From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1075: marked as done (23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color) Date: Mon, 24 Nov 2008 20:55:04 -0800 Message-ID: References: <0419D148-710C-48C8-9817-2D323CE8C693@gmail.com> <48E62E8B.5010905@lysator.liu.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1227588904-8566-0" X-Trace: ger.gmane.org 1227590070 7190 80.91.229.12 (25 Nov 2008 05:14:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Nov 2008 05:14:30 +0000 (UTC) To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 25 06:15:32 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L4qFT-0004PQ-LO for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Nov 2008 06:15:30 +0100 Original-Received: from localhost ([127.0.0.1]:36564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4qEI-0004q6-FG for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Nov 2008 00:12:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4qCd-0004F5-V7 for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2008 00:11:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4qCb-0004Df-UW for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2008 00:11:11 -0500 Original-Received: from [199.232.76.173] (port=58839 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4qCb-0004DW-8D for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2008 00:11:09 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50448) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L4qCZ-0002Fe-Pc for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2008 00:11:09 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP5AAhk013815; Mon, 24 Nov 2008 21:10:12 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mAP4t4x8008689; Mon, 24 Nov 2008 20:55:04 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1075 X-Emacs-PR-Package: emacs,ns X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22674 Archived-At: This is a multi-part message in MIME format... ------------=_1227588904-8566-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 24 Nov 2008 23:46:03 -0500 with message-id <0419D148-710C-48C8-9817-2D323CE8C693@gmail.com> and subject line #1075 - 23.0.60; [NS] wrong number of arguments in call to= ns_free_indexed_color - Emacs bug report logs has caused the Emacs bug report #1075, regarding 23.0.60; [NS] wrong number of arguments in call to ns_free_indexe= d_color to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1075: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1075 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1227588904-8566-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Oct 2008 14:39:26 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93EdI15006310 for ; Fri, 3 Oct 2008 07:39:19 -0700 Received: from mx10.gnu.org ([199.232.76.166]:39594) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kllm9-0004NV-4R for emacs-pretest-bug@gnu.org; Fri, 03 Oct 2008 10:37:01 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KlloH-0006uL-NB for emacs-pretest-bug@gnu.org; Fri, 03 Oct 2008 10:39:17 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:35838) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KlloH-0006tN-AZ for emacs-pretest-bug@gnu.org; Fri, 03 Oct 2008 10:39:13 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id A3ABC40018 for ; Fri, 3 Oct 2008 16:39:10 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1674) id 9756040029; Fri, 3 Oct 2008 16:39:10 +0200 (CEST) Received: from [172.17.0.4] (90-227-135-28-no52.tbcn.telia.com [90.227.135.28]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTP id F2C7840018 for ; Fri, 3 Oct 2008 16:39:07 +0200 (CEST) Message-ID: <48E62E8B.5010905@lysator.liu.se> Date: Fri, 03 Oct 2008 16:39:07 +0200 From: Lennart Staflin User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) After a crash I with ns_free_indexed_color, and x_clear_image_1 on the stack. I noticed that x_clear_image_1 calls ns_free_indexed_color with only one argument, but it takes two arguments. Perhaps that explains a number of crashes in ns_free_indexed_color. //Lennart Staflin In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0) of 2008-10-03 on sin Windowing system distributor `Apple', version 49.46.48 configured using `configure '--with-ns' '--enable-maintainer-mode' '--without-x' '--with-jpeg' '--with-gif' '--with-png' 'CFLAGS=-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: show-paren-mode: t auto-insert-mode: t iswitchb-mode: t partial-completion-mode: t recentf-mode: t cua-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t global-auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: M-x r e p o r t SPC b u g Recent messages: Loading /Users/lenst/emacs/lenst-lisp/loaddefs.el (source)...done Loading /Users/lenst/emacs/lenst-lisp/suck.el (source)...done Loading ~/emacs/lenst-lisp/lenst...done Loading /Users/lenst/emacs/lisp/loaddefs.el (source)...done Loading /Users/lenst/src/emorb/loaddefs.el (source)...done Loading /Users/lenst/.recentf...done Cleaning up the recentf list...done (0 removed) Loading paren...done Loading /Users/lenst/.emacs-records...done For information about GNU Emacs and the GNU system, type C-h C-a. ------------=_1227588904-8566-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1075-done) by emacsbugs.donarmstrong.com; 25 Nov 2008 04:46:23 +0000 Received: from smtprelay.b.hostedemail.com (smtprelay0187.b.hostedemail.com [64.98.42.187]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP4kKc8007174 for <1075-done@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 20:46:21 -0800 Received: from filter.hostedemail.com (b-bigip1 [10.5.19.254]) by smtprelay05.b.hostedemail.com (Postfix) with SMTP id E093AD9D62A for <1075-done@emacsbugs.donarmstrong.com>; Tue, 25 Nov 2008 04:46:19 +0000 (UTC) X-SpamScore: 1 Received: from [10.0.1.198] (unknown [72.169.150.82]) (Authenticated sender: arobert@hughes.net) by omf08.b.hostedemail.com (Postfix) with ESMTP for <1075-done@emacsbugs.donarmstrong.com>; Tue, 25 Nov 2008 04:46:15 +0000 (UTC) Message-Id: <0419D148-710C-48C8-9817-2D323CE8C693@gmail.com> From: Adrian Robert To: 1075-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: #1075 - 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color - Emacs bug report logs Date: Mon, 24 Nov 2008 23:46:03 -0500 X-Mailer: Apple Mail (2.929.2) X-session-marker: 61726F62657274406875676865732E6E6574 I am closing this bug. The call to ns_free_indexed_color() in x_clear_image_1() (image.c:1625) had no business being there -- that color is not indexed, but a long RGB value derived from four_corners_best() or x_alloc_image_color() (which eventually calls ns_defined_color() with makeIndex=0). I checked in a removal as of 11/24, after closer examination prompted by yet another posting bug #1362. Hopefully this is the end of this! ------------=_1227588904-8566-0--