bug#1073: marked as done (23.0.60; Bad interaction between compilation-scroll-output and dedicated windows)

[don@donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]


Your message dated Sat, 04 Oct 2008 12:07:37 +0200
with message-id <48E74069.6000809@gmx.at>
and subject line Re: bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated	windows
has caused the Emacs bug report #1073,
regarding 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1073: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1073
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4205 bytes --]

From: Lawrence Mitchell <wence@gmx.li>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows
Date: Fri, 03 Oct 2008 10:20:21 +0100
Message-ID: <?fnord?y3h6skre827e.fsf@ID-97657.user.individual.net>

In GNU Emacs 23.0.60.3 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-09-24 on lamacq.ph.ed.ac.uk
Windowing system distributor `The X.Org Foundation', version 11.0.60802000
configured using `configure  '-C' '--prefix=/scratch/s0198183/applications/emacs-trunk/' 'CFLAGS=-ggdb3 -O0' '--without-rsvg''

If an Emacs frame is split into multiple windows (two will do) of
which one is dedicated and compilation-scroll-output is t then
`compile' in the non-dedicated window will end up moving point.

Steps to reproduce:

emacs -Q --eval \
'(progn 
  (split-window-vertically)
  (set-window-dedicated-p (selected-window) t)
  (switch-to-buffer-other-window "*test*")
  (insert initial-scratch-message)
  (goto-char (point-min))
  (setq compilation-scroll-output t)
  (compile "echo \"test\"")
  (kill-buffer "*compilation*"))'

Note how point is left at the /end/ of the buffer *test* rather
than the beginning.  This appears to be a problem with a mismatch
between what `selected-window' and `current-buffer' return.

When this code in `compilation-start' is executed:

    (if (buffer-local-value 'compilation-scroll-output outbuf)
	(save-selected-window
	  (select-window outwin)
	  (goto-char (point-max))))

outwin is #<window 13 on *compilation*>
and after the select-window call (selected-window) is #<window 13
on *compilation*>.  However, at this point (current-buffer)
returns *test*, rather than *compilation*.

Cheers,
Lawrence
-- 
Lawrence Mitchell <wence@gmx.li>



[-- Attachment #3: Type: message/rfc822, Size: 1735 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 1073-done@emacsbugs.donarmstrong.com
Cc: Lawrence Mitchell <wence@gmx.li>
Subject: Re: bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated	windows
Date: Sat, 04 Oct 2008 12:07:37 +0200
Message-ID: <48E74069.6000809@gmx.at>

I checked in a slightly different fix.  Please have a look.

Thanks, martin.