From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1062: marked as done (23.0.60; minibuffer-completion-help incomplete) Date: Sat, 8 Nov 2008 09:05:04 -0800 Message-ID: References: <87bpwq6tqt.fsf@cyd.mit.edu> <87od24ljmz.fsf@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1226163904-21278-0" X-Trace: ger.gmane.org 1226164310 30581 80.91.229.12 (8 Nov 2008 17:11:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Nov 2008 17:11:50 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 08 18:12:53 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KyrMg-0003bB-Qy for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Nov 2008 18:12:51 +0100 Original-Received: from localhost ([127.0.0.1]:42913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyrLZ-0001YH-Cd for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Nov 2008 12:11:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KyrK6-0000kZ-Kw for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 12:10:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KyrK5-0000k6-Ir for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 12:10:10 -0500 Original-Received: from [199.232.76.173] (port=35859 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyrK5-0000k1-Ek for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 12:10:09 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40563) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KyrK5-00085V-0M for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 12:10:09 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA8HA6Qa023221; Sat, 8 Nov 2008 09:10:06 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mA8H54wp021795; Sat, 8 Nov 2008 09:05:04 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1062 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22224 Archived-At: This is a multi-part message in MIME format... ------------=_1226163904-21278-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 08 Nov 2008 11:57:14 -0500 with message-id <87bpwq6tqt.fsf@cyd.mit.edu> and subject line Re: 23.0.60; minibuffer-completion-help incomplete has caused the Emacs bug report #1062, regarding 23.0.60; minibuffer-completion-help incomplete to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1062: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1062 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1226163904-21278-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.2 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 1 Oct 2008 10:01:07 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m91A10pd028626 for ; Wed, 1 Oct 2008 03:01:01 -0700 Received: from mail.gnu.org ([199.232.76.166]:57550 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KkyTm-0006sn-3f for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 05:58:46 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KkyVu-0001xQ-3x for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 06:00:59 -0400 Received: from mail.gmx.net ([213.165.64.20]:48756) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KkyVt-0001ws-Hj for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 06:00:57 -0400 Received: (qmail invoked by alias); 01 Oct 2008 10:00:54 -0000 Received: from i5387D545.versanet.de (EHLO escher.local.home) [83.135.213.69] by mail.gmx.net (mp006) with SMTP; 01 Oct 2008 12:00:54 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19M5hhfrd5MZt6yU9XTrGS2xEaLtaEYGZDOixbg// jSvOSFtPB+mknT Received: by escher.local.home (Postfix, from userid 1000) id D87677FBB1; Wed, 1 Oct 2008 12:00:52 +0200 (CEST) From: Stephen Berman To: emacs-pretest-bug@gnu.org Subject: 23.0.60; minibuffer-completion-help incomplete Sender: steve@escher.local.home Date: Wed, 01 Oct 2008 12:00:52 +0200 Message-ID: <87od24ljmz.fsf@escher.local.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. GNU Emacs 23.0.60.5 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-10-01 on escher 1. emacs -Q 2. Let some directory contain the files "tested" and "Testing" and no other files beginning with "test" or "Test". 3. M-x set-variable RET read-file-name-completion-ignore-case RET t RET 4. C-x C-f /test 5. Now type TAB or "?" and a *Completions* buffer pops that shows only "tested" as a possible completion. However, typing "i" next and then TAB does complete to "Testing". If before doing step 4 completion-styles is set to (emacs22), then after the first TAB or ? in step 5 the *Completions* buffer shows both "tested" and "Testing". The following patch makes the *Completions* buffer show all possible completions in step 5 also with the default completion-style basic, but I don't know if it has undesirable consequences elsewhere. Steve Berman *** emacs/lisp/minibuffer.el.~1.58.~ 2008-09-04 16:16:19.000000000 +0200 --- emacs/lisp/minibuffer.el 2008-10-01 11:42:40.000000000 +0200 *************** *** 1316,1322 **** "" (list (substring beforepoint (car bounds)) 'point (substring afterpoint 0 (cdr bounds))))) ! (all (completion-pcm--all-completions prefix pattern table pred))) (completion-hilit-commonality (if (consp all) (nconc all (car bounds)) all) point))) --- 1316,1324 ---- "" (list (substring beforepoint (car bounds)) 'point (substring afterpoint 0 (cdr bounds))))) ! (all (if completion-ignore-case ! (all-completions (substring string 0 point) table pred) ! (completion-pcm--all-completions prefix pattern table pred)))) (completion-hilit-commonality (if (consp all) (nconc all (car bounds)) all) point))) ------------=_1226163904-21278-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1062-done) by emacsbugs.donarmstrong.com; 8 Nov 2008 16:57:06 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA8Gv3st019716 for <1062-done@emacsbugs.donarmstrong.com>; Sat, 8 Nov 2008 08:57:05 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id F222D57E195; Sat, 8 Nov 2008 11:57:14 -0500 (EST) From: Chong Yidong To: Stephen Berman Cc: 1062-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.60; minibuffer-completion-help incomplete Date: Sat, 08 Nov 2008 11:57:14 -0500 Message-ID: <87bpwq6tqt.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > 1. emacs -Q > 2. Let some directory contain the files "tested" and "Testing" and no > other > files beginning with "test" or "Test". > 3. M-x set-variable RET read-file-name-completion-ignore-case RET t RET > 4. C-x C-f /test > 5. Now type TAB or "?" and a *Completions* buffer pops that shows only > "tested" as a possible completion. However, typing "i" next and then > TAB does complete to "Testing". > > The following patch makes the *Completions* buffer show all possible > completions in step 5 also with the default completion-style basic, but > I don't know if it has undesirable consequences elsewhere. The bug was actually in the C code: file-name-all-completions did not handle completion-regexp-list properly. I've checked in a fix. Thanks for the bug report. ------------=_1226163904-21278-0--