* bug#37165: lookup-family-specification test fails
@ 2019-08-23 19:29 Glenn Morris
2019-08-24 13:00 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2019-08-23 19:29 UTC (permalink / raw)
To: 37165; +Cc: rpluim
Package: emacs
Severity: minor
Version: 27.0.50
The test lookup-family-specification fails on hydra.nixos.org:
google.com/0 Name or service not known
Test lookup-family-specification condition:
(ert-test-failed
((should
(network-lookup-address-info "google.com" 'ipv4))
:form
(network-lookup-address-info "google.com" ipv4)
:value nil))
FAILED 1/18 lookup-family-specification (0.002023 sec)
Perhaps the system doesn't having working DNS, in which case you
probably just want to add
(skip-unless (not (getenv "EMACS_HYDRA_CI")))
I suppose this could be true of other systems too, but don't know how
you check that.
Note that test lookup-google passes, but based on the above it should not.
(should (length X)) seems like a buggy test condition (it passes when X
is nil).
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#37165: lookup-family-specification test fails
2019-08-23 19:29 bug#37165: lookup-family-specification test fails Glenn Morris
@ 2019-08-24 13:00 ` Robert Pluim
2019-09-02 15:32 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2019-08-24 13:00 UTC (permalink / raw)
To: Glenn Morris; +Cc: 37165
>>>>> On Fri, 23 Aug 2019 15:29:18 -0400, Glenn Morris <rgm@gnu.org> said:
GM> Package: emacs
GM> Severity: minor
GM> Version: 27.0.50
GM> The test lookup-family-specification fails on hydra.nixos.org:
GM> google.com/0 Name or service not known
GM> Test lookup-family-specification condition:
GM> (ert-test-failed
GM> ((should
GM> (network-lookup-address-info "google.com" 'ipv4))
GM> :form
GM> (network-lookup-address-info "google.com" ipv4)
GM> :value nil))
GM> FAILED 1/18 lookup-family-specification (0.002023 sec)
GM> Perhaps the system doesn't having working DNS, in which case you
GM> probably just want to add
GM> (skip-unless (not (getenv "EMACS_HYDRA_CI")))
OK, Iʼve added that where appropriate.
GM> I suppose this could be true of other systems too, but don't know how
GM> you check that.
By doing a DNS lookup :-)
GM> Note that test lookup-google passes, but based on the above it should not.
GM> (should (length X)) seems like a buggy test condition (it passes when X
GM> is nil).
Yes, plus some others pass that shouldn't. Should be fixed now.
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-02 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-23 19:29 bug#37165: lookup-family-specification test fails Glenn Morris
2019-08-24 13:00 ` Robert Pluim
2019-09-02 15:32 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).