From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#24494: 24.4; Trailing comma in emacs-module.h Date: Mon, 12 Dec 2016 17:35:53 -0500 Message-ID: References: <87fuotnupa.fsf@wellocc1-ares.jhuapl.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481582235 27456 195.159.176.226 (12 Dec 2016 22:37:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Dec 2016 22:37:15 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 24494@debbugs.gnu.org To: Christopher Wellons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 12 23:37:06 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGZDV-0005oX-0v for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Dec 2016 23:37:05 +0100 Original-Received: from localhost ([::1]:33896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZDZ-0002LH-7K for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Dec 2016 17:37:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZDT-0002Jv-DE for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 17:37:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZDS-0001ff-6b for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 17:37:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52532) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cGZDS-0001fQ-2z for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 17:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cGZDR-0003Xu-QQ for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 17:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2016 22:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24494 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24494-submit@debbugs.gnu.org id=B24494.148158216913549 (code B ref 24494); Mon, 12 Dec 2016 22:37:01 +0000 Original-Received: (at 24494) by debbugs.gnu.org; 12 Dec 2016 22:36:09 +0000 Original-Received: from localhost ([127.0.0.1]:39698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGZCa-0003WT-VG for submit@debbugs.gnu.org; Mon, 12 Dec 2016 17:36:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGZCZ-0003WE-Bs for 24494@debbugs.gnu.org; Mon, 12 Dec 2016 17:36:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZCT-0001SL-4f for 24494@debbugs.gnu.org; Mon, 12 Dec 2016 17:36:02 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZCM-0001Qq-02; Mon, 12 Dec 2016 17:35:54 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cGZCL-0006g1-Ii; Mon, 12 Dec 2016 17:35:53 -0500 X-Spook: Torreon insurgency 9705 Samford Road asset Operation X-Ran: "F/tP@42Tk~_BH*6"CiY/Wf`k7MY)v)Xm$D66q:h!V"lf4_a7MD|'Mz}vPcbev~tfZa.:M X-Hue: cyan X-Attribution: GM In-Reply-To: <87fuotnupa.fsf@wellocc1-ares.jhuapl.edu> (Christopher Wellons's message of "Wed, 21 Sep 2016 11:22:57 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126937 Archived-At: Christopher Wellons wrote: > Building Emacs itself now requires a C99 compiler, but this requirement > needn't extend to dynamic modules. Removing a trailing comma (see patch) > makes emacs-module.h C89/C90 compatible, allowing modules to be built > using older C compilers. Trailing commas weren't permitted until C99. Thanks for the report. I don't have an opinion, but some comments: 1) I think it's going to be hard for developers to remember to use different conventions for emacs-module.h, so C99-isms are likely to creep back in. 2) Are people really likely to be building Emacs modules with set-ups that can't build Emacs itself? 3) It seems this feature was supported by gcc since 0.9? Ie, forever? https://www.gnu.org/software/gcc/c99status.html Hopefully someone who does have an opinion will quickly either fix or wontfix this issue. :) > diff --git a/src/emacs-module.h b/src/emacs-module.h > --- a/src/emacs-module.h > +++ b/src/emacs-module.h > @@ -67,7 +67,7 @@ enum emacs_funcall_exit > emacs_funcall_exit_signal = 1, > > /* Function has exit using `throw'. */ > - emacs_funcall_exit_throw = 2, > + emacs_funcall_exit_throw = 2 > }; > > struct emacs_env_25