From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
To: 47620@debbugs.gnu.org
Subject: bug#47620: [PATCH] Allow complex key bindings in project-switch-project
Date: Tue, 06 Apr 2021 16:57:31 +0200 [thread overview]
Message-ID: <fv2zojpmz7lauc.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Hi,
project-switch-project currently only allows for single-char bindings to
be used for its commands. Starting with emacs -Q, evaluate
(require 'project)
(define-key project-prefix-map (kbd "M-s g") 'rgrep)
(add-to-list 'project-switch-commands '(rgrep "grep"))
and then run project-switch-project (by default bound to C-x p p) and
choose a project (hopefully you already have one available). You will
see "[M-s g] grep" shown in the prompt, but you will not be able to
choose it by typing M-s g.
The patch attached bellow allows for any kind of key binding to be used.
Admittedly, there may be a better way to do it since I did not spend
much time looking into it.
Please, share your thoughts.
Best regards,
Dario
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Allow complex key bindings in project-switch-project --]
[-- Type: text/x-diff, Size: 2570 bytes --]
From dbd256fced765e55bbe8a589874490a121546ae1 Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
Date: Tue, 6 Apr 2021 16:51:28 +0200
Subject: [PATCH] Allow complex key bindings in project-switch-project
* lisp/progmodes/project.el (project-switch-project): Replace
read-event with an overriding local map and read-key-sequence to allow
for complex key bindings to be read.
---
lisp/progmodes/project.el | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 910f70db03..84d02e25d9 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1338,23 +1338,27 @@ made from `project-switch-commands'.
When called in a program, it will use the project corresponding
to directory DIR."
(interactive (list (project-prompt-project-dir)))
- (let ((commands-menu
- (mapcar
- (lambda (row)
- (if (characterp (car row))
- ;; Deprecated format.
- ;; XXX: Add a warning about it?
- (reverse row)
- row))
- project-switch-commands))
- command)
+ (let* ((commands-menu
+ (mapcar
+ (lambda (row)
+ (if (characterp (car row))
+ ;; Deprecated format.
+ ;; XXX: Add a warning about it?
+ (reverse row)
+ row))
+ project-switch-commands))
+ (commands-map
+ (let ((temp-map (make-sparse-keymap)))
+ (set-keymap-parent temp-map project-prefix-map)
+ (dolist (row commands-menu temp-map)
+ (when-let ((cmd (nth 0 row))
+ (keychar (nth 2 row)))
+ (define-key temp-map (vector keychar) cmd)))))
+ command)
(while (not command)
- (let ((choice (read-event (project--keymap-prompt))))
- (when (setq command
- (or (car
- (seq-find (lambda (row) (equal choice (nth 2 row)))
- commands-menu))
- (lookup-key project-prefix-map (vector choice))))
+ (let ((overriding-local-map commands-map)
+ (choice (read-key-sequence (project--keymap-prompt))))
+ (when (setq command (lookup-key commands-map choice))
(unless (or project-switch-use-entire-map
(assq command commands-menu))
;; TODO: Add some hint to the prompt, like "key not
--
2.31.GIT
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
--
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid
next reply other threads:[~2021-04-06 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 14:57 Dario Gjorgjevski [this message]
2021-04-07 0:28 ` bug#47620: [PATCH] Allow complex key bindings in project-switch-project Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fv2zojpmz7lauc.fsf@gmail.com \
--to=dario.gjorgjevski@gmail.com \
--cc=47620@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).