From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Mon, 28 Dec 2020 20:48:50 +0100 Message-ID: References: <87sgbsv7gg.fsf@gmail.com> <877dp1kfzz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17748"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42149@debbugs.gnu.org, Stefan Monnier To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 28 20:50:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktyWx-0004Uu-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 20:50:11 +0100 Original-Received: from localhost ([::1]:35754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktyWw-0006WQ-IX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 14:50:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktyWn-0006Uq-W6 for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 14:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktyWn-0004Gt-N0 for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 14:50:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktyWn-0002c3-Hh for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 14:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2020 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.16091849439971 (code B ref 42149); Mon, 28 Dec 2020 19:50:01 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 28 Dec 2020 19:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:36941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktyVq-0002al-OK for submit@debbugs.gnu.org; Mon, 28 Dec 2020 14:49:02 -0500 Original-Received: from mail-ed1-f52.google.com ([209.85.208.52]:43736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktyVl-0002aB-NS for 42149@debbugs.gnu.org; Mon, 28 Dec 2020 14:49:01 -0500 Original-Received: by mail-ed1-f52.google.com with SMTP id y24so10699729edt.10 for <42149@debbugs.gnu.org>; Mon, 28 Dec 2020 11:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Z9VU8uXtZRlh8Fh7uNhqQRa2Pq+YJxuyY7Ps7S5miEw=; b=YSeOevILWC2kg4xouZV3YbrHYcNNjxBq4B69eZAXQ2caXEdNwKYTtC+bVXcLCRc6ce 2Tlx1W7erFJp9y+n2gESS575ZFnbVNPdszv5pa6gbvWoPqb9mV+OyRuBz6g46WSd6W+T d8DuPhwJNooQh4SXz5rSklR6KYnrchSeNOUpnbeULrV5jG5UHZdxuAC4v/0NF/Yfp/L1 txhBrWGf5c3gvm+R2GxuLwKP4QOdLUKZDgsmeSp/HNiJG0ybWBd9dJ+yHa0uViQTbWVI TAniOWZvJgOtqHnv3PKeX0SmAvpP3Z3eaQ0QLmsB4b059jYi7kr5vSk66Zo7h9XiE4yA giig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Z9VU8uXtZRlh8Fh7uNhqQRa2Pq+YJxuyY7Ps7S5miEw=; b=X2LyE6Lt37o3MTo7MDbjUErUE4/T+oqyNx0uUPCkjUGuIgfdZ3HdeXuzOi1WgMSmqN IfW0hfdtkJOpufsHNU5MRWItPJvCCsVfwDRE/AzfX4l4809MpALGewJ/tRFaW8eukmhV hR6urG0qJfYzVonRQT43iNCqdbHtDKdMNU1vARtqp58Mqp6gAAlflpgHFrFZOBzgtrms fRAevA9bfQMinfVilwYSmYlMfe4l1JzIt70ICQ7f1zzE2lwZZVGSJs4hc95lSvFrYb7d CYodStZop1BmvGdu/9Opjc215sl5VqoW+dsbsHRr7G1UyyfoGLqa00PXJCLUp8Pcy30k PkYw== X-Gm-Message-State: AOAM532kHomQekixNn5J3dSswSusK92tlQTlbC4EusxW81LhrwJN3zvI y9whZRce73miAzaJzQ0+HUfA42/XXgo= X-Google-Smtp-Source: ABdhPJygXas+tE4mjZzSnipcSwLwe11CAiPc1mOlDGDBAiS+AeQSIOBDP2Nv0/GDXx0VP2yvzU6AZw== X-Received: by 2002:a05:6402:2074:: with SMTP id bd20mr42745224edb.326.1609184931549; Mon, 28 Dec 2020 11:48:51 -0800 (PST) Original-Received: from ZALANDO-31298 (p200300e9772150b2a1d656ddd4cf4854.dip0.t-ipconnect.de. [2003:e9:7721:50b2:a1d6:56dd:d4cf:4854]) by smtp.gmail.com with ESMTPSA id b19sm36384877edx.47.2020.12.28.11.48.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Dec 2020 11:48:51 -0800 (PST) In-Reply-To: <877dp1kfzz.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 28 Dec 2020 17:16:48 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196893 Archived-At: >> In the example you show, I think overlapping *is* as good a behavior as >> any other (and the code is careful to to replace one face with the >> other > > I agree with this general idea. I think we have to be careful to write > tests in terms of user experience as much as possible. For example, in > the very latest version of the code I pushed, I still have one of > Dario's original tests failing (down to only two now). Makes sense. I had misunderstood the purpose of the face. Overlapping is indeed fine -- for all I care, we can also avoid putting it altogether in cases where there is no _first character to type_ (without moving point). But again, the current behavior is OK. In that case, the tests should be changed. >>> This is good (consecutive `any` can introduce serious performance >>> bugs because of our backtracing regexp matcher). Other than >>> improving performance, have you found other effects? >> >> Yes, the presence of multiple consecutive wildcards invalidates the >> aforementioned assumption of completion-pcm--hilit-commonality that >> the match is of the form >> >> ... > > Makes sense, thank you. I think this elimination of consecutive `any' should also be included in Jo=C3=A3o=E2=80=99s branch. Best regards, Dario --=20 $ keyserver=3Dhkps://hkps.pool.sks-keyservers.net $ keyid=3D744A4F0B4F1C9371 $ gpg --keyserver $keyserver --search-keys $keyid