From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Wed, 14 Oct 2020 11:01:51 +0200 Message-ID: References: <87k0znsdjb.fsf@gmail.com> <87sgbsv7gg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42149@debbugs.gnu.org, Stefan Monnier To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 11:02:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kScfn-0004pj-4W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 11:02:15 +0200 Original-Received: from localhost ([::1]:44060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kScfm-0007Bg-0t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 05:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kScfc-0007BV-5Z for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 05:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kScfa-0004L3-SY for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 05:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kScfa-0008NE-QN for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 05:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.160266612132107 (code B ref 42149); Wed, 14 Oct 2020 09:02:02 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 14 Oct 2020 09:02:01 +0000 Original-Received: from localhost ([127.0.0.1]:50053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScfY-0008LX-S2 for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:02:01 -0400 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:41048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScfX-0008GP-3Q for 42149@debbugs.gnu.org; Wed, 14 Oct 2020 05:01:59 -0400 Original-Received: by mail-ed1-f47.google.com with SMTP id l24so2303347edj.8 for <42149@debbugs.gnu.org>; Wed, 14 Oct 2020 02:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=R6nlBstWMOTXQdXU4cr4D2DCxy7TUfL+lBgI0koozvo=; b=iRmEK+pTwviCQN4bVAjlk9AvVG910uWDN3japOJRaGddWBq33RE+zakO/iY+mGNjJk SJV/GOn9Mm7EcosAk7f7SIqFtHnTDWDGqfBP+k2ywSE8foMPDufsuVz4woZTpSz03+ef uf1dZqHhQDnNDRgNg1EcruUeyxVOXACvt4pbQI558SVbFL7Z1WO6j7w1hVS3jT4Mm9UW XZSN6jLXBmUg/i4rzDeI5zEFz2oaszqiEDM61KBi/9oDQ5AAPT35iUJ9j2j028lK0Yb7 8eGXOb849Kj5DqY9hlJjvpPKIgx9sEzUnKLBpFsvSKURRH56rAAKoQKnDFQ6K0rIP7eS /9lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=R6nlBstWMOTXQdXU4cr4D2DCxy7TUfL+lBgI0koozvo=; b=nmaq8m/rxS79VWUg+C1euRM+Jj6nodYlCPL5I9n6vLggePf0jPMnj16mAQO+2vyrql wwFQLkGZGVBCnzV5iUW4CO6KqXI0+Rx5b1gAQx4INyrKIl3ab8eNtudupk09QV+Z1K5A rhqJHtoPySQHFGkVtLWPmwZG3MD1MTySLgky/qcXKujOp1avSU+E8tpqEtr0FTzECspk SUSetSegBDfO/uwhzvuJ4WFK9voGOH4YcTNEFcj0TWE+TXg88ojkNu2wbJBwJptXj60U dLpDK2WvLBDsM+7VntNM0jYV5t+8fjHVdsk2AXRbD8hyVQUGneHeNxDqYlT5lIu5i7UV a1Yg== X-Gm-Message-State: AOAM531xmuCm1FYlc9az8jwT7k3wbqUbqvdCPG7+MFgkmyQWXcMMYkCQ /E1/BXSU35bgqnqhJRJL7BE53sDcOnub0A== X-Google-Smtp-Source: ABdhPJwqnisNBnFHYTFDAWoA3+hY5CeCqEhteBibTcL46ktV/DFTthSSzZBA5EWnKUzL4dOrqcxYZg== X-Received: by 2002:aa7:c2ca:: with SMTP id m10mr3911491edp.255.1602666112878; Wed, 14 Oct 2020 02:01:52 -0700 (PDT) Original-Received: from ZALANDO-31298 ([79.140.120.73]) by smtp.gmail.com with ESMTPSA id d12sm1291379ejt.105.2020.10.14.02.01.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Oct 2020 02:01:52 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 14 Oct 2020 09:39:47 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190496 Archived-At: Hi Jo=C3=A3o, > Sorry for the delay in handling this. No problem; it=E2=80=99s not a very critical bug after all, just an annoying one. > 1. Question: if I compile and/or evaluate the changes to the > test/lisp/minibuffer-tests.el file but _don't_ compile the changes > to the lisp/minibuffer.el file, will they expose this bug and this > bug only? In other words, will I get exactly the same failures > that you describe originally in this issue and will that fact be > apparent in the failure message(s)? Yes. As for how apparent they=E2=80=99ll be, well, I guess that=E2=80=99s = up to ERT. You will get something along the lines of (ert-test-failed ((should (eql (get-text-property 0 'completion-score (car ...)) 1.0)) :form (eql 0.0 1.0) :value nil)) Which says that the =E2=80=98completion-score=E2=80=99 was 0 but should hav= e been 1, as indicated in the bug report. Of course, some of the tests are more general tests for the sake of catching regressions. > 2. Question: are the changes to completion-pcm--optimize-pattern > an optimization or does the fix above depend on them? If the > former, could you make it a separate commit? Unfortunately, the fix loosely depends on them. Without them, having multiple consecutive =E2=80=9C*=E2=80=9D would mess up the PCM scoring. > 3. Nitpick: the commit message is broadly according to the > format, but I find it hard to parse its intentions. Though > conventions vary, I usually like to format the commit message > like in this example which separates the what, the why and > the how. Thanks for both the remark and the useful example. I will fix it and come back with a new patch. Best regards, Dario --=20 dario.gjorgjevski@gmail.com :: +49 1525 8666837 % gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \ \`> --recv-keys '744A4F0B4F1C9371'