bug#2707: 23.0.91; RMAIL summary not in step with main file

bug#2707: 23.0.91; RMAIL summary not in step with main file

[jpff]

Reading a mail file I deleted most of them and then saved.  The
-summary window still showed the headings with messages marked as
deleted when they had been expunged.  This is a change from recent versions


In GNU Emacs 23.0.91.22 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2009-03-18 on cardew
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  auto-image-file-mode: t
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
b <return> <left> <left> + 1 C-x C-s C-x b <return> 
s C-x k <return> C-x C-f J u n <tab> <return> M-x r 
m <tab> a <tab> - m <tab> o <tab> <return> h C-x C-f 
S P <tab> A <tab> <return> <down> 1 2 9 + C-x b <return> 
<escape> < <down> <down> <down> <down> d d d d d d 
d d d d d d d d d d d d d d d d d d d d d d d d d d 
d d d SPC d SPC d d d d d d d SPC d d d d d d d d d 
d d d d d d d d d d d d d d d d d d d d d d d d d d 
d d d d d d d d d d d d d d d d d d d d d d d d d d 
d d d d d d d d d d d d d d d d d d d d SPC SPC d < 
<down-mouse-1> <mouse-movement> <mouse-movement> <mouse-1> 
M-s @ c o d e m i s t <return> M-s <return> C-o / m 
n t / s b o u t <backspace> <backspace> <backspace> 
<backspace> n o u t / h o m <tab> j p f f / S P A <tab> 
M a <tab> <return> t <down-mouse-1> <mouse-movement> 
<mouse-movement> <drag-mouse-1> M-s <return> t M-s 
<return> s y C-x b <return> <next> <backspace> - 4 
+ 6 5 <return> 2 1 SPC M a r SPC 2 0 0 9 : <tab> <backspace> 
SPC <return> C-x b <return> s C-x k <return> M-m C-x 
k <return> M-x r e p o r <tab> <return>

Recent messages:
Rmail search for @codemist...
Search failed: @codemist
Erase deleted messages from Rmail file? (y or n) 
Expunging deleted messages...done
Saving file /home/jpff/Junky...
Wrote /home/jpff/Junky
call-interactively: End of buffer
Expunging deleted messages...done
(No changes need to be saved)
Auto save file for draft message exists; consider M-x mail-recover

==John ffitch

bug#2707: 23.0.91; RMAIL summary not in step with main file

[Glenn Morris]

jpff wrote:

> Reading a mail file I deleted most of them and then saved.  The
> -summary window still showed the headings with messages marked as
> deleted when they had been expunged.

(You need to use `s' rather than `x' to see this problem.)

This is a consequence of the following change. Now rmail-expunge does
not update the summary if called with dont-show non-nil.


2009-03-16  Richard M Stallman  <rms at gnu.org>

* mail/rmail.el (rmail-expunge): Show the message only once, and only
  if needed. If the current message was current before, just re-swap.

bug#2707: 23.0.91; RMAIL summary not in step with main file

[Richard M Stallman]

    This is a consequence of the following change. Now rmail-expunge does
    not update the summary if called with dont-show non-nil.

When DONT-SHOW is non-nil, should rmail-expunge do this, or should the
caller do it?

The reason I am not sure is that the code seems to expect that summary
manipulation to also do the job of showing the message, and DONT-SHOW
says not to do that.

bug#2707: 23.0.91; RMAIL summary not in step with main file

[Glenn Morris]

Richard M Stallman wrote:

> When DONT-SHOW is non-nil, should rmail-expunge do this, or should the
> caller do it?

Doesn't matter much. rmail-expunge is only used in two places in all
of Emacs (rmail-expunge-and-save and rmail-quit). Both currently
expect it to update any summary, but it's easy to change.

> The reason I am not sure is that the code seems to expect that summary
> manipulation to also do the job of showing the message, and DONT-SHOW
> says not to do that.

The DONT-SHOW argument is new (and undocumented...), so you can make
it do whatever you like.

bug#2707: 23.0.91; RMAIL summary not in step with main file

[Richard M Stallman]

I fixed that.  Could you close the bug report?

bug#2707: marked as done (23.0.91; RMAIL summary not in step with main file)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]


Your message dated Mon, 23 Mar 2009 13:15:52 -0400
with message-id <dnvdq06tyv.fsf@fencepost.gnu.org>
and subject line Re: bug#2707: 23.0.91; RMAIL summary not in step with main file
has caused the Emacs bug report #2707,
regarding 23.0.91; RMAIL summary not in step with main file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2707: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2707
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4891 bytes --]

From: jpff <jpff@codemist.co.uk>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.91; RMAIL summary not in step with main file
Date: Wed, 18 Mar 2009 07:33:26 +0000
Message-ID: <9424-Wed18Mar2009073326+0000-jpff@codemist.co.uk>

Reading a mail file I deleted most of them and then saved.  The
-summary window still showed the headings with messages marked as
deleted when they had been expunged.  This is a change from recent versions


In GNU Emacs 23.0.91.22 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2009-03-18 on cardew
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  auto-image-file-mode: t
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
b <return> <left> <left> + 1 C-x C-s C-x b <return> 
s C-x k <return> C-x C-f J u n <tab> <return> M-x r 
m <tab> a <tab> - m <tab> o <tab> <return> h C-x C-f 
S P <tab> A <tab> <return> <down> 1 2 9 + C-x b <return> 
<escape> < <down> <down> <down> <down> d d d d d d 
d d d d d d d d d d d d d d d d d d d d d d d d d d 
d d d SPC d SPC d d d d d d d SPC d d d d d d d d d 
d d d d d d d d d d d d d d d d d d d d d d d d d d 
d d d d d d d d d d d d d d d d d d d d d d d d d d 
d d d d d d d d d d d d d d d d d d d d SPC SPC d < 
<down-mouse-1> <mouse-movement> <mouse-movement> <mouse-1> 
M-s @ c o d e m i s t <return> M-s <return> C-o / m 
n t / s b o u t <backspace> <backspace> <backspace> 
<backspace> n o u t / h o m <tab> j p f f / S P A <tab> 
M a <tab> <return> t <down-mouse-1> <mouse-movement> 
<mouse-movement> <drag-mouse-1> M-s <return> t M-s 
<return> s y C-x b <return> <next> <backspace> - 4 
+ 6 5 <return> 2 1 SPC M a r SPC 2 0 0 9 : <tab> <backspace> 
SPC <return> C-x b <return> s C-x k <return> M-m C-x 
k <return> M-x r e p o r <tab> <return>

Recent messages:
Rmail search for @codemist...
Search failed: @codemist
Erase deleted messages from Rmail file? (y or n) 
Expunging deleted messages...done
Saving file /home/jpff/Junky...
Wrote /home/jpff/Junky
call-interactively: End of buffer
Expunging deleted messages...done
(No changes need to be saved)
Auto save file for draft message exists; consider M-x mail-recover

==John ffitch



[-- Attachment #3: Type: message/rfc822, Size: 1970 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: rms@gnu.org
Cc: 2707-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2707: 23.0.91; RMAIL summary not in step with main file
Date: Mon, 23 Mar 2009 13:15:52 -0400
Message-ID: <dnvdq06tyv.fsf@fencepost.gnu.org>

Richard M Stallman wrote:

> I fixed that.  Could you close the bug report?

Thanks. You close something by sending a mail to "###-done", where ###
is the bug number. Eg in this case, I sent this mail to:

2707-done at emacsbugs.donarmstrong.com