From: Glenn Morris <rgm@gnu.org>
To: Luke Lee <luke.yx.lee@gmail.com>
Cc: 17854@debbugs.gnu.org
Subject: bug#17854: The patch #3 of 3 for hideif.el, a lot of bug fixes and enhancements
Date: Fri, 27 Jun 2014 23:22:29 -0400 [thread overview]
Message-ID: <fgppht90qy.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <75lhsh7qb8.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 27 Jun 2014 21:53:15 -0400")
Glenn Morris wrote:
>> +(defcustom hide-ifdef-header-regexp
>> + "^.*\\.[hH]\\([hH]\\|[xX][xX]\\|[pP][pP]\\)?"
This would be better written as
"\\.[hH]\\([hH]\\|[xX][xX]\\|[pP][pP]\\)?\\'"
(why not just case-fold?)
Also, you match it against buffer-name, which is fragile to things like
uniquify. Seems it would be better to match the file name.
next prev parent reply other threads:[~2014-06-28 3:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 13:51 bug#17854: The patch #3 of 3 for hideif.el, a lot of bug fixes and enhancements Luke Lee
2014-06-26 16:56 ` Glenn Morris
2014-06-26 16:59 ` Glenn Morris
2014-06-27 9:08 ` Luke Lee
2014-06-27 9:26 ` Luke Lee
2014-06-27 9:37 ` Luke Lee
2014-06-28 1:53 ` Glenn Morris
2014-06-28 3:22 ` Glenn Morris [this message]
2014-06-30 14:42 ` Luke Lee
2014-06-30 21:47 ` Stefan Monnier
2014-07-01 1:55 ` Luke Lee
2014-07-01 6:44 ` Glenn Morris
2014-07-03 2:37 ` Luke Lee
2014-07-07 0:02 ` Glenn Morris
2014-07-07 1:00 ` Glenn Morris
2014-07-07 9:05 ` Luke Lee
2014-07-07 9:04 ` Luke Lee
2014-07-07 16:10 ` Glenn Morris
2014-07-08 2:10 ` Luke Lee
2014-07-07 9:04 ` bug#17854: Completed Luke Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fgppht90qy.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=17854@debbugs.gnu.org \
--cc=luke.yx.lee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).