unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Matthias Meulien <orontee@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 75379@debbugs.gnu.org
Subject: bug#75379: 30.0.93; project-find-regexp expects "C" or "en" locale
Date: Mon, 6 Jan 2025 03:55:51 +0200	[thread overview]
Message-ID: <ff8e48df-0439-4447-9253-aa65a908dc84@gutov.dev> (raw)
In-Reply-To: <CAFEQCfA+Osd=PyHpqFq77c5ik=B6=WPvxro0Rndq-9PPMPjh2Q@mail.gmail.com>

On 05/01/2025 23:22, Matthias Meulien wrote:
> 
> I am not familiar with all grep options but I saw that:
> 
> ‘-I’
>       Process a binary file as if it did not contain matching data; this
>       is equivalent to the ‘--binary-files=without-match’ option.
> 
> Just tested
> 
>    (setq xref-search-program-alist '((grep . "xargs -0 grep <C> --null - 
> snHE -I -e <R>"))
> 
> and it works fine on my side.

Thanks, this is a solid proposal, but as per comment:

                  ;; TODO: Show these matches as well somehow?

we would probably want to print these weird matches as well, in the 
future. As you mention, search programs have a flag which avoids 
printing these matches, but in certain rare cases it might happen that a 
mostly text file is detected as binary - and then it seems preferable to 
print all of such matches in the buffer rather than ignore them. (Unless 
people disagree?)

And yeah, it's an old comment, so this improvement is not high on the 
list, but whenever we (I/you/anybody else) get around to implementing 
it, we'd have to change the default entries in xref-search-program-alist 
again - and these get customized by users over the years, which means 
not everybody would get the fix together with the package's or Emacs's 
update. So a fix using other means would be better if feasible.





  parent reply	other threads:[~2025-01-06  1:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-05 10:35 bug#75379: 30.0.93; project-find-regexp expects "C" or "en" locale Matthias Meulien
2025-01-05 18:03 ` Dmitry Gutov
2025-01-05 18:46   ` Eli Zaretskii
2025-01-05 19:35     ` Dmitry Gutov
2025-01-05 20:16       ` Eli Zaretskii
2025-01-07 14:17         ` Dmitry Gutov
2025-01-07 14:23           ` Eli Zaretskii
2025-01-07 14:26             ` Dmitry Gutov
2025-01-07 14:50               ` Eli Zaretskii
2025-01-05 21:22     ` Matthias Meulien
2025-01-05 21:29       ` Matthias Meulien
2025-01-06 13:03         ` Eli Zaretskii
2025-01-06  1:55       ` Dmitry Gutov [this message]
2025-01-06 12:36         ` Matthias Meulien
2025-01-06 12:42           ` Matthias Meulien
2025-01-06 14:13             ` Dmitry Gutov
2025-01-06 14:11           ` Dmitry Gutov
2025-01-07  5:42             ` Matthias Meulien
2025-01-07 12:45               ` Eli Zaretskii
2025-01-07 14:24               ` Dmitry Gutov
2025-01-06 17:36         ` Juri Linkov
2025-01-06 20:33           ` Dmitry Gutov
2025-01-07 17:39             ` Juri Linkov
2025-01-07 19:38               ` Dmitry Gutov
2025-01-08  7:48                 ` Juri Linkov
2025-01-06 13:02       ` Eli Zaretskii
2025-01-06 14:13         ` Dmitry Gutov
2025-01-05 21:10   ` Matthias Meulien
2025-01-06  1:32     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff8e48df-0439-4447-9253-aa65a908dc84@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=75379@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).