From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50509: 28.0.50; [PATCH] elisp-mode-tests regression Date: Fri, 10 Sep 2021 18:12:24 +0300 Message-ID: References: <87o890pn60.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35212"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: dick.r.chiang@gmail.com, 50509@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 10 17:13:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOiDT-00092l-Oa for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 17:13:23 +0200 Original-Received: from localhost ([::1]:43870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOiDS-0007oY-5u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 11:13:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOiD8-0007oK-To for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 11:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOiD8-0005rP-MA for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 11:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOiD8-0001cz-Fe for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Sep 2021 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50509-submit@debbugs.gnu.org id=B50509.16312867566217 (code B ref 50509); Fri, 10 Sep 2021 15:13:02 +0000 Original-Received: (at 50509) by debbugs.gnu.org; 10 Sep 2021 15:12:36 +0000 Original-Received: from localhost ([127.0.0.1]:38965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOiCh-0001cC-Ox for submit@debbugs.gnu.org; Fri, 10 Sep 2021 11:12:35 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:42960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOiCg-0001bz-8s for 50509@debbugs.gnu.org; Fri, 10 Sep 2021 11:12:34 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id q11so3100703wrr.9 for <50509@debbugs.gnu.org>; Fri, 10 Sep 2021 08:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1DaUgKKotLYlke3IGWPBm2XIotTZRwqssRe1HvF2b4c=; b=MDYa6JmQDSu1rfMcV0KUSsQLUez6CONK7fYYoLLEIPM/yOhOHhnY/Ubiuw4ek0jhmU Awo6JLA8ozG5sVs4np7I3xk3A9FWWqhGP0zu+BGTtEPtK+PQaw9D9bJ7xy81BtW+OwFj +qoY9aaKBLS+XpEvRF4q1XZ+OzlWTAxe2yLNFuZE6mORly+ZsjUeC3Ij6ESiLnilTdFS U5vDo7b3nYvw35kDQYIFLZVyZ+Ctvdgtdti5A05wopKbJAt2UL6Y8HUlnOB9N0oOX3DO Y+W7mZEgjgVRf5XM+B4xPskQHoDJj3G8hSRl+FSWE58M1EbLtCqr4XRwhqRNxqmuNNPd 0ZUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1DaUgKKotLYlke3IGWPBm2XIotTZRwqssRe1HvF2b4c=; b=eDIu/J2jBpStSe8jLoSi0qbV9vcdE+tY7+u85nMrm33j+YIFmnBgyDFZxQrbi6ZBK6 9TkBoK+KLvGe9D1cgzYmnA5XFQykRLI5xD4IkdZaHHiddB4yDHP6F1AryEXjh1gIzWyq RBsuL/CdF2a0ZCfY34PGFbrBj7cUn0BGSKoOJV7j/XKDVikuXs4jqhScLB1PTCFbGsWj +5OQsq0T8AoArBk/BpcRx+xtHXlpgWckNp1eQyRYhhOsUqa/Yk5uU9kEImKXcEl9CGi5 DmqNuUHrV4CyJPl8EgEZBnRKWtJs6ZtwkeSW3yTj9/dLbJTGsDIf9xdwQZ8bmvM2oU+V piUQ== X-Gm-Message-State: AOAM530RrvJrZqs4QGtxC2vweiH6y9So43hyrrr6B254kAaePvMMWdl7 nuydnLYKYm14yemQxbN/wzkML++v25o= X-Google-Smtp-Source: ABdhPJwp6qGE/jG4geHKO9+6+58qyavE/EzjlAilSJh1v/cNGzfRNW9Fs78rOoCv7FWUlYIQPph8iw== X-Received: by 2002:adf:9d47:: with SMTP id o7mr10483598wre.50.1631286748325; Fri, 10 Sep 2021 08:12:28 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o26sm4454055wmc.17.2021.09.10.08.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Sep 2021 08:12:27 -0700 (PDT) In-Reply-To: <87o890pn60.fsf@dick> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214021 Archived-At: Hi! Do you mean to say that 'make check' fails for you, locally or on the CI? On 10.09.2021 16:36, dick.r.chiang@gmail.com wrote: > From c8f9869ba7e022d1952c75fc5076bd26e0843072 Mon Sep 17 00:00:00 2001 > From: dickmao > Date: Fri, 10 Sep 2021 09:31:28 -0400 > Subject: [PATCH] A so-called "CICD" integrated into a PR-based submission > flow... > > ... would have caught this. Just saying. > > * test/lisp/progmodes/elisp-mode-tests.el (find-defs-defgeneric-el): > --- > test/lisp/progmodes/elisp-mode-tests.el | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/test/lisp/progmodes/elisp-mode-tests.el b/test/lisp/progmodes/elisp-mode-tests.el > index f47d54e59c..2745aff670 100644 > --- a/test/lisp/progmodes/elisp-mode-tests.el > +++ b/test/lisp/progmodes/elisp-mode-tests.el > @@ -604,6 +604,12 @@ find-defs-defgeneric-el > 'xref-location-marker nil '(xref-etags-location)) > 'cl-defmethod > (expand-file-name "../../../lisp/progmodes/etags.el" emacs-test-dir))) > + (xref-make "(cl-defmethod xref-location-marker ((l xref-etags-apropos-location)))" > + (xref-make-elisp-location > + (cl--generic-load-hist-format > + 'xref-location-marker nil '(xref-etags-apropos-location)) > + 'cl-defmethod > + (expand-file-name "../../../lisp/progmodes/etags.el" emacs-test-dir))) > )) > > (xref-elisp-deftest find-defs-defgeneric-eval The change above doesn't make sense: elisp and xref-etags-apropos-location do not mix.