bug#48218: [PATCH] ibuffer.el: Use display-buffer properly

bug#48218: [PATCH] ibuffer.el: Use display-buffer properly

[Miha Rihtaršič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Minor simplification for C-o command in ibuffer.
C-o can pop up a new frame under some display-buffer configurations.
In this case, `pop-to-buffer' focuses the new frame, but `select-window'
usually fails to focus the original frame. This simple patch fixes that (if
your window manager doesn't automatically focus newly created frames).


---
* lisp/ibuffer.el (ibuffer-visit-buffer-other-window-noselect): Use
display-buffer instead of pop-to-buffer and selecting the old window.
---
 lisp/ibuffer.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index b484dd717c..c80222ed0f 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -988,9 +988,7 @@ ibuffer-visit-buffer-other-window
   (let ((buf (ibuffer-current-buffer t)))
     (bury-buffer (current-buffer))
     (if noselect
-	(let ((curwin (selected-window)))
-	  (pop-to-buffer buf)
-	  (select-window curwin))
+        (display-buffer buf)
       (switch-to-buffer-other-window buf))))
 
 (defun ibuffer-visit-buffer-other-window-noselect ()
-- 
2.31.1

bug#48218: [PATCH] ibuffer.el: Use display-buffer properly

[martin rudalics]

 > This simple patch fixes that (if
 > your window manager doesn't automatically focus newly created frames

If it does we could apply one of these

(make-frame '((no-accept-focus . t)))

(make-frame '((no-focus-on-map . t)))

but I didn't have the time to look into this.  It would require
experimenting with a number of window managers and their default
settings and customizations.

 > ).

martin

bug#48218: [PATCH] ibuffer.el: Use display-buffer properly

[Lars Ingebrigtsen]

Miha Rihtaršič <miha@kamnitnik.top> writes:

> Minor simplification for C-o command in ibuffer.
> C-o can pop up a new frame under some display-buffer configurations.
> In this case, `pop-to-buffer' focuses the new frame, but `select-window'
> usually fails to focus the original frame. This simple patch fixes that

Thanks; applied to Emacs 28.

> (if > your window manager doesn't automatically focus newly created
> frames).

Martin had a comment about this bit, but if I interpreted his comment
correctly, he didn't object to the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48218: [PATCH] ibuffer.el: Use display-buffer properly

[martin rudalics]

 > Martin had a comment about this bit, but if I interpreted his comment
 > correctly, he didn't object to the patch.

Right.  The patch is good IMHO.

martin