From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Newsgroups: gmane.emacs.bugs Subject: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error Date: Wed, 16 Nov 2016 18:53:16 -0500 Message-ID: References: <871sybw6u8.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn" X-Trace: blaine.gmane.org 1479340458 30866 195.159.176.226 (16 Nov 2016 23:54:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2016 23:54:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 To: 24762@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 17 00:54:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7A1t-0006nf-Hm for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Nov 2016 00:54:13 +0100 Original-Received: from localhost ([::1]:55694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7A1t-0008WO-R3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 18:54:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7A1n-0008V6-SJ for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:54:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7A1j-0002Kc-02 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:54:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7A1i-0002KU-St for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c7A1i-0004r6-4t for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2016 23:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.147934044018655 (code B ref -1); Wed, 16 Nov 2016 23:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Nov 2016 23:54:00 +0000 Original-Received: from localhost ([127.0.0.1]:59965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7A1g-0004qo-1W for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:54:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7A1e-0004qa-Fq for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:53:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7A1Y-0002DH-Gb for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:53:53 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7A1Y-0002D7-C3 for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:53:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7A1M-0008Sp-Bt for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:53:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7A17-00020A-GM for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:53:40 -0500 Original-Received: from mout.kundenserver.de ([212.227.126.135]:52966) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7A17-0001yv-3y for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:53:25 -0500 Original-Received: from [18.26.2.123] ([18.26.2.123]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.168]) with ESMTPSA (Nemesis) id 0Lnnzv-1ci8vV3yiV-00hrV7 for ; Thu, 17 Nov 2016 00:53:23 +0100 In-Reply-To: <871sybw6u8.fsf@udel.edu> X-Provags-ID: V03:K0:slUHhYFNGcA+8Vqtj4gv0zDE0GpNw99W0TzZHCgI8r6H+7FNOA9 YKlfH1T4TCUxm1QX4XMV4ZWsg6HycHjCzu/kv5J6XKJsxwJNmlAanVuW7TyAlEnPS1z8fb4 D+UQjtpjOEGsKmCqP9dPMQ4wTANj0K9PszNyYgGQWJ9nDbuug9rtsAnNChYrz+rGB4Ym+1m waDbtal+WZb42IBfmLClg== X-UI-Out-Filterresults: notjunk:1;V01:K0:zWO2PkymXb0=:nvJXZf9ZDM1tGKpBjk6doJ W8qu/tsQK1fX7BOfXt+1Vl5D41yfBYyaJZ6FjKsuDIsGs8Nz4tmvaPZEBIvy3d/XyCAxYO/eM aFHtFlTfTDd9kFxI3PJulPolGUD57rFV5sC95Ssw52bLhLhnGwxZBJX0LFlu5MnKk2mRbJvxg CSPE33JHqr1I2xrAcUmWgqA2BGVewSNHGw+yphA5vsVnrNGUJcblTnqpdnporbysDd+LSbFBJ FfkWokmjbeNaD/IF97/ZLOMYfjigtEG/Yi0g3kWiG53kbzsGsDUmT7dH31Axt/epMN5VlQcBn hmWh7pzbzEeP3nOdtdipFZfw/1yM4x5Sd1oTgQBtJ6HQak8fX+/sfdSfxgzpC3ifuh6iYs0MH 0LM29AyaGUQeDr5T+JgiKfjMZ1i6sgeYLfd7mspA23mSrHASOgKV7AuKf6KSzX4cdNiCCHMZ7 ABvCOQBPMTdsFjilP0Tz9ZGjk0G2YFOZnRKGMDhySe+vBhRYN0ZeQ9VL8Bu/kFfH2OGV91RMO YeTPoL5l/2sGax3ef8tumwovF60syqHTwJ5GVqxWC/tp21V16xX0hgOOIvUpBmiCIaeblzwGo rg6f6JO4VHQHJlhCYybr9wr5jYvBqtMDLMw3vfqObctUSxWnPZNWPie6lgAt6V/tLog/pcNoG IPxXTkDDQXJyRarGmxqN05Tbi5bsY8jPg+FdZYLffwiFcfh2O2IwrxxLwQQCJusijOkA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125776 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn Content-Type: multipart/mixed; boundary="fcqblSrWROw3K3wnv9BIVGKfxhQi62Nip"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: Subject: Re: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error References: <871sybw6u8.fsf@udel.edu> In-Reply-To: <871sybw6u8.fsf@udel.edu> --fcqblSrWROw3K3wnv9BIVGKfxhQi62Nip Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable LGTM :) On 2016-11-16 14:41, Mark Oteiza wrote: > Gemini Lasswell writes: >=20 >> There's an &optional followed by &rest instead of a parameter name in >> python-define-auxiliary-skeleton in lisp/progmodes/python.el. This >> doesn't work with defmacro's Edebug spec and prevents use of Edebug on= >> the macro and testcover-start on the file. >> >> To repro: >> 1. start Emacs at the top of its source tree, with -Q if you like >> 2. C-x C-f lisp/progmodes/python.el RET >> 3. C-s &optional &r RET >> 4. C-u C-M-x >> >> Result: Invalid read syntax: "Bad argument:", &rest >=20 > Thanks for reporting--it looks to me like the following fixes: >=20 > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index f9b28c3..9cd9cc8 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table > "Abbrev table for Python mode." > :parents (list python-mode-skeleton-abbrev-table)) > =20 > -(defmacro python-define-auxiliary-skeleton (name doc &optional &rest s= kel) > +(defmacro python-define-auxiliary-skeleton (name &optional doc &rest s= kel) > "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL. > The skeleton will be bound to python-skeleton-NAME." > (declare (indent 2)) > @@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton > (signal 'quit t)) > ,@skel))) > =20 > -(python-define-auxiliary-skeleton else nil) > +(python-define-auxiliary-skeleton else) > =20 > -(python-define-auxiliary-skeleton except nil) > +(python-define-auxiliary-skeleton except) > =20 > -(python-define-auxiliary-skeleton finally nil) > +(python-define-auxiliary-skeleton finally) > =20 > (python-skeleton-define if nil > "Condition: " >=20 >=20 >=20 >=20 --fcqblSrWROw3K3wnv9BIVGKfxhQi62Nip-- --GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLPFsAAoJEPqg+cTm90wjVpoP/0N8cULQQKzVO0c4ykkVE9Ph JSW0RKdL78KIWywHJ1ZbfjfCA4ldgr2Ke4T+wZtJrSLFwUd13ZqsMpVuLfHh95Ql 9lCj5OI4unwBUvRx3f6Ofg/3Kz8e1oPcd22XbGVEmCH+SJdVy0IKtEdTUthizDCP Qjsushddy4AfQ9jy8xuyDSjQJUpnjgLzgZbbSxUgnNIVNtBJuWhH+e3Cvw/Wb4U1 MIpc3R8nDw8csQ2Azzr9WE47Ti5dGeEe8dTCqvIVbYfpDyhybFEGRcnbSfvyJREe Y7nsYGhH7wUUWfhoeJTObpX/7VfrrDrIE/7FgOcQRyWN+g5Axn162eD+Jxgdh/Pk wx7PRpzmo3F439zE7/Rt+VB//2eNC/UIhLwCRDZEdmrLVD7VltNrvJJ6rYAcAcR1 PGBaA95bZGhuLSdukNPgOcgQ3jjX8t6hvwnddxqOY1jVSZF03aclEpRwxR2NEvzT HjYPmjr7eTjYXcw8YKXG3faCWpiwUT2OU7+9CkBxkXt/llV/uLuUOa1dwdwaeMFx wFLNwEovvTVqBUVaLORbn5hPe3u25kePeuETbAnOqSI1yhBgwp5MmralrQ/jHFfD 0njj965JIEUhKkEIpzz2OuLKI4CQPDahBp1dcC9CWTbitovSUXhtT7jTeqNZM1jo aqqJj31GFS/vd4sF3sxH =urW6 -----END PGP SIGNATURE----- --GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn--