From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lucas Werkmeister Newsgroups: gmane.emacs.bugs Subject: bug#31498: [PATCH] Notify systemd in daemon-initialized Date: Thu, 7 Jun 2018 23:40:08 +0200 Message-ID: References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <87bmcm3frw.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1528407489 23501 195.159.176.226 (7 Jun 2018 21:38:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Jun 2018 21:38:09 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: 31498@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 07 23:38:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2bZ-0005wA-Je for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 23:38:01 +0200 Original-Received: from localhost ([::1]:60314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR2dg-0002Vb-Pq for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 17:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR2da-0002VU-7o for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 17:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fR2dW-0002UZ-7j for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 17:40:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58808) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fR2dV-0002Tz-Vk for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 17:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fR2dV-0007JL-Kc for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 17:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lucas Werkmeister Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jun 2018 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31498-submit@debbugs.gnu.org id=B31498.152840759528084 (code B ref 31498); Thu, 07 Jun 2018 21:40:01 +0000 Original-Received: (at 31498) by debbugs.gnu.org; 7 Jun 2018 21:39:55 +0000 Original-Received: from localhost ([127.0.0.1]:38472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2dP-0007Iu-3O for submit@debbugs.gnu.org; Thu, 07 Jun 2018 17:39:55 -0400 Original-Received: from lucaswerkmeister.de ([94.130.58.99]:35426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2dM-0007Ik-W2 for 31498@debbugs.gnu.org; Thu, 07 Jun 2018 17:39:53 -0400 Original-Received: from theoden.lucaswerkmeister.de (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 9F5B9396855; Thu, 7 Jun 2018 23:39:51 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528407591; bh=Z8h45/kaJDXiFJvpploQri7Ex/p+YP4O4Ypa2fEToUM=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=He2j3BRW+CUmhp6G4NPCmlIU7gvaTl8pRjo/p9gcFOVei5WSrXylQvf+zhhZ6HXNR C4wVj7j0s6UcWBuGuIT3UJGhIwCIli1c+9osbkr6j9DTx0QB2XL5qSUs3ngKK4Chzu P0LIL9sbQyo7pqkkdXJyTiuB3RgWQaxuN4h14tA8= Openpgp: preference=signencrypt Autocrypt: addr=mail@lucaswerkmeister.de; prefer-encrypt=mutual; keydata= xsFNBFKkO1oBEACXP/JGIJsKiXsA866Ak439ZIaU5xNss6V2QoOQBSj6848kkxhDLEbfgVYW 4meXYpYJV9P2Vk0PC2kQWadqbvqhfP7OomlIlZzlpvbi2xbjW4tr09brY7d7GvMcplh5igYS gWo5J/6+4ZDgVj+TG0OuvkTDZmJmHhrwDuIsvh3KDJhT0z6t43qzQ69Efse/OjJRpWha5nZt fvtdBCI/v2Pq6pJrPx1g1u/BKArRcrrWLpCRQRbFwrQ1MsIkj8Wzz1tKjulGUSPIXvvssxYA /3BQEniMKzxbkZlhi4DUe5WJZWFS6BWaS+Qbwd0bq2WaCD/PFddjHN6qWAxxPY2rvP7C+Lj7 FQiHLbeMi2K0hiMEsUUsORq/A0LjG84RSwhic2a6cvszj9b6WRmRUb1PMMxcNCjCzebkdZeL RWrqhCnMU+rxQJ+qib5rbYCjvpV2hWzlXcvjaW2B32jUAhG3sDK6Cd4A+Ao7gJPv1KzdvqZj Aoo5/5RI1Er5EYkhcjGAc0N/VWnOq5WDuL4CdeamIwMyOlI42npbzKsHhlb5nXPeFl7eEOdZ RVKs3yuE3/23XpWisjKUk9tUpGBHi098rPPnbA4T9P7ZwWNwo8j4Bh8D71nC+JJ1ue92NzSi T9E7ckdSIatPl5rJIEjvf9pZB4YUugGM06JdlYakVVZZHLXFgQARAQABzSxMdWNhcyBXZXJr bWVpc3RlciA8bWFpbEBsdWNhc3dlcmttZWlzdGVyLmRlPsLBmAQTAQoAQgIbAwYLCQgHAwIG FQgCCQoLBBY In-Reply-To: <87bmcm3frw.fsf@gmail.com> Content-Language: de-DE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147148 Archived-At: Thanks for the review! Replies inline. On 07.06.2018 15:08, Noam Postavsky wrote: > severity 31498 wishlist > severity 31521 wishlist > quit > > > Thanks, the patch seems straightforward enough. Just a few minor > comments about formatting. Have you assigned copyright for Emacs? The > patch is small enough to go in anyway, it would just have to be marked. I haven’t assigned copyright yet, but I’d be happy to do so – I’ve tried to get the process started on emacs-devel. > > Lucas Werkmeister writes: > >> With --[bg-]daemon and Type=forking, systemd will only consider the >> daemon to have fully started up once the original process exits, and >> will wait until then to start units depending on the Emacs service. To > ^ > double space ack >> get the same functionality with --fg-daemon, use Type=notify instead of >> Type=simple and explicitly send a readiness notification to systemd at >> the point where the forked process would in --bg-daemon mode notify its >> parent process and cause it to exit. >> * etc/emacs.service: update Type > > The ChangeLog entries should be captilalized and end with a period: > "Update Type." > >> * src/emacs.c (daemon-initialized): call sd_notify() > > Same here. 2× ack > > I think it should have a NEWS entry mentioning that Emacs now supports > this systemd notification feature. I would probably go ahead and > combine with #31521, since it's using the same feature. > Do you mean, announce both in this patch, or completely merge that patch into this one? Once I’ve fixed the problems locally, what’s the best way to re-roll the patch in this bug tracking system? Should I try to configure `git send-email` to reply to the right email (and with the right bug in CC), or perhaps use `git format-patch` and add the patch file as a regular attachment in a manual response?