From: Lucas Werkmeister <mail@lucaswerkmeister.de>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31498@debbugs.gnu.org
Subject: bug#31498: [PATCH] Notify systemd in daemon-initialized
Date: Thu, 7 Jun 2018 23:40:08 +0200 [thread overview]
Message-ID: <fede2577-ab12-62b8-2212-4d863a066811@lucaswerkmeister.de> (raw)
In-Reply-To: <87bmcm3frw.fsf@gmail.com>
Thanks for the review! Replies inline.
On 07.06.2018 15:08, Noam Postavsky wrote:
> severity 31498 wishlist
> severity 31521 wishlist
> quit
>
>
> Thanks, the patch seems straightforward enough. Just a few minor
> comments about formatting. Have you assigned copyright for Emacs? The
> patch is small enough to go in anyway, it would just have to be marked.
I haven’t assigned copyright yet, but I’d be happy to do so – I’ve tried
to get the process started on emacs-devel.
>
> Lucas Werkmeister <mail@lucaswerkmeister.de> writes:
>
>> With --[bg-]daemon and Type=forking, systemd will only consider the
>> daemon to have fully started up once the original process exits, and
>> will wait until then to start units depending on the Emacs service. To
> ^
> double space
ack
>> get the same functionality with --fg-daemon, use Type=notify instead of
>> Type=simple and explicitly send a readiness notification to systemd at
>> the point where the forked process would in --bg-daemon mode notify its
>> parent process and cause it to exit.
>> * etc/emacs.service: update Type
>
> The ChangeLog entries should be captilalized and end with a period:
> "Update Type."
>
>> * src/emacs.c (daemon-initialized): call sd_notify()
>
> Same here.
2× ack
>
> I think it should have a NEWS entry mentioning that Emacs now supports
> this systemd notification feature. I would probably go ahead and
> combine with #31521, since it's using the same feature.
>
Do you mean, announce both in this patch, or completely merge that patch
into this one?
Once I’ve fixed the problems locally, what’s the best way to re-roll the
patch in this bug tracking system? Should I try to configure `git
send-email` to reply to the right email (and with the right bug in CC),
or perhaps use `git format-patch` and add the patch file as a regular
attachment in a manual response?
next prev parent reply other threads:[~2018-06-07 21:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 17:40 bug#31498: [PATCH] Notify systemd in daemon-initialized Lucas Werkmeister
2018-06-07 13:08 ` Noam Postavsky
2018-06-07 15:38 ` Eli Zaretskii
2018-06-07 21:40 ` Lucas Werkmeister [this message]
2018-06-08 0:41 ` Noam Postavsky
2018-06-09 10:27 ` bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs Lucas Werkmeister
2018-06-09 10:55 ` bug#31498: (no subject) Lucas Werkmeister
2018-06-09 10:56 ` bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs Lucas Werkmeister
2018-06-09 12:29 ` Noam Postavsky
2018-06-09 12:31 ` Lucas Werkmeister
2018-06-09 12:36 ` Noam Postavsky
2018-06-09 13:00 ` Lucas Werkmeister
2018-06-09 14:05 ` Noam Postavsky
2018-06-13 13:42 ` Lucas Werkmeister
2018-06-13 16:33 ` Eli Zaretskii
2018-06-09 13:01 ` Lucas Werkmeister
2018-07-12 22:20 ` bug#31498: [PATCH] Notify systemd in daemon-initialized and, kill-emacs Lucas Werkmeister
2018-07-13 6:58 ` Eli Zaretskii
2018-07-25 12:03 ` bug#31498: [PATCH] Notify systemd in daemon-initialized and, , kill-emacs Lucas Werkmeister
2018-07-25 14:48 ` Eli Zaretskii
2018-07-26 1:13 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fede2577-ab12-62b8-2212-4d863a066811@lucaswerkmeister.de \
--to=mail@lucaswerkmeister.de \
--cc=31498@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).