unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 18069@debbugs.gnu.org
Subject: bug#18069: 24.4.50; doc of rectangle highlighting & redisplay code
Date: Mon, 21 Jul 2014 10:00:57 -0700 (PDT)	[thread overview]
Message-ID: <feca8b5c-2720-4e94-9e2d-6a05e2fe6ac8@default> (raw)

The doc is, well, missing.

Nothing for the advice of `redisplay-(un)highlight-region-function' or
`region-extract-function', or for those variable themselves, or for the
functions used to advise them (`rectangle--highlight-for-redisplay', for
example).

Nothing for `redisplay--update-region-highlight(s)', or other funtions
that use those `*-function' vars, or for `pre-redisplay-function', which
uses `redisplay--update-region-highlight'.

IOW, nothing for anything that does region (un)highlighting redisplay,
including `deactivate-mark' (which has a doc string, but whose doc
string does not cover this new part of its behavior).

None of the so-called "New rectangle integration with kill-ring"
behavior is documented in doc strings.  It is also not documented in
NEWS, AFAICT.

This code change represents a change in user-visible behavior, and it
should be documented.


[It's a shame that Emacs Dev has increasingly neglected to add helpful
 doc strings (IMHO).  The originator of the self-documenting editor is
 no longer watching closely, and developers will be developers, I
 suppose...  Too bad.

 BTW, why is Emacs code simply using `add-function' all over the place
 now, instead of actually adding the code to the functions?  Is advice
 the new normal for Emacs code maintenance?]


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''





             reply	other threads:[~2014-07-21 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 17:00 Drew Adams [this message]
2021-01-20  1:59 ` bug#18069: 24.4.50; doc of rectangle highlighting & redisplay code Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feca8b5c-2720-4e94-9e2d-6a05e2fe6ac8@default \
    --to=drew.adams@oracle.com \
    --cc=18069@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).