From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Date: Sat, 25 Mar 2023 15:00:24 +0200 Message-ID: References: <87fs9yur7r.fsf@gmail.com> <2fd8f2b8-d9c4-c825-a789-f2d42324859f@yandex.ru> <09539C5E-23DA-4B00-A3F6-873A41D6A2CE@gmail.com> <83h6uc549z.fsf@gnu.org> <665745A2-FDC8-45DE-BFF5-2F688FC85431@gmail.com> <491b788f-c3c3-4877-daa0-f515be9f3a17@yandex.ru> <83sfduelab.fsf@gnu.org> <8FC25A01-6934-43BB-899C-CA5926BEA3CF@gmail.com> <83jzz5c8ml.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 14:01:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg3Wc-0006J8-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 14:01:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg3W5-00022B-Gh; Sat, 25 Mar 2023 09:01:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg3W4-00021j-Em for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:01:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg3W3-0006TH-6Q for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:01:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg3W2-0005z2-0u for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 13:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62333 X-GNU-PR-Package: emacs Original-Received: via spool by 62333-submit@debbugs.gnu.org id=B62333.167974923422938 (code B ref 62333); Sat, 25 Mar 2023 13:01:01 +0000 Original-Received: (at 62333) by debbugs.gnu.org; 25 Mar 2023 13:00:34 +0000 Original-Received: from localhost ([127.0.0.1]:42121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg3Va-0005xu-0l for submit@debbugs.gnu.org; Sat, 25 Mar 2023 09:00:34 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:38427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg3VY-0005xd-PQ for 62333@debbugs.gnu.org; Sat, 25 Mar 2023 09:00:33 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id q19so1202222wrc.5 for <62333@debbugs.gnu.org>; Sat, 25 Mar 2023 06:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679749226; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=/LaY8YNE6aALpGA4X6raPDa0gMm3pXFb3xw5hKZk0l8=; b=nFqy2PW/bLz2EPz2xOSVS3DN2niT7ycn/BZTkNPJbsDFBSy5C7/a1UDewLuIjw0H6/ +qdkTb6NYM8QlG/wDKEV5SFceFw92SFHvT1+SeoCCQ3g1/OoJPjpbUzpAkFpMSgvc9JU xEPdURIIh4uWlE3fMXB1mNfzhV4qT5sraRIvaUFxuukJDZ2xd9om3QvR1n94Za1aacBb xN/RiJq6AVQ/i5bdQkWGOAMKw4lAlKpe2OmIxpY2BhjMHF8crhniCicdAW0nvntmfmpM +t5eDhnkjLuCD8DzszL3t53Qkq2/hrvj7oBtkABiGyfbsOlwB36VqWLx0WupPUhWJ70E 9+kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679749226; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/LaY8YNE6aALpGA4X6raPDa0gMm3pXFb3xw5hKZk0l8=; b=fCH8iCSoag5FHSrF0jTJsZqiANO1ZFRbSWwLanT4FULUSk8spaiaYJYsOl5xSEBrlj Y371C7vMbROdwOm3n9DTVUjUTSzJWWNO/3FoW3fs9ZHR3k+xiNw+ZropB2mOnWKm6Ay9 gBPjshRktXiAkmlz2y2tLUZR/+lVgsHhMoGefn0j5h3alJ63aia3FlZIj3+yL/wRhVXK vv3ZADif6+SgzC1+VzNrCXu6ClUUWlmCCzaR6BktkRs7It2v8pkjR68IunBYJuhz36QP PkxFwsUpCzZPg2UCHQqyoSZ8JELitxb2GxRjlQSFIfQwjBz5hrkvJ/AC2H33EJ2CiwNL HeVw== X-Gm-Message-State: AAQBX9eneBfHA8ED38le+hraBjvBT+SkFJMNZvuMwI/3+EPbrRE5iSAr Qe2BlMQv2TM5Nh9ahXhfgMM= X-Google-Smtp-Source: AKy350aWNsjc9TnCjixUULXLgjzO7cyYKf6nCv1yPYZ8sklHtg2OrnSrJ82uLWWWEOpyaH1jF0WwAQ== X-Received: by 2002:adf:f30c:0:b0:2cf:ed87:37c9 with SMTP id i12-20020adff30c000000b002cfed8737c9mr4610323wro.11.1679749226560; Sat, 25 Mar 2023 06:00:26 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id w2-20020a5d6802000000b002cfe687fc7asm20535495wru.67.2023.03.25.06.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 06:00:26 -0700 (PDT) Content-Language: en-US In-Reply-To: <83jzz5c8ml.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258560 Archived-At: On 25/03/2023 14:34, Eli Zaretskii wrote: >> Not ideal indeed. >> >> Aside from the performance impact, we could also see cases where the >> "narrowed" parse tree contains errors (due to incomplete code) which >> make the tree itself less useful. Especially when the narrowing's end is >> closer to the current position than in blink-matching-open's usage. >> >> Not sure how to solve that, but suppose we had a way to convey to >> treesit.c that it shouldn't change the visibility bounds for the parser >> in this particular instance? Though that would raise the issue of code >> trying to use node positions beyond the current accessible range. > Exactly. Which is why I don't think this is the right way. > > Is there any real reason blink-matching-open narrows the buffer? If > we could remove that narrowing, the problem with the parser's taking > notice of it would be gone. Performance: to avoid scanning for the matching paren too far in the buffer. Which might seem like not that big a deal, or could even be handled in a special way here using the parse tree, but narrowing has been used for this purpose for a long time (to limit various kinds of searches or movements), so fundamentally the problem will still be with us.