From: Drew Adams <drew.adams@oracle.com>
To: Philipp Stephani <p.stephani2@gmail.com>, 24706@debbugs.gnu.org
Subject: bug#24706: 26.0.50; Minor mode functions should do strict argument type checking
Date: Sun, 16 Oct 2016 12:50:06 -0700 (PDT) [thread overview]
Message-ID: <fe2d7dd5-e379-4d08-9032-ceecae168a91@default> (raw)
In-Reply-To: <CAArVCkQ92m0tibx_ApbLj-Zo0514zQmv3cQCHV+26BbXwq8BtQ@mail.gmail.com>
>> Why would you change the behavior, instead of just clarifying
>> the doc?
>
> I generally prefer the behavior to be as strict as possible.
> Consider (foo-mode 'disable) If you read such code, do you
> assume that this enables foo-mode?
If I understand the function, then yes. But I agree that the
doc could make the function behavior clearer.
That example is akin to this:
(deconst two 42)
(+ 3 two)
There are plenty of ways to write code that is perverse in
terms of readability (whether or not it has the right behavior).
> However, in this case I guess it's too late, and fixing the
> documentation is indeed more appropriate.
It would be a backward-incompatible change. (And I do not
see any advantage to it. But others might disagree with
me and agree with you.)
prev parent reply other threads:[~2016-10-16 19:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 15:45 bug#24706: 26.0.50; Minor mode functions should do strict argument type checking Philipp Stephani
2016-10-16 16:12 ` Drew Adams
2016-10-16 16:31 ` Noam Postavsky
2016-10-16 16:49 ` Drew Adams
2016-10-16 18:01 ` Eli Zaretskii
2016-10-16 18:13 ` Philipp Stephani
2016-10-16 18:25 ` Philipp Stephani
2016-10-16 18:51 ` Eli Zaretskii
2017-04-23 17:51 ` Philipp Stephani
2017-04-26 11:26 ` Eli Zaretskii
2020-08-01 20:47 ` Philipp Stephani
2020-08-02 16:13 ` Eli Zaretskii
2020-10-01 12:12 ` Stefan Kangas
2016-10-16 18:53 ` Eli Zaretskii
2016-10-16 19:50 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2d7dd5-e379-4d08-9032-ceecae168a91@default \
--to=drew.adams@oracle.com \
--cc=24706@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).