unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 12939@debbugs.gnu.org
Subject: bug#12939: 24.3.50; [PATCH] `icomplete-mode' should respect `completion-ignored-extensions'
Date: Wed, 24 Feb 2016 07:10:22 -0800 (PST)	[thread overview]
Message-ID: <fe26cd39-b283-484a-a2b3-5898ce6f0793@default> (raw)
In-Reply-To: <87k2luejeq.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

> > `icomplete-mode' shows, e.g., names of files ending with `~'.  It
> > should, but it does not, respect `completion-ignored-extensions'.
> >
> > This is apparently because `completion-all-sorted-completions'
> > does not respect it either (which is, however, TRT).
> 
> You included an entire version of icomplete.el, which, of course,
> can't be compared for code changes now.
> 
> Could you submit a patch for the changes you want to see happen?

I meant to send the attached 2012 patch; sorry.  Of course, you might
need to adjust something because the code base has probably changed
a bit since 2012. ;-)

[-- Attachment #2: icomplete-2012-11-19.patch --]
[-- Type: application/octet-stream, Size: 611 bytes --]

diff -c icomplete.el icomplete-patched-2012-11-19.el
*** icomplete.el	Mon Nov 19 13:17:02 2012
--- icomplete-patched-2012-11-19.el	Mon Nov 19 13:56:50 2012
***************
*** 297,302 ****
--- 297,305 ----
      (if (not (consp comps))
          (format " %sNo matches%s" open-bracket close-bracket)
        (if last (setcdr last nil))
+       (when (and minibuffer-completing-file-name
+ 		 icomplete-with-completion-tables)
+ 	(setq comps (completion-pcm--filename-try-filter comps)))
        (let* ((most-try
                (if (and base-size (> base-size 0))
                    (completion-try-completion

  reply	other threads:[~2016-02-24 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 22:15 bug#12939: 24.3.50; [PATCH] `icomplete-mode' should respect `completion-ignored-extensions' Drew Adams
2016-02-24  6:01 ` Lars Ingebrigtsen
2016-02-24 15:10   ` Drew Adams [this message]
2016-04-28 17:31     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe26cd39-b283-484a-a2b3-5898ce6f0793@default \
    --to=drew.adams@oracle.com \
    --cc=12939@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).