unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@janestreet.com, 72426@debbugs.gnu.org
Subject: bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command
Date: Sat, 14 Sep 2024 02:45:00 +0300	[thread overview]
Message-ID: <fe168b78-011f-41f4-be5b-8ef6d55630e5@gutov.dev> (raw)
In-Reply-To: <86zfocjdah.fsf@gnu.org>

On 13/09/2024 09:08, Eli Zaretskii wrote:
>> FWIW async-shell-command's behavior is affected by a bunch of other
>> comint-* variables as well because it uses a major mode which inherits
>> from comint-mode (previously it was shell-mode, now shell-command-mode,
>> but that aspect didn't change).
> Yes, and that is baaad!

It might be non-obvious, but I don't see how else it would work: comint 
is the only built-in subsystem we have that implement a general 
read-evel-print-loop. So we have 'M-x shell' and 'M-x ielm', for 
example, both using it as well (not to mention inf-python, inf-ruby, etc).

And since we wanted, apparently, to have async-shell-command support 
user input (the command can be 'sh', for example), it uses parts of 
comint for its work too (comint-output-filter and the major mode with 
all its local bindings -- not sure if something else too, but this is 
already a lot).

An alternative would be to have separate user options for each of the 
above features which would bind comint's options under the cover. But 
that's not very economical.





  reply	other threads:[~2024-09-13 23:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 18:35 bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command Spencer Baugh
2024-08-02 18:39 ` Spencer Baugh
2024-08-03  5:48 ` Eli Zaretskii
2024-08-03 10:47   ` Spencer Baugh
2024-08-03 15:38     ` Eli Zaretskii
2024-08-03 16:42       ` Spencer Baugh
2024-08-03 17:18         ` Eli Zaretskii
2024-08-06 15:33           ` Spencer Baugh
2024-08-06 15:46             ` Eli Zaretskii
2024-08-06 16:29               ` Jim Porter
2024-08-06 18:02                 ` Eli Zaretskii
2024-08-03 18:38       ` Jim Porter
2024-08-06 15:31         ` Spencer Baugh
2024-08-06 15:50           ` Eli Zaretskii
2024-08-06 16:42             ` Spencer Baugh
2024-08-06 18:07               ` Eli Zaretskii
2024-08-06 18:49                 ` Spencer Baugh
2024-08-06 19:07                   ` Eli Zaretskii
2024-08-06 19:23                     ` Spencer Baugh
2024-08-07  2:36                       ` Jim Porter
2024-08-07 11:51                         ` Eli Zaretskii
2024-08-07 15:05                           ` Spencer Baugh
2024-08-07 15:26                             ` Eli Zaretskii
2024-08-07 15:31                               ` Spencer Baugh
2024-08-07 16:08                                 ` Jim Porter
2024-08-07 11:18                       ` Eli Zaretskii
2024-08-07 15:09                         ` Spencer Baugh
2024-08-17  9:25                       ` Eli Zaretskii
2024-09-13  1:17       ` Dmitry Gutov
2024-09-13  6:08         ` Eli Zaretskii
2024-09-13 23:45           ` Dmitry Gutov [this message]
2024-09-14  6:27             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe168b78-011f-41f4-be5b-8ef6d55630e5@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=72426@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).