From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#2807: Subject: 23.0.90; etags can't access .el.gz files Date: Thu, 12 Oct 2023 12:04:47 -0300 Message-ID: References: <49c2c28b-291c-4436-8443-77bf6949751c@gmail.com> <28afd2a3-1adc-42cf-ac2f-9bded2d0c22c@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------KJ53njT0QboMc8pMVebS2TAk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18356"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: pot@gnu.org, 2807@debbugs.gnu.org, prouleau001@gmail.com, 44494@debbugs.gnu.org, dgutov@yandex.ru, Lars Ingebrigtsen , Eli Zaretskii To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 12 17:05:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqxG4-0004W1-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Oct 2023 17:05:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqxFu-0004mp-8w; Thu, 12 Oct 2023 11:05:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqxFs-0004mV-NR for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2023 11:05:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqxFr-0002TX-VI for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2023 11:05:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqxGE-0005xt-6t for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2023 11:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Oct 2023 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 2807-submit@debbugs.gnu.org id=B2807.169712312322871 (code B ref 2807); Thu, 12 Oct 2023 15:06:02 +0000 Original-Received: (at 2807) by debbugs.gnu.org; 12 Oct 2023 15:05:23 +0000 Original-Received: from localhost ([127.0.0.1]:44082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqxFa-0005wo-Cl for submit@debbugs.gnu.org; Thu, 12 Oct 2023 11:05:22 -0400 Original-Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:54639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqxFY-0005wV-1L; Thu, 12 Oct 2023 11:05:20 -0400 Original-Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c9a1762b43so9011775ad.1; Thu, 12 Oct 2023 08:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697123091; x=1697727891; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=3ALXOVE9T/oNMDD690ZzrR1grQw+uvT9e5P59kp6R28=; b=lTMWXotOmwqVH4cNyQqRzgTPQlNaUkZvLIGCvmfP4ahGprGWl8xloXbzPjUDbVLuLl CQYz7xjgzy4Vi1RJI1ZhwH1UJZ69TuqCfnuCbnee8qyhdIpgnYvEpgAe5KFAy8YT9Qgi DatEzYqJ84aJOmQe2TxI5SQ4L+zO9GUORZV7NtG38kOAyiZGM7pWubfXU9aZaHAbMKNZ m5+aV4yuR+T1NRwH9uCb55adCKKRTG8+h1WaI2bSXBo5h7Xq+FMyn27bhkeai3+R4H+o AdGnxZTrFhJGgGayfmH4UWkApFW6Q1wVtXhD9uRJvSMy7zqqSCW95XccG1zrXgUz2L3z NO/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697123091; x=1697727891; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3ALXOVE9T/oNMDD690ZzrR1grQw+uvT9e5P59kp6R28=; b=mUP7WEirvg6/C4EbBApHYKIPaEEq9zZ15W7knLJKo9x0pedjM1gqdL9Y10M+SauOk6 1plml9bgAZIxDeBUaW2Jn9GYfN+/duwbiAx0Y+xsxa5otg1S+f4ZMGpZ3zgmSwv9H0Di Wm/9Eaa34j3kHlxDc6/uPo34Cy3MMhZtM7OU7sw10IgZ2cj8diAxPhHGA3GWTSe7ogxU vM+PBPj9JNd2TzuqGUNezK3pVmBG3DEnbL3oLofKELlfzV0c9bXxDnwR5ikvDaTdeHl3 qggJcD5I6xwOHy7YUzrgmVkQZTh1t3XimfKSIkswaNIRSFSmeD0BP+GDz600fCYZxUqe Z8pg== X-Gm-Message-State: AOJu0YwEpufnv2d2B3/OtbVWX0QhP5uKU4LrzoZ+5lbiZbgqhI8NmTYu Mzos8WMAv1xElnSzBhRnTTQ= X-Google-Smtp-Source: AGHT+IFukvHve1kFRaRl13Q6FOXa1KGl6xPDi04+mb5hoso94rjCw53Ta8GT0APM3eDIqJePmuQs0g== X-Received: by 2002:a17:902:7246:b0:1c5:dfe9:b209 with SMTP id c6-20020a170902724600b001c5dfe9b209mr24054525pll.62.1697123091290; Thu, 12 Oct 2023 08:04:51 -0700 (PDT) Original-Received: from [192.168.0.100] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id l18-20020a170902eb1200b001c5fc291ef9sm2091436plb.209.2023.10.12.08.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Oct 2023 08:04:50 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272307 Archived-At: This is a multi-part message in MIME format. --------------KJ53njT0QboMc8pMVebS2TAk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/10/23 11:28, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> +(defun etags--ensure-file (file) >> + "Ensure FILE can be visited. >> + >> +FILE should be an expanded file name. >> +This function tries to locate FILE, possibly adding it a suffix >> +present in `tags-compression-info-list'. If the file can't be found, >> +signals an error. >> +Else, returns the filename that can be visited for sure." >> + (let ((f (locate-file file nil tags-compression-info-list))) >> + (unless f >> + (signal 'file-missing (list "Cannot locate file in TAGS" file))) >> + f)) > > The patch looks pretty good, but other parts of the code use > check `auto-compression-mode` before using `tags-compression-info-list`, > so we should probably do the same here. Thank you! Yes, I should've added that check. I attach a patch that incorporates the check. > As other comments mention in the file, this arrangement is suboptimal > because the search for compressed filenames should probably be moved to > jka-compr's code (e.g. using `jka-compr-compression-info-list` rather > than `tags-compression-info-list`). Yes, but I opted to go with this simpler patch for a 24 year-old bug report. > Historical side note: jka-compr used to have the ability to do what we > want here "transparently" (it changed things like `find-file-noselect` > to look for compressed versions of the file, among other things). > IIRC it was removed when it got integrated into Emacs (don't know why > but I assumed it was too hackish/ugly/costly/brittle). > > We should arguably re-add this feature, tho maybe not transparent, > i.e. let packages who need that request that feature explicitly (like > here). > That's good to know, thank you. And I agree that the feature would be good to have, but I hope that in the meantime we can go with the updated patch. --------------KJ53njT0QboMc8pMVebS2TAk Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-searching-for-tags-in-compressed-files.patch" Content-Disposition: attachment; filename="0001-Fix-searching-for-tags-in-compressed-files.patch" Content-Transfer-Encoding: base64 RnJvbSBiZmVkNTIzZTNhZTgwMDdlOTU5ZTc4MDFhM2NiY2QwYTRjN2I4M2Q4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFRodSwgMTIgT2N0IDIwMjMgMDk6NDE6NTggLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggc2VhcmNoaW5nIGZvciB0YWdzIGluIGNvbXByZXNzZWQgZmlsZXMKCiog bGlzcC9wcm9nbW9kZXMvZXRhZ3MuZWwgKGV0YWdzLS1lbnN1cmUtZmlsZSk6IE5ldyBmdW5j dGlvbi4KKGV0YWdzLS1hbGwtZmlsZXMpOiBNYWtlIHN1cmUgZmlsZXMgaW4gVEFHUyBjYW4g YmUgdmlzaXRlZCwgZXZlbiBpZgp0aGUgZmlsZXMgYXJlIGNvbXByZXNzZWQuICAoQnVnIzI4 MDcpCihldGFncy0teHJlZi1maW5kLWRlZmluaXRpb25zKTogUmVwb3J0IHRvIHhyZWYgYSBm aWxlIHRoYXQgd2UgYXJlIHN1cmUKaXQgZXhpc3RzLiAgKEJ1ZyM0NDQ5NCkKLS0tCiBsaXNw L3Byb2dtb2Rlcy9ldGFncy5lbCB8IDE5ICsrKysrKysrKysrKysrKysrLS0KIDEgZmlsZSBj aGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsIGIvbGlzcC9wcm9nbW9kZXMvZXRhZ3MuZWwKaW5k ZXggY2I5NWYyOWI1ZmUuLmQ0OGRjYzY2NTlkIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rl cy9ldGFncy5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9ldGFncy5lbApAQCAtMTcyOSw2ICsx NzI5LDIxIEBAIHRhZ3MtbmV4dC1maWxlCiAgIChmaWxlbG9vcC1uZXh0LWZpbGUgbm92aXNp dCkKICAgKHN3aXRjaC10by1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpCiAKKyhkZWZ1biBl dGFncy0tZW5zdXJlLWZpbGUgKGZpbGUpCisgICJFbnN1cmUgRklMRSBjYW4gYmUgdmlzaXRl ZC4KKworRklMRSBzaG91bGQgYmUgYW4gZXhwYW5kZWQgZmlsZSBuYW1lLgorVGhpcyBmdW5j dGlvbiB0cmllcyB0byBsb2NhdGUgRklMRSwgcG9zc2libHkgYWRkaW5nIGl0IGEgc3VmZml4 CitwcmVzZW50IGluIGB0YWdzLWNvbXByZXNzaW9uLWluZm8tbGlzdCcuICBJZiB0aGUgZmls ZSBjYW4ndCBiZSBmb3VuZCwKK3NpZ25hbHMgYW4gZXJyb3IuCitFbHNlLCByZXR1cm5zIHRo ZSBmaWxlbmFtZSB0aGF0IGNhbiBiZSB2aXNpdGVkIGZvciBzdXJlLiIKKyAgKGxldCAoKGYg KGxvY2F0ZS1maWxlIGZpbGUgbmlsIChpZiBhdXRvLWNvbXByZXNzaW9uLW1vZGUKKwkJCQkg ICAgIHRhZ3MtY29tcHJlc3Npb24taW5mby1saXN0CisJCQkJICAgJygiIikpKSkpCisgICAg KHVubGVzcyBmCisgICAgICAoc2lnbmFsICdmaWxlLW1pc3NpbmcgKGxpc3QgIkNhbm5vdCBs b2NhdGUgZmlsZSBpbiBUQUdTIiBmaWxlKSkpCisgICAgZikpCisKIChkZWZ1biB0YWdzLS1h bGwtZmlsZXMgKCkKICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgKGxldCAoKGNidWYgKGN1cnJl bnQtYnVmZmVyKSkKQEAgLTE3NTAsNyArMTc2NSw3IEBAIHRhZ3MtLWFsbC1maWxlcwogICAg ICAgICAgIDs7IGxpc3QgbGF0ZXIgcmV0dXJuZWQgYnkgKHRhZ3MtdGFibGUtZmlsZXMpLgog ICAgICAgICAgIChzZXRmIChpZiB0YWlsIChjZHIgdGFpbCkgZmlsZXMpCiAgICAgICAgICAg ICAgICAgKG1hcGNhciAjJ2V4cGFuZC1maWxlLW5hbWUgKHRhZ3MtdGFibGUtZmlsZXMpKSkp KQotICAgICAgZmlsZXMpKSkKKyAgICAgIChtYXBjYXIgIydldGFncy0tZW5zdXJlLWZpbGUg ZmlsZXMpKSkpCiAKIChtYWtlLW9ic29sZXRlLXZhcmlhYmxlICd0YWdzLWxvb3Atb3BlcmF0 ZSAnZmlsZWxvb3AtaW5pdGlhbGl6ZSAiMjcuMSIpCiAoZGVmdmFyIHRhZ3MtbG9vcC1vcGVy YXRlIG5pbApAQCAtMjEzNyw3ICsyMTUyLDcgQEAgZXRhZ3MtLXhyZWYtZmluZC1kZWZpbml0 aW9ucwogICAgICAgICAgICAgICAoYmVnaW5uaW5nLW9mLWxpbmUpCiAgICAgICAgICAgICAg IChwY2FzZS1sZXQqICgodGFnLWluZm8gKGV0YWdzLXNuYXJmLXRhZykpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoYCgsaGludCAsbGluZSAuIF8pIHRhZy1pbmZvKSkKLSAgICAg ICAgICAgICAgICAobGV0KiAoKGZpbGUgKGZpbGUtb2YtdGFnKSkKKyAgICAgICAgICAgICAg ICAobGV0KiAoKGZpbGUgKGV0YWdzLS1lbnN1cmUtZmlsZSAoZmlsZS1vZi10YWcpKSkKICAg ICAgICAgICAgICAgICAgICAgICAgKG1hcmsta2V5IChjb25zIGZpbGUgbGluZSkpKQogICAg ICAgICAgICAgICAgICAgKHVubGVzcyAoZ2V0aGFzaCBtYXJrLWtleSBtYXJrcykKICAgICAg ICAgICAgICAgICAgICAgKGxldCAoKGxvYyAoeHJlZi1tYWtlLWV0YWdzLWxvY2F0aW9uCi0t IAoyLjM0LjEKCg== --------------KJ53njT0QboMc8pMVebS2TAk--