From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#25627: 25.1; `help-make-xrefs' loads `cl-extra.el' now Date: Sun, 5 Feb 2017 11:24:52 -0800 (PST) Message-ID: References: <82c8d359-fd05-4bff-9dba-29d2738d435d@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1486322776 17061 195.159.176.226 (5 Feb 2017 19:26:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Feb 2017 19:26:16 +0000 (UTC) To: 25627@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 05 20:26:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caSRr-00044Q-Gw for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Feb 2017 20:26:07 +0100 Original-Received: from localhost ([::1]:44215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caSRv-0007PQ-Gx for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Feb 2017 14:26:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caSRq-0007PA-0Y for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caSRm-0003Gy-Rz for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:26:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1caSRm-0003Gu-Ob for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1caSRm-0001QQ-JH for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2017 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25627 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25627-submit@debbugs.gnu.org id=B25627.14863227035411 (code B ref 25627); Sun, 05 Feb 2017 19:26:02 +0000 Original-Received: (at 25627) by debbugs.gnu.org; 5 Feb 2017 19:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:56909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caSQo-0001PD-OX for submit@debbugs.gnu.org; Sun, 05 Feb 2017 14:25:02 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:23791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caSQm-0001Oc-Oc for 25627@debbugs.gnu.org; Sun, 05 Feb 2017 14:25:01 -0500 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v15JOssm024084 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <25627@debbugs.gnu.org>; Sun, 5 Feb 2017 19:24:54 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.14.4) with ESMTP id v15JOsY1025486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <25627@debbugs.gnu.org>; Sun, 5 Feb 2017 19:24:54 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v15JOr1h000687 for <25627@debbugs.gnu.org>; Sun, 5 Feb 2017 19:24:54 GMT In-Reply-To: <82c8d359-fd05-4bff-9dba-29d2738d435d@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129000 Archived-At: It's also not clear to me why replacing the 3 `cond' clauses used previously by the clause that uses `cl-some' is TRT (an improvement). Seems to me like a degradation (bug), but I don't have a test case. Was that done to fix some bug? The previous code was able to in some cases determine that the symbol is a face or that it is a variable or that it is a function. That was replaced by the simple `cl-some' clause, which just treats it as a symbol (producing all possible help for it). If that's the approach, why not just do that in all cases? It looks like someone came up with `describe-symbol-backends' for some other purpose and decided it could be reused here: only the second element of each 3-element list entry is used here. Could you please state the rationale behind this change, even if that is not directly related to this bug, which is about unnecessarily loading `cl-extra.el'. Thx. These are the 3 `cond' clauses that were replaced by the generic `cl-some' clause: ((and (facep sym) (save-match-data (looking-at "[ \t\n]+face\\W"))) (help-xref-button 8 'help-face sym)) ((and (or (boundp sym) =09 (get sym 'variable-documentation)) (fboundp sym)) ;; We can't intuit whether to use the ;; variable or function doc -- supply both. (help-xref-button 8 'help-symbol sym)) ((and (or (boundp sym) (get sym 'variable-documentation)) (or (documentation-property sym 'variable-documentation) (documentation-property (indirect-variable sym) 'variable-documentation))) (help-xref-button 8 'help-variable sym)) ((fboundp sym) (help-xref-button 8 'help-function sym)))))))