From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Thu, 21 Nov 2019 17:50:10 +0200 Message-ID: References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="88173"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 16:51:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXojf-000Mmb-OU for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 16:51:11 +0100 Original-Received: from localhost ([::1]:42110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXoje-0001Jt-7x for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 10:51:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54062) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXojX-0001JF-ID for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXojW-000785-IY for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44408) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXojW-00077m-EA for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXojW-00039O-8e for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 10:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157435142212065 (code B ref 38044); Thu, 21 Nov 2019 15:51:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 15:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:53229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXoir-00038X-Qk for submit@debbugs.gnu.org; Thu, 21 Nov 2019 10:50:22 -0500 Original-Received: from mail-ed1-f53.google.com ([209.85.208.53]:37473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXoiq-00038I-FH for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 10:50:21 -0500 Original-Received: by mail-ed1-f53.google.com with SMTP id k14so3215505eds.4 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 07:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BDTazJ4PYSHRaet8EOkxnZLhVuxIhSgdg8Zf/tihVMM=; b=c++0kNPOKeKweEjlmIcMZ0i7thLr4kdZOiXb7c128MePcKcUPlLUzWXi5m41M7CaBi RxaB5VArkqBK5ZJYTq6HzlziAcfQ3tBeWu2pf+L9gyZaUeGODHwozOytGqWte73yEZcU 0Zn/vC8X9eSgcRnxOebeDo9Us94A2v8uf0sRGiwnkwUg77IP0xZqaNpB6ZNmm9yhjh/n k+uZIi0czlaRdNfRK5s1CbpZEGmiQJYW1HJOZkhJl+osamfv6kafokDaSbrCWp0Lf8AC /fEFoTssvPVlkF3DXXgCXkjKZYtScQmj1VvETnNdSmdpANYDTR+VO1piNNH01MfkWNsp OJWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BDTazJ4PYSHRaet8EOkxnZLhVuxIhSgdg8Zf/tihVMM=; b=fSjoWxpiB1ODHvJWBUEryeQuXZ8BdIT/tW82HNbmCYg9eRgSw271cP5biPQb5y9RtO JoIo+M0Lj8L+1Warrj55rcR8XWR5ToBAIfxOULX4mzcAOuzxG2MxW2ZfwyTXhhCpGUj2 nqjbP6Tb0Jy2RloQa0ElNmCZ8Vn2rmHR6FTlUj+u6vXpNrfqwZhfBayyKshuJP7pPzxH mCkXGsyjyH1b4MKoGxl3Bd8g8RpKaYvk768Jfuhyw8GJkneKy2zuQk+N7KwUS43nfWbS yHS+VOsGMoqSOeyOYkqZgSQ4EvnhbgrDPs7qJLj0I+MfnYfoCYFsPqJhAsPSZr5CLjM3 rZcQ== X-Gm-Message-State: APjAAAVmsho26H4gX6LFsHaemLAJkfTy66Flu+V/EBtYA6arOBbIXVfr EPyF9OZg4ZktYLV/N4YP5nnp3wzt X-Google-Smtp-Source: APXvYqyNDVSY3hjUJ1cs4sJ8gMBuFV5PRjlZ5JuVnnQOb1iUX6lg/wlwpbbVzQMdAjg9VAuxiKeY6A== X-Received: by 2002:a17:906:4e48:: with SMTP id g8mr14437587ejw.67.1574351413960; Thu, 21 Nov 2019 07:50:13 -0800 (PST) Original-Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id z31sm109125edz.13.2019.11.21.07.50.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 07:50:13 -0800 (PST) In-Reply-To: <83r221xoll.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172143 Archived-At: On 21.11.2019 16:59, Eli Zaretskii wrote: > I'd prefer this to be a variant of vc-diff, and bound to "C-x v =". > The "C-u C-x v =" form is already taken, and tweaking it to accept a > single revision would not be easy. So how about "C-u C-u C-x v ="? Okay, I see what you mean now: you're basically suggesting to tackle the new behavior (the one everybody wants apparently) on top the 'diff' backend action. Which can kind of work, but I don't see why we would make that choice. Adding a new backend command is relatively cheap, and we won't force the backend implementation to try to reconcile incompatible arguments (e.g. REV1 that is not a parent of REV2 and SHOW-METADATA=t). I also think the current patch proposed by Juri is cleaner than the one that is required to implement your idea. Finally, "C-u C-u C-x v =" doesn't look semantic enough for me (revision != diff in my mind, at least not entirely). I think it would be nicer to have a new command, but opinions welcome on this.