From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#34794: 26.1; doc of `read-buffer' Date: Mon, 11 Mar 2019 09:09:57 -0700 (PDT) Message-ID: References: <<<>>> <<<<831s3g7zv1.fsf@gnu.org>>>> <<>> <<<83r2bf7w21.fsf@gnu.org>>> <> <<83o96i615x.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="186307"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34794@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 11 17:11:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3NWI-000mMp-37 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Mar 2019 17:11:18 +0100 Original-Received: from localhost ([127.0.0.1]:36133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3NWG-0003Sx-Vy for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Mar 2019 12:11:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3NW3-0003Rl-0l for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2019 12:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3NW2-0008RR-4f for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2019 12:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3NW1-0008RC-U4 for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2019 12:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h3NW1-0004AY-L9 for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2019 12:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Mar 2019 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34794 X-GNU-PR-Package: emacs Original-Received: via spool by 34794-submit@debbugs.gnu.org id=B34794.155232060915961 (code B ref 34794); Mon, 11 Mar 2019 16:11:01 +0000 Original-Received: (at 34794) by debbugs.gnu.org; 11 Mar 2019 16:10:09 +0000 Original-Received: from localhost ([127.0.0.1]:39380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3NVA-00049M-Qb for submit@debbugs.gnu.org; Mon, 11 Mar 2019 12:10:09 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:49438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3NV8-00048g-Sm for 34794@debbugs.gnu.org; Mon, 11 Mar 2019 12:10:07 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2BG9TRr068478; Mon, 11 Mar 2019 16:10:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=i4WBMll4jh4t751axFe5bJdKVthDkjc76USkfLTy7Gs=; b=QHWp9rnnZlfdexqgbpYurPnRX4ueDzh0Zc8pGvFd1MbDBxtWjKPv562GXPoDsTrwDJjM tGgVEVlHXoY+LyodcHYeO4fOVa122x0vRf8cHJpqj7VWxv3cohmcZ1Qhlg/fiqBm54su 1dz/un/eq/rWjLjJqQcYUHpDvU7UDG1s4YyWlvaavAPiyYFNc/Y3VQQFKFfVA0DHWnw7 euuqu/HQCLqA1KhYdZb902A1rjAtVlJ8vZ8mUeyTbYWAcoNaZHRsNwoyxCqjvfg3VB0z uEVmUaQi8vRoYbi7X9JNlnnkDO5WBEKvPWe4rozls6AiSYvp8JQQ0sM0jnxs9rcb3PtE kw== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2r464r7cr4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2019 16:10:00 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2BG9wDm030761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2019 16:09:59 GMT Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2BG9wxH026034; Mon, 11 Mar 2019 16:09:58 GMT In-Reply-To: <<83o96i615x.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4810.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9192 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903110116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156238 Archived-At: > > 1. OK. How about this? > Thanks, I used some ideas from your suggestion. Thx. Definitely better than what was there before the bug report. My (minor) feedback, FWIW: 1. It says that the return value is a string buffer name. That's generally, and probably expected to be, the case. But as we've seen, if DEF is not a string or a list of strings then the default return value is not a string. =09 It's an open question whether the doc should discourage using non-string values with DEF. If it should then the doc should do that. If it shouldn't then perhaps the doc should point out that DEF can violate this expectation of a string buffer name (GIGO). 2. "if user enters an empty line, instead of that empty string" is unclear. What empty string? No empty string has been mentioned, so "that" empty string doesn't mean anything. And what does "instead of" refer to? Is the user entering an empty line somehow instead of "that empty string"? Unclear. It should just say that empty input (not an empty "line", BTW - minibuffer input isn't line-oriented) means that the empty string is returned. 3. It should say which buffer names are completion candidates (all live buffers, it seems). This is different, for example, from the case of `read-file-name', which excludes some file names based on option `completion-ignored-extensions'. Many buffers, especially those users interact with, are visiting files, and it's not unreasonable to suppose that `completion-ignored-extension' or another, similar variable applies to `read-buffer'. There is no such variable - users can only use PREDICATE to exclude buffer names. 4. It's unclear that the `read-buffer-function' value, when called, is passed all of the args to `read-buffer', in order.