From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text Date: Tue, 10 Sep 2024 03:58:58 +0300 Message-ID: References: <83e5b9c4-0f5f-49c4-a4b2-fe553c59b2f6@gutov.dev> <86o75bftql.fsf@gnu.org> <119819e3-fc54-4f9a-9075-b07af637db12@gutov.dev> <864j71dw8e.fsf@gnu.org> <48e0fa23-623e-4a73-b968-ba10d766cf37@gutov.dev> <87y14bwvyd.fsf@gmail.com> <9a5884da-44cc-4f9a-9d4a-caf830617c7f@gutov.dev> <6805f597-20ab-4c97-b1bf-1b15856364e0@gutov.dev> <76a2f902-5876-42a3-ad06-b95d6a9959c1@gutov.dev> <867cblvym6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="881"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 72765@debbugs.gnu.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 10 03:00:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snpF1-000Ad0-1R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Sep 2024 03:00:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snpEe-0005jy-EV; Mon, 09 Sep 2024 21:00:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snpEc-0005jp-Uw for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 20:59:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snpEc-00060w-M8 for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 20:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=peHXNWkpewiTBxtDaXBMyVUUeZKajkB4Lq/MkGri+Vc=; b=uf637mEeVYujix0K2xkjYitdVm5mfkWxCzfHSxavir1ONNo/h/Gw7Nj+jw/qPlD4hXYUq9MQHrPvCMWZCfFfqIH5ESZmDjhJkormM1DCWOBkiH7xTHB8B08h2ZktQhsHV5CgXOQYHgOE86ObZe6MdPxKqMjeaq3Fjbzj249xoPSdAk+wuVkmo7PgKJ4qydIpb2U2kL73bsxueCPvCOGMSkzxnX4dky28uHtseOEvHgVkX9psocjO0ToMRkIY3/3o8l35cPhqKkPMmchnhCNU4A7HOP6mwq0ofbYU/WqD32JCamzzuPBlLqX60PUTF1l1pCB6ABGDltABZHqv+rxU9A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snpEg-0007o1-Sc for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 21:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Sep 2024 01:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72765 X-GNU-PR-Package: emacs Original-Received: via spool by 72765-submit@debbugs.gnu.org id=B72765.172592995329918 (code B ref 72765); Tue, 10 Sep 2024 01:00:02 +0000 Original-Received: (at 72765) by debbugs.gnu.org; 10 Sep 2024 00:59:13 +0000 Original-Received: from localhost ([127.0.0.1]:34412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snpDt-0007mT-HM for submit@debbugs.gnu.org; Mon, 09 Sep 2024 20:59:13 -0400 Original-Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]:52371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snpDq-0007mF-IU for 72765@debbugs.gnu.org; Mon, 09 Sep 2024 20:59:11 -0400 Original-Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 1968011401FA; Mon, 9 Sep 2024 20:59:01 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Mon, 09 Sep 2024 20:59:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725929941; x=1726016341; bh=peHXNWkpewiTBxtDaXBMyVUUeZKajkB4Lq/MkGri+Vc=; b= Gz89UVeJdnm2/sf3EJxI3/jnDdIZCXGSbP8U0k37fMWRTYF3D9fCfggRSSv/1DuT J8B9cF/fZO7oyZ/Ou8pdl69vsVpkD1m0EWHspivamcESrFObWgb4xZ1eMsAtlRWJ A3guhq2YspAq+hGO/U38TQLI86KPy7+wy97pefv1VcB7dKHPC/Sj3xi/9abtfrwg dhEwfdND4IjrL35paJ2cSKPbxm6GeS5n57DWOTEj5a87LpzlFZhiSGoWxBD4SeaH Rq4XiYomT7Q1d4dMfRbRrqvJ6j2OC0aRYBuNgTFxRJ7WDBcjEw+MX6Ffh+7GIx28 fU5h9cOAt+uU9mhH+AdteA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725929941; x= 1726016341; bh=peHXNWkpewiTBxtDaXBMyVUUeZKajkB4Lq/MkGri+Vc=; b=J okFI814/5jpI5grUM5wFORhGvjDfBt5MwZR6nM4+VtHLlGGlt1tBrxkCOBh/td/v R2LayHBNQ6bprVH+mxyunnqeFfdh4gauHEkJsHLL0E4O9NHz9nkh9KBgA0Y40yCE aoWhZCUo9yh+LthdC12dc/5tbfCmZGUb81tUE/6OjHZ0ane3e/gvHMtsSBrEn+or YSUSY+5jN68AU9Sg4SHP41LWSubYmdewP9T2Gzc8XTMbvMb5Ijp/kGVi4Ay9iolv ASGjn5XP1aFVMWjH39KdRq4mmh+NjW9clh/NFkOboEgOkFY3TNf9HO4Z8gY0XBhP QJeab4Mh68HX3FrnwtvKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeikedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh dprhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhdprhgtphhtthho peejvdejieehseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Sep 2024 20:58:59 -0400 (EDT) Content-Language: en-US In-Reply-To: <867cblvym6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291533 Archived-At: On 09/09/2024 14:46, Eli Zaretskii wrote: >> Date: Mon, 9 Sep 2024 03:20:01 +0300 >> Cc: Eli Zaretskii , 72765@debbugs.gnu.org >> From: Dmitry Gutov >> >>> This now aborts (segfault?). At least something different. >>> >>> So, for the record, before this patch with the latest emacs-30, I get the >>> results in failure1.txt and with your last redisplay-skip-initial-frame patch >>> I get failure2.txt. >>> >>> I've produced these files with >>> >>> make -C test eglot-tests SELECTOR=\"rust-completion\" 2>&1 | tee failure1.txt >> >> So it's reproducible. Great! >> >> Could someone look into the segfault? The repro steps are simple: >> >> 1) apply the patch above, >> 2) run 'make -C test eglot-tests' or the longer command above which >> executes just one test from that file. >> >> The backtrace that I managed to generate is attached. > > Thanks. Please try the patch below. Thanks! The patch takes care of the crash AFAICS (no core dump now), but alas not of the original test failure. > P.S. I'm not at all sure this is the last segfault you will see > because you are playing with fire: you are not supposed to reset > redisplay-skip-initial-frame to nil in batch-mode tests that test > redisplay-related features! Isn't that the main/only purpose of this variable? That's how the docstring reads to me, and it's also seems why minibuffer-test.el uses it. In any case, this var is neither necessary nor sufficient (see my next email), so sorry if that wasted you time. The fix might still be worth installing, though. > diff --git a/src/xdisp.c b/src/xdisp.c > index bf7d84c..a1319e7 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -22089,7 +22089,8 @@ #define GIVE_UP(X) return 0 > > /* Window must either use window-based redisplay or be full width. */ > if (!FRAME_WINDOW_P (f) > - && (!FRAME_LINE_INS_DEL_OK (f) > + && (FRAME_INITIAL_P (f) > + || !FRAME_LINE_INS_DEL_OK (f) > || !WINDOW_FULL_WIDTH_P (w))) > GIVE_UP (4); >