From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Tue, 9 Feb 2021 01:24:04 +0200 Message-ID: References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> <87im72o6r6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4813"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 46358@debbugs.gnu.org, Protesilaos Stavrou To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 01:23:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Gow-00019D-VQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 01:23:58 +0100 Original-Received: from localhost ([::1]:57290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Gou-0004JX-Vn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 19:23:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Ftu-0002SC-R1 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 18:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Ftu-0002cQ-Iu for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 18:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9Ftu-0003LI-EU for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 18:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161282665412785 (code B ref 46358); Mon, 08 Feb 2021 23:25:02 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 8 Feb 2021 23:24:14 +0000 Original-Received: from localhost ([127.0.0.1]:52130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Ft8-0003K9-He for submit@debbugs.gnu.org; Mon, 08 Feb 2021 18:24:14 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:35166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Ft6-0003Ju-EU for 46358@debbugs.gnu.org; Mon, 08 Feb 2021 18:24:13 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id l12so19297919wry.2 for <46358@debbugs.gnu.org>; Mon, 08 Feb 2021 15:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LyAr3R4hFUxEk7vU0M1us1fNpTSPv7EdiqGM8W+t10Y=; b=U1WWjwMM5ENuw3nbgWEumTyweaChB3IjzejVbY1hvokKUyh3WJwydTJEkTM9sM/sNL mkz8pOndKTIv3Q7z/X8tTzOWT72Jy/343PQP70Hu3R6NZjcBt0a1wyvatjvot+g1TNuv yqP5ZZUrxD/mWmHS6pS5X7kTXSq3K6iN+70dNtOvyTm7nvFzkP3ZapPH230Ia7wGt2iH qOjAsIz6av67NkIwetUGnxArW95emu+F+6yJoa//YMllwqJbXOY4uMfoBxIu+ItFXnt0 8Ts2MdpIl9ElObZkv/lXj/qWquAJR6vQrtBMA/1fAgJQ1JSsqDpRAg+3aAEjjmyI7DFd HVoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LyAr3R4hFUxEk7vU0M1us1fNpTSPv7EdiqGM8W+t10Y=; b=nhZ/Edd/Qtxc8vLD2v3Sb3YyWsBfk9ewhtj0D1tWXEER7l2uC46UvOe/bZWfUhrybd z1oPOU70BP3ZMNwGedWIj4OIdgXO4NnzESJBkJgdxhOKbbIQ3rn6hrrY7Ve14Wf5sQTs DWxeMz8dEEwtZLhr7prgKNck2FxU2++ceVCkQpksy//HzPuts6/XIP/cYcNu58pPieJg tp4v6yRfsXRaMpUJgu54jfwyo0ulKyt+x+2kdgHbUmkJZPq/w7IYWTVpzBe1fxz4cibl j6WAW1/oI7gIc6b2nTTf9gumFNg/ZWd36c4YxRK46jeq4oxh9H+81gBEpI52/z2jKQLV Jk8w== X-Gm-Message-State: AOAM5322a1x523jH/Bm/sjkNtlJ6U53lDU5HEi1l5xc7clVZUWLFqWuA WaCKIbPT5AT1WmcNTCq3pUg= X-Google-Smtp-Source: ABdhPJzcMHjlFw2xt+iImQ2Zcszk00pVATcOtrJ7oG4wW6itDy817s4S97I4M++wG6Q2oxkqPKsllQ== X-Received: by 2002:a5d:690b:: with SMTP id t11mr22413728wru.12.1612826646489; Mon, 08 Feb 2021 15:24:06 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o13sm1213194wmh.2.2021.02.08.15.24.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 15:24:05 -0800 (PST) In-Reply-To: <87im72o6r6.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199644 Archived-At: On 08.02.2021 20:17, Juri Linkov wrote: >>> Very well! I am doing just that in the revised patch. So there should >>> be no visual difference between this and the prior state, except for one >>> case: the empty Git stash header, which will ultimately inherit from >>> 'shadow' (before there was a "FIXME" to disambiguate it from other >>> header values). >> >> Looks good to me; pushed to Emacs 28 now. > > I don't know if anyone else has such problem, but now highlighting > the empty Git stash header with a different color distinguishes it > from other header lines, and thus attracts more attention. > So now the most noticeable thing in the vc-dir is the Git stash header > (that I almost never use). It looks okay-ish for me, but that must depend on a particular theme. > Maybe better to display the empty Git stash header using the default > colors, and then highlight it differently only when it's non-empty? Not with vc-dir-ignored, though (it is based on the 'shadow' face).