From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48409: Text runs away before user can copy it Date: Thu, 20 May 2021 18:54:45 +0200 Message-ID: References: <87cztt4yg9.5.fsf@jidanni.org> <83fsypztd4.fsf@gnu.org> <87cztt9qdj.fsf@mail.linkov.net> <83mtsxxfo8.fsf@gnu.org> <87h7j12j93.fsf@mail.linkov.net> <83bl98rxqo.fsf@gnu.org> <83k0nvrhgg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------458BA38FDF78F9747EFEE509" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4243"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48409@debbugs.gnu.org, juri@linkov.net To: Alan Mackenzie , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 20 18:55:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljlx0-0000zM-6i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 18:55:10 +0200 Original-Received: from localhost ([::1]:44832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljlwz-0005YN-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 12:55:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljlws-0005YE-GI for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 12:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljlws-0000NO-8L for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljlws-0001P2-4W for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2021 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48409 X-GNU-PR-Package: emacs Original-Received: via spool by 48409-submit@debbugs.gnu.org id=B48409.16215297005382 (code B ref 48409); Thu, 20 May 2021 16:55:02 +0000 Original-Received: (at 48409) by debbugs.gnu.org; 20 May 2021 16:55:00 +0000 Original-Received: from localhost ([127.0.0.1]:35116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljlwp-0001Oj-Ow for submit@debbugs.gnu.org; Thu, 20 May 2021 12:55:00 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:56209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljlwl-0001OT-1R for 48409@debbugs.gnu.org; Thu, 20 May 2021 12:54:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621529686; bh=clTmIMu6sGoDKi5WRh+7uacEnOgxurSfhhSs88PQMKI=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=Yb9QtA28/gtPcHn4GxA9OPLgOhlqkJAM2ByuvBgSKyqssD+/+AC2EQ+KmJVYX2Lij PSV34eZ2YTgxqn3Ht505n9qsXdNfU0tPVN1MG3bl4oSmwTPNP+pHq6wULfgpmD3YT9 E7af7G2Z2v6fny1XNXLfJDX3MR/CKEJ7ARl+lGvI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([213.142.96.175]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1My32L-1lXJtZ22G7-00zaeL; Thu, 20 May 2021 18:54:46 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:L186QoZPKcjMmTpKEUMBVhtwGaE4Zrfoanbh6ChmofOCa8WghNY CF3ZMq1FD1lo4TPnCET8Hly9AUUD2iVDy8h37QdLACpjgUVPqSxrNiY60AxWNcDmKypk+RP uFz3fIhlCjHVwrvRCRlYVOHa1Bukv4gN0Mh0XwQ7dzDzN9gSnCq4tbPlTTb+m+gw0Ps9dUY VmMKv6uPAhzHJKY8Xtfig== X-UI-Out-Filterresults: notjunk:1;V03:K0:pleOxvQ8I3Q=:IC64bcXdSKX5RWfzR0sf1f k3ofuC2nxw24Q7AT+KV9MjgS8gkcYm/9uKpHaCZdSVbbV1HmsV7HHrSg8cp02x/PCbJOJ3PkH xu/2wfVrWX2xdFk51EDFWe1jdCuCocNzUJjOTWty2QPvkOMSEaUum+qhhkxQCMw8ga6WIgrgd ycc6Td7ZoluafHFnzrBCf52LNaVhW+ekG4owl39+C+Ph8p3ZVn2EcfUxXo6B50Che1+0KfPfz mNY3lTKgU6qV8lVRMwxpezdriB/GSpoqOFLf7NfySE+7KywpVZlHcTegT5OLBtxaM2dnJdnoV VgR0cvfRw9+FtkJnXRtpcgHnDhAk1WMV/icdN+ikkDQoErxbO8k0dWAaUAoNHrpQX2KIDwsYs NRRxGVuB/rf94viXyLvnAN3Z2e5KMWz9a4htSnNgHwdpgzFAtVISA3WwHNEDda0o9ajP7tUhJ 7+X1xiipweF7rSzqaaMSacoFFFiu+AisJJKa50huvZX14CcHBh8wdBhnKev4j+vPdYkB0p+Pw ERqKrMC6w85L/k2RZufCBIrI89cCENWxkzP9N4APHErBG7xZDK9yKVDCrUYtxI3Ofw0UWSWJ5 mhN9kvBnuSCktHXgEV9W6L+G/J+rKARFLPQSEt2k/iOcnhD4Z1c/B2qF1GKdC/vYim/IpebJY 7G6vVmtEih870KzbEI87RyGvN9HTKH+A0emRNQS5Y4vKWVtpxm/m1cTFFWS5NLF+JW3GSm4iZ zH/67/8VAEMqUjydY+n7mQFAmN3EFKBjCE3sgLXN3fvOv8VV6MVT0sYRTW0Q3SVZ92TLe4vd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206951 Archived-At: This is a multi-part message in MIME format. --------------458BA38FDF78F9747EFEE509 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > For clicks into the bottom line the attached might help. Clicks above > must be caught elsewhere. But you don't get a drag event and no error > message for them. The attached patch should allow clicking anywhere in the minibuffer window. Its more than kludgy but this is a bug that has annoyed me for years. martin --------------458BA38FDF78F9747EFEE509 Content-Type: text/x-patch; name="keyboard.c.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="keyboard.c.diff" diff --git a/src/keyboard.c b/src/keyboard.c index 47b5e59024..92f842f2d7 100644 =2D-- a/src/keyboard.c +++ b/src/keyboard.c @@ -5625,11 +5625,12 @@ make_lispy_event (struct input_event *event) start_pos =3D *start_pos_ptr; *start_pos_ptr =3D Qnil; + struct frame *f; + { /* On window-system frames, use the value of double-click-fuzz as is. On other frames, interpret it as a multiple of 1/8 characters. */ - struct frame *f; intmax_t fuzz; if (WINDOWP (event->frame_or_window)) @@ -5727,9 +5728,48 @@ make_lispy_event (struct input_event *event) it's probably OK to ignore it as well. */ && EQ (Fcar (Fcdr (start_pos)), Fcar (Fcdr (position))))) { - /* Mouse has moved enough. */ - button_down_time =3D 0; - click_or_drag_modifier =3D drag_modifier; + Lisp_Object start_window =3D XCAR (start_pos); + Lisp_Object pos_window =3D XCAR (position); + + /* For the minibuffer window special precautions are + needed because it may change its height in between + two clicks. */ + if (WINDOW_LIVE_P (pos_window) + && WINDOW_LIVE_P (start_window) + && MINI_WINDOW_P (XWINDOW (start_window))) + { + struct window *start_w =3D XWINDOW (start_window); + struct window *pos_w =3D XWINDOW (pos_window); + + if (start_w =3D=3D pos_w + && WINDOW_PIXEL_HEIGHT (pos_w) >=3D XFIXNUM (XCDR (down)) + && WINDOW_PIXEL_WIDTH (pos_w) >=3D XFIXNUM (XCAR (down))) + /* Mouse has moved enough. */ + { + button_down_time =3D 0; + click_or_drag_modifier =3D drag_modifier; + } + else if (start_w !=3D pos_w + && (WINDOW_PIXEL_HEIGHT (start_w) >=3D XFIXNUM (XCDR (down)) + || WINDOW_PIXEL_WIDTH (start_w) >=3D XFIXNUM (XCDR (down)))) + /* Artificially move mouse into the minibuffer + window's new text area. */ + position + =3D make_lispy_position (f, + make_fixnum (WINDOW_BOX_LEFT_EDGE_X (start_w) + + WINDOW_LEFT_FRINGE_WIDTH (start_w) + + WINDOW_LEFT_MARGIN_WIDTH (start_w) + + 1), + make_fixnum (WINDOW_TOP_EDGE_Y (start_w) + 1), + event->timestamp); + } + else + /* Mouse has moved enough. */ + { + button_down_time =3D 0; + click_or_drag_modifier =3D drag_modifier; + } + } } --------------458BA38FDF78F9747EFEE509--