From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#35564: 27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters Date: Thu, 9 May 2019 10:13:06 +0200 Message-ID: References: <87zho2cd4f.fsf@gmail.com> <071cc96c-1bf2-f331-8f9e-b3c54a7452da@gmx.at> <877eb3e5im.fsf@gmail.com> <9bd289fe-3623-4c45-4c4f-04c6668cae76@gmx.at> <9fc1129c-5377-4b56-ba6d-dce497140941@default> <877eb0ptiy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="143823"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35564@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 09 10:14:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOeBy-000bJI-6E for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 10:14:14 +0200 Original-Received: from localhost ([127.0.0.1]:50162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOeBx-0007vs-66 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 04:14:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOeBr-0007vm-2t for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 04:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOeBp-0004uJ-5Z for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 04:14:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49305) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOeBm-0004tS-WC for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 04:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOeBl-0001Cp-RE for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 04:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 08:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.15573895964571 (code B ref 35564); Thu, 09 May 2019 08:14:01 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 9 May 2019 08:13:16 +0000 Original-Received: from localhost ([127.0.0.1]:34615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOeB2-0001Bd-JW for submit@debbugs.gnu.org; Thu, 09 May 2019 04:13:16 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:33521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOeB0-0001BQ-9F for 35564@debbugs.gnu.org; Thu, 09 May 2019 04:13:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557389583; bh=+XoNa+viqVNcEV0jW9P+P/PzfjLxvHu7RT2wfawZ400=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=kO+Jek/ZrJlMP1noHZ9CYJ7exanyX5gwuTuMiWt5bE67pnC3YBBcd8kDWU+ec1fhr dyi3PNICiDljB3OGAYrQvxN2YMmWVuaEXb1S4++kvJgc7+cALtsRQ0eOfbpLzfiUZ7 VIDJaOmU4IMavCSXWHFetRrUtPqdZPgNsyznOJrk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.238]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MTTKZ-1hG1cW1hJf-00SMcQ; Thu, 09 May 2019 10:13:03 +0200 In-Reply-To: <877eb0ptiy.fsf@gmail.com> Content-Language: de-DE X-Provags-ID: V03:K1:wHIfpgAhk8T10624QlPQ0nhf6/UkMzCOaEtGAUTRDJCuozUEjdk 6PajqNKieaGekE8aLGEqY4xPD1TwUYXZx1+A6jbwOrztcv3/pxAEsu2h9owcsYY3Xv1F4ZM 8siWoE3ZATgRv0ib9KhxYzK9fUxYoATY79vVMOmQ1klqrQz+c7u4vHb2Mw9eKJLCvLF04zX lVTLO2spnvarw6htRItUg== X-UI-Out-Filterresults: notjunk:1;V03:K0:vyKLGKePqYI=:wANLkcwLjjRBBLHM7f3Jn8 nwLwlkclc5wKXs0tyGtIypsnlCeE/S9HsZOhCGu6B2Q9kCflK5tZPQEo4eJeJLnTkFs/eGWDt c2CNuUiqe3q2NjvU1rcY8eXr12EQR6Ohw0wY7mBIIqcgJJyWXKMYpiVseBru1jN/4q11Q9Vkz FhqWk1rWYG8+4PAyTeHgkJGwYz2VKwMO4LbWnCixAN5tixVu6gL4IB1rzuLFrw3/hngVpSLb2 BqMzCViM2Mdfm2qmBgxRQf16emYY8mTtzSPZLbvwbFIzfjwmu+WAqYgAglHkNHjQFsudW1yIl lROhOPf3XuPN0uG5LBUXixVXI0hepP+ULR3HvZzFn03bdF+biESaTceIgdD+gBPNbpYloItIG 4etzsdxWM4ALXFqy8cVLE8pYGWoRwjt0IG2lnOSV+VBh+5pCuZTAPCOATwf6r41cR8vMjw5Xt SGSfTiFOXPMmdYK1qQ90/IT0MIx+FsoyXzJweJPN2y8iBBczkkzKIqy7edDPukvjsmjVXqlyM 4favdlvdv9LOr9AVo9YbHiypG9VfRFAJTfXpVgDWzlfrcuvoMZG17rJGBKEjKZ9KHVS8gLzTN EXd3+3y5auBFVo18Fs5jVrTR3IPjU747eik+/I3z4IgYHj+Clwcah/XEd/pNTZ+u5/km1ROXW WLZKssE9fawoyaLU+Pn/2NaH5qwEk1UlGHe9worn26A0OGZbQZHYRLp1o7o3QmIZUbz3+1oxu 7RxaOsm4R1byDaRF4+kz4Zb2ZPXlCZKVN6ei6nHpdG9ET5hsh3ROzqnObxc0G3tfE6ZcbNHG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158971 Archived-At: > (Perhaps those clients could be migrated to a new face, > e.g. 'message-prompt', which would inherit 'minibuffer-prompt' by > default?) Simply 'prompt' would be more intuitive since most messages do not show prompts. But I'm afraid we'll have to stick to what we have now. > Fair enough. Should I raise the issue on emacs-devel, or create a new > bug report? Just to make sure I am not omitting something, is this how > you would sum up the issue? > > - In the context of bug#35564, I would like to add text properties to > the y-or-n-p prompt (although I'm open to other, simpler solutions > e.g. simply changing Dired's message). > > - While this can be patched within y-or-n-p and we can call it a day, > the minibuffer-prompt-face-adding code could be factored out of > 'read_minibuf'. > > - This raises two questions: > > 1. Do we actually want to use the 'minibuffer-prompt' face in this > context, since the minibuffer is not involved? > > 2. What do we do with other clients of 'minibuffer-prompt', which > use the same (propertize prompt 'face 'minibuffer-prompt) idiom? That would sum it up (but since I don't use Dired I can't comment on that). Note that this isssue also touches one Drew raised elsewhere - whether 'tooltip-show' should retain face properties of the original text or show text uniformly with the 'tooltip' face. Maybe we should introduce an option like 'prompts-retain-text-properites' so users have the choice. > [1] AFAICT, the commit that added this face (927be33, back when y-or-n-p > was still a C function) does not say why this was thought to be a > good idea. It's probably part of a concept to have prompts appear uniformly and integrate them into the framework of themes. Note that Emacs usually cannot control the appearance of dialog boxes or system tooltips. martin