From: Jim Porter <jporterbugs@gmail.com>
To: Robin Campbell Joy <emacs@robinjoy.net>, 71107@debbugs.gnu.org
Subject: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase
Date: Wed, 22 May 2024 21:35:29 -0700 [thread overview]
Message-ID: <fbcd301d-497b-d8f7-8b9b-0ffcb629566c@gmail.com> (raw)
In-Reply-To: <CADzxVkGyByGtiOpKU4CLmcnge=h7An4JX+X+FMgDd_xLoyny2g@mail.gmail.com>
On 5/22/2024 1:21 AM, Robin Campbell Joy wrote:
> Severity: minor
> Tags: patch
>
> In case of eshell-hist-ingoredups set to 'erase, history handling isn't
> working correctly.
I believe this should already be fixed by commit 7b0f24ab1f9 from bug#63360.
However, I didn't bother to account for the case where there may be
multiple entries to remove (I just added a FIXME note since it seemed
like a low priority). If removing multiple duplicates is important to
you, would you be willing to rebase your patch on top of the master
branch? Thanks either way.
next prev parent reply other threads:[~2024-05-23 4:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 8:21 bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Robin Campbell Joy
2024-05-23 4:35 ` Jim Porter [this message]
2024-05-23 6:22 ` Robin Campbell Joy
2024-05-23 23:33 ` Jim Porter
2024-05-24 5:55 ` Eli Zaretskii
2024-05-25 2:38 ` Jim Porter
2024-05-24 12:29 ` Robin Campbell Joy
2024-05-25 2:35 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbcd301d-497b-d8f7-8b9b-0ffcb629566c@gmail.com \
--to=jporterbugs@gmail.com \
--cc=71107@debbugs.gnu.org \
--cc=emacs@robinjoy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).