From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#25816: Emacs xwidget GC issue with callback Date: Mon, 20 Feb 2017 09:10:32 -0800 Organization: UCLA Computer Science Department Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------A60ABE78E877EAF2C0973A42" X-Trace: blaine.gmane.org 1487610677 1696 195.159.176.226 (20 Feb 2017 17:11:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2017 17:11:17 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 Cc: Ricardo Wurmus , Joakim Verona To: 25816@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 20 18:11:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfrUR-00085h-Mo for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 18:11:07 +0100 Original-Received: from localhost ([::1]:40041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfrUX-0006Ee-6Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 12:11:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfrUQ-0006EO-Nv for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfrUM-00008Q-Kp for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:11:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cfrUM-00008L-HA for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cfrUM-00076N-Cn for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2017 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Emacs bug reports and feature requests Original-Received: via spool by submit@debbugs.gnu.org id=B.148761065427283 (code B ref -1); Mon, 20 Feb 2017 17:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Feb 2017 17:10:54 +0000 Original-Received: from localhost ([127.0.0.1]:47721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfrUE-00075y-5d for submit@debbugs.gnu.org; Mon, 20 Feb 2017 12:10:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfrUC-00075l-GY for submit@debbugs.gnu.org; Mon, 20 Feb 2017 12:10:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfrU6-0008Uf-Cr for submit@debbugs.gnu.org; Mon, 20 Feb 2017 12:10:47 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cfrU6-0008US-7T for submit@debbugs.gnu.org; Mon, 20 Feb 2017 12:10:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfrU4-0006E8-Rt for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:10:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfrU0-0008TV-OE for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:10:44 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42726) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cfrU0-0008T7-AK for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 12:10:40 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 55CF31600D8; Mon, 20 Feb 2017 09:10:38 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id lwsIXf8zI6pd; Mon, 20 Feb 2017 09:10:37 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 717481600DA; Mon, 20 Feb 2017 09:10:37 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IBWfMxXUBXLy; Mon, 20 Feb 2017 09:10:37 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 50E461600D8; Mon, 20 Feb 2017 09:10:37 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129576 Archived-At: This is a multi-part message in MIME format. --------------A60ABE78E877EAF2C0973A42 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable When configuring with --with-xwidgets --enable-check-lisp-object-type the= Emacs=20 build would fail due to a type confusion in src/xwidget.c, which I attemp= ted to=20 fix by installing the attached patch. However, as noted in the patch, thi= s code=20 appears to have a garbage-collection bug, as it converts a Lisp_Object to= a C=20 pointer and stores that pointer (for what appears to be an indefinite per= iod of=20 time) into a C object that the garbage collector does not know about. If=20 garbage-collection reclaims the object before the callback is used, disas= ter can=20 occur. As I don't know the lifetime of the C object I'm reluctant to try = to fix=20 this myself, so I'm filing this bug report in the hope that an xwidget ex= pert=20 can fix it. --------------A60ABE78E877EAF2C0973A42 Content-Type: text/plain; charset=UTF-8; name="0001-Port-xwidget-to-DCHECK_LISP_OBJECT_TYPE.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Port-xwidget-to-DCHECK_LISP_OBJECT_TYPE.txt" RnJvbSA1YmFjZWZmOTJkODk0N2VkNWI2NGZhZGFlODA4YjM2NmY1Y2ExZGE3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDIwIEZlYiAyMDE3IDA4OjUzOjUwIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gUG9ydCB4d2lkZ2V0IHRvIC1EQ0hFQ0tfTElTUF9PQkpFQ1RfVFlQRQpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVu dC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKKiBzcmMveHdpZGdldC5jICh3ZWJraXRfamF2 YXNjcmlwdF9maW5pc2hlZF9jYikKKEZ4d2lkZ2V0X3dlYmtpdF9leGVjdXRlX3NjcmlwdCk6 IERvbid0IGFzc3VtZSBMaXNwX09iamVjdCBpcyBhbgppbnRlZ2VyLiAgVGhpcyBmaXggaXMg anVzdCBhIGhhY2s7IEnigJlsbCBmaWxlIGEgYnVnIHJlcG9ydCBhYm91dAp0aGUgdW5kZXJs eWluZyBwcm9ibGVtLgotLS0KIHNyYy94d2lkZ2V0LmMgfCAxNyArKysrKysrKysrKystLS0t LQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvc3JjL3h3aWRnZXQuYyBiL3NyYy94d2lkZ2V0LmMKaW5kZXggNWMyNzZi MS4uZGM3MDViYiAxMDA2NDQKLS0tIGEvc3JjL3h3aWRnZXQuYworKysgYi9zcmMveHdpZGdl dC5jCkBAIC0zODksNyArMzg5LDEwIEBAIHdlYmtpdF9qYXZhc2NyaXB0X2ZpbmlzaGVkX2Ni IChHT2JqZWN0ICAgICAgKndlYnZpZXcsCiAgICAgLyogUmVnaXN0ZXIgYW4geHdpZGdldCBl dmVudCBoZXJlLCB3aGljaCB0aGVuIHJ1bnMgdGhlIGNhbGxiYWNrLgogICAgICAgIFRoaXMg ZW5zdXJlcyB0aGF0IHRoZSBjYWxsYmFjayBydW5zIGluIHN5bmMgd2l0aCB0aGUgRW1hY3MK ICAgICAgICBldmVudCBsb29wLiAgKi8KLSAgICBzdG9yZV94d2lkZ2V0X2pzX2NhbGxiYWNr X2V2ZW50ICh4dywgKExpc3BfT2JqZWN0KWxpc3BfY2FsbGJhY2ssCisgICAgLyogRklYTUU6 IFRoaXMgbWlnaHQgbGVhZCB0byBkaXNhc3RlciBpZiBMSVNQX0NBTExCQUNL4oCZcyBvYmpl Y3QKKyAgICAgICB3YXMgZ2FyYmFnZSBjb2xsZWN0ZWQgYmVmb3JlIG5vdy4gIFNlZSB0aGUg RklYTUUgaW4KKyAgICAgICBGeHdpZGdldF93ZWJraXRfZXhlY3V0ZV9zY3JpcHQuICAqLwor ICAgIHN0b3JlX3h3aWRnZXRfanNfY2FsbGJhY2tfZXZlbnQgKHh3LCBYSUwgKChpbnRwdHJf dCkgbGlzcF9jYWxsYmFjayksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbGlzcF92YWx1ZSk7CiB9CiAKQEAgLTcxNCw4ICs3MTcsMTMgQEAgYXJndW1lbnQgcHJv Y2VkdXJlIEZVTi4qLykKICAgaWYgKCFOSUxQIChmdW4pICYmICFGVU5DVElPTlAgKGZ1bikp CiAgICAgd3JvbmdfdHlwZV9hcmd1bWVudCAoUWludmFsaWRfZnVuY3Rpb24sIGZ1bik7CiAK LSAgdm9pZCAqY2FsbGJhY2sgPSAoRlVOQ1RJT05QIChmdW4pKSA/Ci0gICAgJndlYmtpdF9q YXZhc2NyaXB0X2ZpbmlzaGVkX2NiIDogTlVMTDsKKyAgR0FzeW5jUmVhZHlDYWxsYmFjayBj YWxsYmFjaworICAgID0gRlVOQ1RJT05QIChmdW4pID8gd2Via2l0X2phdmFzY3JpcHRfZmlu aXNoZWRfY2IgOiBOVUxMOworCisgIC8qIEZJWE1FOiBUaGlzIGhhY2sgbWlnaHQgbGVhZCB0 byBkaXNhc3RlciBpZiBGVU4gaXMgZ2FyYmFnZQorICAgICBjb2xsZWN0ZWQgYmVmb3JlIHN0 b3JlX3h3aWRnZXRfanNfY2FsbGJhY2tfZXZlbnQgbWFrZXMgaXQgdmlzaWJsZQorICAgICB0 byBMaXNwIGFnYWluLiAgU2VlIHRoZSBGSVhNRSBpbiB3ZWJraXRfamF2YXNjcmlwdF9maW5p c2hlZF9jYi4gICovCisgIGdwb2ludGVyIGNhbGxiYWNrX2FyZyA9IChncG9pbnRlcikgKGlu dHB0cl90KSBYTEkgKGZ1bik7CiAKICAgLyogSmF2YVNjcmlwdCBleGVjdXRpb24gaGFwcGVu cyBhc3luY2hyb25vdXNseS4gIElmIGFuIGVsaXNwCiAgICAgIGNhbGxiYWNrIGZ1bmN0aW9u IGlzIHByb3ZpZGVkIHdlIHBhc3MgaXQgdG8gdGhlIEMgY2FsbGJhY2sKQEAgLTcyMyw4ICs3 MzEsNyBAQCBhcmd1bWVudCBwcm9jZWR1cmUgRlVOLiovKQogICB3ZWJraXRfd2ViX3ZpZXdf cnVuX2phdmFzY3JpcHQgKFdFQktJVF9XRUJfVklFVyAoeHctPndpZGdldF9vc3IpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNTREFUQSAoc2NyaXB0KSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCAvKiBjYW5jZWxhYmxlICovCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2FsbGJhY2ssCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGdwb2ludGVyKSBmdW4pOworICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNhbGxiYWNrLCBjYWxsYmFja19hcmcpOwogICByZXR1 cm4gUW5pbDsKIH0KIAotLSAKMi45LjMKCg== --------------A60ABE78E877EAF2C0973A42--