From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cecilio Pardo Newsgroups: gmane.emacs.bugs Subject: bug#73730: 31.0.50; Support for color fonts on MS-Windows Date: Sat, 26 Oct 2024 22:13:57 +0200 Message-ID: References: <36a6b4d5-c719-44d6-957d-bcd7db5a854b@imayhem.com> <86o73s14x5.fsf@gnu.org> <0a0c622c-5b69-4f30-94b1-67a238e124b4@imayhem.com> <861q0gqpkf.fsf@gnu.org> <0d2238ff-5cf9-4ba7-97ab-11b76892198d@imayhem.com> <86bjzjp7vv.fsf@gnu.org> <80dc50bd-b2d4-4d21-ad38-322412588b3b@imayhem.com> <86o73ej2u7.fsf@gnu.org> <8e5ffc88-dda8-4b4d-a133-f80029825347@imayhem.com> <86plnrdtm1.fsf@gnu.org> <86bjzaemev.fsf@gnu.org> <68b9d35b-b8e1-4830-8ad9-8c33258e0980@imayhem.com> <864j50d4od.fsf@gnu.org> <78477402-2af1-4da1-bf02-11d1b0e4b4a0@imayhem.com> <86msisbder.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------LFkLMBThjXP4z7rLaGhIyG84" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31658"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73730@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 26 22:14:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t4nBU-00086m-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Oct 2024 22:14:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4nB8-0000OP-Iq; Sat, 26 Oct 2024 16:14:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4nB7-0000OH-6g for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2024 16:14:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t4nB6-00053I-UX for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2024 16:14:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:From:MIME-Version:Date:To:Subject; bh=i5/vgnazsT/jfqzxYPEeV5vFjTXWuBVJT89SlVFRRE8=; b=iXJE+37ttgABS1qELMVRqIPhizS36t+pLGmXY8ZeVKdD/ZHsUB50rFXFDNH1TzGdIGOYD7IWUAna/+UrNipyfOY7Vg4V6+cfUX6kTDjiyh7J3noW0Xfzk6yr/zs5YfgopGpJfoKDTCxoB1Bsa1Cb+fcZ2al6dNg/tjFw5WmUuzjVrlR8KDBP9JBl+BMmAos63YKbP489AsCIpRo4FGtqqtXVkXj1BFTcQy6DE/PxrpxbCq4hg/d+XmMZygxLJyB6iFPIxJyspN+UG1vmz0TQhvmwRm2CJiiyRtCbHtcNK/sUZaiEPFs/pftj4Dj4RvkxW7KYlMvG5vT9lnZt/+xIXQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t4nBd-00089i-Os for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2024 16:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Oct 2024 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73730 X-GNU-PR-Package: emacs Original-Received: via spool by 73730-submit@debbugs.gnu.org id=B73730.172997368031305 (code B ref 73730); Sat, 26 Oct 2024 20:15:01 +0000 Original-Received: (at 73730) by debbugs.gnu.org; 26 Oct 2024 20:14:40 +0000 Original-Received: from localhost ([127.0.0.1]:42688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4nBH-00088o-Ng for submit@debbugs.gnu.org; Sat, 26 Oct 2024 16:14:40 -0400 Original-Received: from mail.imayhem.com ([82.223.54.191]:59337 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4nBG-00088a-OS for 73730@debbugs.gnu.org; Sat, 26 Oct 2024 16:14:39 -0400 Original-Received: from [192.168.68.104] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 9E3BD80100; Sat, 26 Oct 2024 20:13:58 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.104] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Language: es-ES In-Reply-To: <86msisbder.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294295 Archived-At: This is a multi-part message in MIME format. --------------LFkLMBThjXP4z7rLaGhIyG84 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >>> Thanks, I will review this shortly. Meanwhile, could you please look >>> at how Emacs with this patch displays some complex Emoji sequences? >>> Some of them look incorrect to me. For example, this sequence from >>> admin/unidata/emoji-zwj-sequences.txt: >>> >>> 1F469 200D 1F469 200D 1F467 200D 1F466 ; RGI_Emoji_ZWJ_Sequence ; family: woman, woman, girl, boy # E2.0 [1] (๐Ÿ‘ฉโ€๐Ÿ‘ฉโ€๐Ÿ‘งโ€๐Ÿ‘ฆ) >>> >>> when displayed using Segoe UI Emoji, is shown with the "boy" part >>> overlapping the closing parenthesis, which looks incorrect to me. >>> "C-u C-x =" claims all of the codepoints of the sequence were composed >>> into a single grapheme cluster, but it doesn't look like that on >>> display, and the cursor doesn't include the "boy" part. >> >> I dont's see that, but I do see that the individual glyphs are truncated >> on the left side, even when removing color rendering. Do you see >> it? > > Yes. > >> I will investigate this first, in case the defects are related. This patch fixes the left side glyph truncation, which happens when glyphs have negative left bearing. About the problem you reported, I can't reproduce when building for 64bit. It does show when building with mingw32 for 32bit. It also shows when building version 30.0.92. Maybe is the Harfbuzz version? I have 2.4.0 for this build. --------------LFkLMBThjXP4z7rLaGhIyG84 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-problem-with-DirectWrite-MS-Windows.patch" Content-Disposition: attachment; filename="0001-Fix-problem-with-DirectWrite-MS-Windows.patch" Content-Transfer-Encoding: base64 RnJvbSA0OWUzNTM0OTAxYjJiN2I4MzJlYzE1OTc3ZDc4OTYyYTYyNDE3Nzg5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDZWNpbGlvIFBhcmRvIDxjcGFyZG9AaW1heWhlbS5j b20+CkRhdGU6IFNhdCwgMjYgT2N0IDIwMjQgMTc6NTE6MjIgKzAyMDAKU3ViamVjdDogW1BB VENIXSA7IEZpeCBwcm9ibGVtIHdpdGggRGlyZWN0V3JpdGUgKE1TLVdpbmRvd3MpCgpOZWdh dGl2ZSBsYmVhcmluZ3Mgd2VyZSBub3QgaGFuZGxlZC4KCiogc3JjL3czMmR3cml0ZS5jICh3 MzJfZHdyaXRlX2RyYXcpOiBNb2RpZmllZCB0byBoYW5kbGUgbmVnYXRpdmUKbGJlYXJpbmcu Ci0tLQogc3JjL3czMmR3cml0ZS5jIHwgMTIgKysrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgNyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy93 MzJkd3JpdGUuYyBiL3NyYy93MzJkd3JpdGUuYwppbmRleCBlY2MzM2FmNWYzZi4uNDViZTVi NWJlZmYgMTAwNjQ0Ci0tLSBhL3NyYy93MzJkd3JpdGUuYworKysgYi9zcmMvdzMyZHdyaXRl LmMKQEAgLTg5NSw3ICs4OTUsOSBAQCB3MzJfZHdyaXRlX2RyYXcgKEhEQyBoZGMsIGludCB4 LCBpbnQgeSwgdW5zaWduZWQgKmdseXBocywgaW50IGxlbiwKICAgICAgIHJldHVybiBmYWxz ZTsKICAgICB9CiAKLSAgaW50IGJpdG1hcF93aWR0aCA9IG1ldHJpY3Mud2lkdGggKyBtZXRy aWNzLnJiZWFyaW5nOworICBpbnQgbGVmdF9tYXJnaW4gPSBtZXRyaWNzLmxiZWFyaW5nIDwg MCA/IC1tZXRyaWNzLmxiZWFyaW5nIDogMDsKKworICBpbnQgYml0bWFwX3dpZHRoID0gbGVm dF9tYXJnaW4gKyBtZXRyaWNzLndpZHRoICsgbWV0cmljcy5yYmVhcmluZzsKICAgaW50IGJp dG1hcF9oZWlnaHQgPSBmb250LT5hc2NlbnQgKyBmb250LT5kZXNjZW50OwogCiAgIC8qIFdl IG5ldmVyIHJlbGVhc2UgdGhpcywgZ2V0X2JpdG1hcF9yZW5kZXJfdGFyZ2V0IHJldXNlcyBp dC4gICovCkBAIC05MTQsNyArOTE2LDcgQEAgdzMyX2R3cml0ZV9kcmF3IChIREMgaGRjLCBp bnQgeCwgaW50IHksIHVuc2lnbmVkICpnbHlwaHMsIGludCBsZW4sCiAgICAgPSBiaXRtYXBf cmVuZGVyX3RhcmdldC0+bHBWdGJsLT5HZXRNZW1vcnlEQyAoYml0bWFwX3JlbmRlcl90YXJn ZXQpOwogCiAgIC8qIENvcHkgdGhlIGJhY2tncm91bmQgcGl4ZWwgdG8gdGhlIHJlbmRlciB0 YXJnZXQgYml0bWFwLiAgKi8KLSAgQml0Qmx0ICh0ZXh0X2RjLCAwLCAwLCBiaXRtYXBfd2lk dGgsIGJpdG1hcF9oZWlnaHQsIGhkYywgeCwgeSwgU1JDQ09QWSk7CisgIEJpdEJsdCAodGV4 dF9kYywgMCwgMCwgYml0bWFwX3dpZHRoLCBiaXRtYXBfaGVpZ2h0LCBoZGMsIHggLSBsZWZ0 X21hcmdpbiwgeSwgU1JDQ09QWSk7CiAKICAgVUlOVDE2ICppbmRpY2VzID0gU0FGRV9BTExP Q0EgKGxlbiAqIHNpemVvZiAoVUlOVDE2KSk7CiAKQEAgLTk0OCw3ICs5NTAsNyBAQCB3MzJf ZHdyaXRlX2RyYXcgKEhEQyBoZGMsIGludCB4LCBpbnQgeSwgdW5zaWduZWQgKmdseXBocywg aW50IGxlbiwKICAgSURXcml0ZUNvbG9yR2x5cGhSdW5FbnVtZXJhdG9yICpsYXllcnM7CiAg IC8qIFRoaXMgY2FsbCB3aWxsIHRlbGwgdXMgaWYgd2UgaGF2ZSB0byBoYW5kbGUgYW55IGNv bG9yIGdseXBocy4gICovCiAgIGhyID0gZHdyaXRlX2ZhY3RvcnkyLT5scFZ0YmwtPlRyYW5z bGF0ZUNvbG9yR2x5cGhSdW4gKGR3cml0ZV9mYWN0b3J5MiwKLQkJCQkJCQkwLCBmb250LT5h c2NlbnQsCisJCQkJCQkJbGVmdF9tYXJnaW4sIGZvbnQtPmFzY2VudCwKIAkJCQkJCQkmZ2x5 cGhfcnVuLAogCQkJCQkJCU5VTEwsCiAJCQkJCQkJTUVBU1VSSU5HX01PREUsCkBAIC05NTks NyArOTYxLDcgQEAgdzMyX2R3cml0ZV9kcmF3IChIREMgaGRjLCBpbnQgeCwgaW50IHksIHVu c2lnbmVkICpnbHlwaHMsIGludCBsZW4sCiAgIC8qIE5vIGNvbG9yLiAgSnVzdCBkcmF3IHRo ZSBHbHlwaFJ1bi4gICovCiAgIGlmIChociA9PSBEV1JJVEVfRV9OT0NPTE9SKQogICAgIGJp dG1hcF9yZW5kZXJfdGFyZ2V0LT5scFZ0YmwtPkRyYXdHbHlwaFJ1biAoYml0bWFwX3JlbmRl cl90YXJnZXQsCi0JCQkJCQkwLCBmb250LT5hc2NlbnQsCisJCQkJCQlsZWZ0X21hcmdpbiwg Zm9udC0+YXNjZW50LAogCQkJCQkJTUVBU1VSSU5HX01PREUsCiAJCQkJCQkmZ2x5cGhfcnVu LAogCQkJCQkJcmVuZGVyaW5nX3BhcmFtcywKQEAgLTEwMjQsNyArMTAyNiw3IEBAIHczMl9k d3JpdGVfZHJhdyAoSERDIGhkYywgaW50IHgsIGludCB5LCB1bnNpZ25lZCAqZ2x5cGhzLCBp bnQgbGVuLAogICAgIH0KIAogICAvKiBGaW5hbGx5LCBjb3B5IHRoZSByZW5kZXJlZCB0ZXh0 IGJhY2sgdG8gdGhlIG9yaWdpbmFsIERDLiAgKi8KLSAgQml0Qmx0IChoZGMsIHgsIHksIGJp dG1hcF93aWR0aCwgYml0bWFwX2hlaWdodCwgdGV4dF9kYywgMCwgMCwgU1JDQ09QWSk7Cisg IEJpdEJsdCAoaGRjLCB4IC0gbGVmdF9tYXJnaW4sIHksIGJpdG1hcF93aWR0aCwgYml0bWFw X2hlaWdodCwgdGV4dF9kYywgMCwgMCwgU1JDQ09QWSk7CiAgIFNBRkVfRlJFRSAoKTsKICAg cmV0dXJuIHRydWU7CiB9Ci0tIAoyLjM1LjEud2luZG93cy4yCgo= --------------LFkLMBThjXP4z7rLaGhIyG84--