From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Thu, 25 Jun 2020 19:45:45 +0300 Message-ID: References: <87r1ulxk48.fsf@mail.linkov.net> <7164426e-8c37-8839-64da-563cfa829b53@yandex.ru> <87mu50j5cu.fsf@mail.linkov.net> <87y2oh8fdv.fsf@mail.linkov.net> <87366ohw5z.fsf@mail.linkov.net> <878sge7jls.fsf@mail.linkov.net> <7e136435-7123-fa42-e4a8-66b82e6595da@yandex.ru> <87pn9pxris.fsf@mail.linkov.net> <83d05ottnw.fsf@gnu.org> <0b42f540-f779-446b-4411-8dae3a50d09d@yandex.ru> <837dvwtrv1.fsf@gnu.org> <835zbgtqps.fsf@gnu.org> <625de669-0715-1467-0bd1-84328b4bee5f@yandex.ru> <83wo3ws4g8.fsf@gnu.org> <83tuyzs2np.fsf@gnu.org> <14381b78-ab1c-91e0-2297-426620b19684@yandex.ru> <83r1u3rtsd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="76391"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: 41821@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 25 18:46:50 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1joV1W-000JlX-5V for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 18:46:50 +0200 Original-Received: from localhost ([::1]:44352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joV1V-00020d-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 12:46:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joV0k-0001HD-J6 for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 12:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joV0k-0000Xm-7G for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 12:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joV0k-0003od-4Y for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 12:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jun 2020 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.159310355814656 (code B ref 41821); Thu, 25 Jun 2020 16:46:02 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 25 Jun 2020 16:45:58 +0000 Original-Received: from localhost ([127.0.0.1]:41007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joV0f-0003oI-Rn for submit@debbugs.gnu.org; Thu, 25 Jun 2020 12:45:58 -0400 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:37899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joV0c-0003o0-QW for 41821@debbugs.gnu.org; Thu, 25 Jun 2020 12:45:56 -0400 Original-Received: by mail-ed1-f47.google.com with SMTP id cy7so4733510edb.5 for <41821@debbugs.gnu.org>; Thu, 25 Jun 2020 09:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XYWCZw8cVrgxTcgt6R2hxL9dcvUzv4cQNmPp7ZFHOwk=; b=s/An10o3fe2aRMLE1dpAP4BoLL1tap07W/2OiKCj1IxQsHfxbXKVlZZ85TmZafXthp KM/fjngD1taeR+QPip9A+ZX2rFAZI6Hem9h1OVZi9yPTTdMK0fGlAq1eLt4SDeI01aoM 7eF1Gm3kSvV/utSBmEQT9ftTO29Im9rwMUENBD7yT8SckB/SFWmEpVVQ3PvPxxeXVdIo qJuuU4SGWDd4nZzdAZp8tCufEoecD2lXYTUs4yn3O+w0P5k9iOyeHD3qfD5u7hSQri0V y74rZEleMYRPAZpYHjIGy9/1T93GKFcLqtvj3KHgu+WRRbta1tAKfW5zy2UIP2gRqmht 2oPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XYWCZw8cVrgxTcgt6R2hxL9dcvUzv4cQNmPp7ZFHOwk=; b=nwRLMy3ghnev1RDYJCD0MpCkWHBwiuYQJ3gW4oug5tJ5SxNitpG6nBs6dwiDff7itS Mx3of51SSgjk6N1m8h7nWFazu3onG/wAaFCFeYZYA01mu3yuJ7cJ4hLgvvu9y0VQ1Jpb 9GnNBr3VBrjNHFytz9O4Ow/zwu+zDhfBcW/o1HPiY58t1hrdE/XMMHBapw2r0jkSagrZ V9/rAEMgM0thEP4CyTPMZN8kTaJn9u/4GGExDRyuRC5mvArI9ubvIGJHVb1mj55YngFI LDGoXHg0zNHkxFpZge76dukgg1c2LWa3Kr5ZuVvNZCkufDXC45Kj5U9Zkz1iHzMBS4Lq Ezug== X-Gm-Message-State: AOAM531mPPHP3beoAEhwcws5ItvRaTsdAygjlHG+qchTHnf+3hGIy0NI ZuFI8tq4xiqCzIcXQDh4jzQ= X-Google-Smtp-Source: ABdhPJwdk0v0nBfxEcdyiYlYZoum2mfwlAYAKJBbtUXwWdkwKzB5D9qYOWNML4lFmpDg8cwch2Kj7Q== X-Received: by 2002:a50:ab52:: with SMTP id t18mr18068994edc.195.1593103548973; Thu, 25 Jun 2020 09:45:48 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id p18sm4823605ejm.55.2020.06.25.09.45.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 09:45:47 -0700 (PDT) In-Reply-To: <83r1u3rtsd.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182372 Archived-At: On 25.06.2020 19:31, Eli Zaretskii wrote: >> And having vc-hooks call project.el functions at runtime would somehow >> force us to preload it? How? > > It's enough that someone makes the function a macro, or does something > else similarly innocent. Nobody will make it a macro, or a defsubst. And I wouldn't say making it a macro would be "innocent". >>> Anyway, if you-two feel strongly about keeping the current solution, >>> i.e. having VC commands use project.el-collected history, I'd >>> appreciate if that function could be moved to vc.el from vc-hooks.el, >>> thanks in advance. >> >> We can't just move it: it accesses information private to project.el. >> The best we could do is a wrapper function. > > Sorry, I don't understand: why can't we move it from vc-hooks.el to > vc.el, and why doing that would need a wrapper? It would be a wrapper for a project.el function. But if it works for you, okay.