* bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
[not found] ` <87eec6wrlm.fsf@posteo.net>
@ 2021-07-10 10:26 ` Dmitry Gutov
2021-07-10 13:17 ` Philip Kaludercic
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-07-10 10:26 UTC (permalink / raw)
To: Philip Kaludercic, 49465; +Cc: Simen Heggestøyl
On 10.07.2021 10:33, Philip Kaludercic wrote:
> I think that adding the shells created by C-x p {e,s} would be good, but
> I am not sure if we want to always kill a shell buffer, that might just
> happen to be in a project directory.
IDK, most of the time I create Eshell by calling the "plain" eshell
command somewhere inside the project. And it still feels like belonging
to that project. So I'd probably like for them to be cleaned out too.
Do you envision a particular scenario where you wouldn't want this to
happen?
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
2021-07-10 10:26 ` bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers? Dmitry Gutov
@ 2021-07-10 13:17 ` Philip Kaludercic
2021-07-17 23:46 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2021-07-10 13:17 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Simen Heggestøyl, 49465
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 10.07.2021 10:33, Philip Kaludercic wrote:
>> I think that adding the shells created by C-x p {e,s} would be good, but
>> I am not sure if we want to always kill a shell buffer, that might just
>> happen to be in a project directory.
>
> IDK, most of the time I create Eshell by calling the "plain" eshell
> command somewhere inside the project. And it still feels like
> belonging to that project. So I'd probably like for them to be cleaned
> out too.
>
> Do you envision a particular scenario where you wouldn't want this to
> happen?
A simple example would be if I start a shell session, later on cd into a
project, start working on it and then want to clean up the project. The
shell that might contain relevant information outside of the project I
just worked on would also be killed.
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
2021-07-10 13:17 ` Philip Kaludercic
@ 2021-07-17 23:46 ` Dmitry Gutov
2021-12-15 13:49 ` Simen Heggestøyl
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-07-17 23:46 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: Simen Heggestøyl, 49465
On 10.07.2021 16:17, Philip Kaludercic wrote:
> A simple example would be if I start a shell session, later on cd into a
> project, start working on it and then want to clean up the project. The
> shell that might contain relevant information outside of the project I
> just worked on would also be killed.
But project-eshell basically creates an eshell buffer in the project
root directory, and that's it. You could also 'cd' inside it to a
different project and work there for a time.
Not sure if we should add some special distinctions or restrictions,
like prohibiting 'cd'-ing outside of the current project.
Anyway, if people think it's a bad idea, we can leave this feature up to
individual users' configurations. But I wonder what others think.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
2021-07-17 23:46 ` Dmitry Gutov
@ 2021-12-15 13:49 ` Simen Heggestøyl
2021-12-17 1:21 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Simen Heggestøyl @ 2021-12-15 13:49 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Philip Kaludercic, 49465
As of commit 38977b6134e7c57788ca92a31362d536d4c7687a to master
(project.el v0.8.2), shell-mode (and other comint-mode-based) buffers
are now included in the kill conditions.
I think that weighs in favor of including Eshell buffers too, for
alignment?
-- Simen
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
2021-12-15 13:49 ` Simen Heggestøyl
@ 2021-12-17 1:21 ` Dmitry Gutov
2021-12-17 7:56 ` Simen Heggestøyl
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-12-17 1:21 UTC (permalink / raw)
To: Simen Heggestøyl; +Cc: Philip Kaludercic, 49465
Hi Simen,
On 15.12.2021 16:49, Simen Heggestøyl wrote:
> As of commit 38977b6134e7c57788ca92a31362d536d4c7687a to master
> (project.el v0.8.2), shell-mode (and other comint-mode-based) buffers
> are now included in the kill conditions.
>
> I think that weighs in favor of including Eshell buffers too, for
> alignment?
Makes sense, added.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
2021-12-17 1:21 ` Dmitry Gutov
@ 2021-12-17 7:56 ` Simen Heggestøyl
0 siblings, 0 replies; 6+ messages in thread
From: Simen Heggestøyl @ 2021-12-17 7:56 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 49465-done, Philip Kaludercic
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 15.12.2021 16:49, Simen Heggestøyl wrote:
>> As of commit 38977b6134e7c57788ca92a31362d536d4c7687a to master
>> (project.el v0.8.2), shell-mode (and other comint-mode-based) buffers
>> are now included in the kill conditions.
>> I think that weighs in favor of including Eshell buffers too, for
>> alignment?
>
> Makes sense, added.
Cool, thanks!
Closing this.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-17 7:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4a4ce7e8-34c0-cc0a-118a-c9753ba68347@yandex.ru>
[not found] ` <87eec6wrlm.fsf@posteo.net>
2021-07-10 10:26 ` bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers? Dmitry Gutov
2021-07-10 13:17 ` Philip Kaludercic
2021-07-17 23:46 ` Dmitry Gutov
2021-12-15 13:49 ` Simen Heggestøyl
2021-12-17 1:21 ` Dmitry Gutov
2021-12-17 7:56 ` Simen Heggestøyl
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).