From: Dmitry Gutov <dgutov@yandex.ru>
To: Robert Pluim <rpluim@gmail.com>
Cc: p.stephani2@gmail.com, 48228@debbugs.gnu.org
Subject: bug#48228: json-serialize should signal error when dll is not found [MS Windows]
Date: Tue, 4 May 2021 19:59:15 +0300 [thread overview]
Message-ID: <fb1c0f0c-2fa5-4470-46c8-93b88019a8e9@yandex.ru> (raw)
In-Reply-To: <87fsz28n5x.fsf@gmail.com>
On 04.05.2021 19:43, Robert Pluim wrote:
> What makes it error-prone? Those existing testing functions (on
> Windows) attempt to load the relevant DLL's using the exact same
> mechanisms as the actual code, so the failure (and success) modes are
> identical.
When somebody write code using json-serialize, and it can't do what it
was asked to do, it should raise an error.
I have code like this in a separate project:
(cond ((fboundp 'json-parse-buffer)
(json-parse-buffer
:array-type 'list
:object-type 'alist
:null-object nil))
(t
(let ((json-array-type 'list))
(json-read))))
It has been there for a couple of years. And only now I find out that it
can fail on MS Windows, because that failure is not reproducible on any
other platform. I can only hope that whatever random Windows users
encountered it saw the message wherever it was printed, and it was not
concealed by subsequent messages from the caller code (reporting some
cryptic errors, I imagine).
That's not to say we must not have a function json-available-p. If it's
helpful, why not add it as well.
next prev parent reply other threads:[~2021-05-04 16:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 15:25 bug#48228: json-serialize should signal error when dll is not found [MS Windows] Dmitry Gutov
2021-05-04 15:46 ` Philipp Stephani
2021-05-04 15:49 ` Dmitry Gutov
2021-05-04 16:08 ` Eli Zaretskii
2021-05-04 16:10 ` Dmitry Gutov
2021-05-04 16:43 ` Robert Pluim
2021-05-04 16:59 ` Dmitry Gutov [this message]
2021-05-04 17:42 ` Eli Zaretskii
2021-05-04 17:47 ` Dmitry Gutov
2021-05-04 18:07 ` Eli Zaretskii
2021-05-05 22:36 ` Dmitry Gutov
2021-05-06 15:26 ` Nikolay Kudryavtsev
2021-05-06 15:45 ` Eli Zaretskii
2021-05-06 16:13 ` Nikolay Kudryavtsev
2021-05-06 16:18 ` Eli Zaretskii
2021-05-06 16:29 ` Nikolay Kudryavtsev
2021-05-06 16:36 ` Eli Zaretskii
2021-05-06 16:42 ` Nikolay Kudryavtsev
2021-05-06 16:46 ` Eli Zaretskii
2021-05-06 17:02 ` Nikolay Kudryavtsev
2021-05-06 17:11 ` Dmitry Gutov
2021-05-06 17:36 ` Nikolay Kudryavtsev
2021-05-06 17:55 ` Eli Zaretskii
2021-05-08 4:48 ` Richard Stallman
2021-05-04 16:44 ` Eli Zaretskii
2021-05-04 17:00 ` Dmitry Gutov
2021-05-04 17:44 ` Eli Zaretskii
2021-07-20 12:50 ` Lars Ingebrigtsen
2021-07-20 12:51 ` Lars Ingebrigtsen
2021-07-20 13:22 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1c0f0c-2fa5-4470-46c8-93b88019a8e9@yandex.ru \
--to=dgutov@yandex.ru \
--cc=48228@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).