From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#74786: [PATCH] Add custom args to test compile step Date: Wed, 01 Jan 2025 23:50:32 +0000 Message-ID: References: <86wmg62pfs.fsf@gnu.org> <87wmg643g4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31029"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , 74786@debbugs.gnu.org, Eli Zaretskii , "J.P." To: "O'Brien, Will" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 00:51:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tT8Um-0007uS-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 00:51:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tT8US-0008OF-3n; Wed, 01 Jan 2025 18:51:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tT8UR-0008O6-1q for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 18:51:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tT8UQ-0002N7-Nk for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 18:51:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=TIuzNNbotaKCX/X+pwZ1+5T1wFJDkgRSl66pnFBMkfM=; b=aL0HnDHtqLIj8J2p5+qsJB9afelgXR119x88GSsvwpgzU/TngAfE1UFRDyXH/eIZvKwk9kNdYMVKw/zk9J0BzoCXhHNLcwyZovDhH12qM5Bl3A0Lfyd1vSoVf3CmZl8oJFbZQqjymK+QDHmiVhX6lggDEBhWvE0ZpASjr8+wvou47sjdr0ySTrmYK0DKC7yZxhNKnm5gJpmAd4X5gntke1U4pnWTW7uznFDgofQpiOlkRzGIQAN9zAGLfrpInIailyRsjiYSwclP9poJ2CLmUkVpQemo+yXCe7TQSYH4SF8E3D6fKBqSWMyOfLHbdYI2FwBpAKEMxDh4SG4rHLt/cQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tT8UQ-0004X1-G0 for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 18:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Jan 2025 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74786-submit@debbugs.gnu.org id=B74786.173577544417394 (code B ref 74786); Wed, 01 Jan 2025 23:51:02 +0000 Original-Received: (at 74786) by debbugs.gnu.org; 1 Jan 2025 23:50:44 +0000 Original-Received: from localhost ([127.0.0.1]:40885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tT8U8-0004WU-Gd for submit@debbugs.gnu.org; Wed, 01 Jan 2025 18:50:44 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:37399) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tT8U5-0004WH-Kw for 74786@debbugs.gnu.org; Wed, 01 Jan 2025 18:50:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1735775435; x=1736034635; bh=TIuzNNbotaKCX/X+pwZ1+5T1wFJDkgRSl66pnFBMkfM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=NCH/HidpfCPOXvj9HmJDKifJfEMbLZuj67W/CirUB3skZxPHgAZmk6P8cU/H3gjQ3 +o3n5dExGefu81whhjj13G/yzL4DJguyrsE+ERLOYA2Gf4ecMbVlhljaImcTiCeyLG ugjgg8PG7V+YNj3Md0rmo2nyGcHLWfOVb3+Tnaj2QzMzE+Ap9t7TwPGEpELorVvwd7 5PNcBfdU5rKBtLZscG/QIiTSB9sjWdD0Gkv6nckfb1ClefqNUGXRJTzyHiQ66Oe/GF BR0twRxyLd8bI9wRZpWmLMUZ+cGQ3BNq6U6YVdlEemzTVyaG0e85ye5Vkfq526rMoT /tM5y+663MWNg== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 8677cf220a954884cf664b110738d10ae4e1ca24 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298074 Archived-At: On Friday, December 20th, 2024 at 11:14, O'Brien, Will wrote: >=20 >=20 > Hi, >=20 > On Thu, Dec 19 2024 at 16:20, "O'Brien, Will" will.08rien@gmail.com wrote= : >=20 > > I believe the attached patch should cover your suggestion, Randy, > > as well as incorporating Robert's and J.P.'s suggestions. Thanks, the patch looks good to me. There is a typo: + "Return the flags for test invoation." ^invocation >=20 >=20 > I think there's a further issue which I believe was pre-existing. >=20 > The package test function looks like this: >=20 > --8<---------------cut here---------------start------------->8--- >=20 > (defun go-ts-mode-test-this-package () > "Run all the unit tests under the current package." > (interactive) > (compile (format "go test -v %s -run %s" > (go-ts-mode--get-build-tags-flag) > default-directory))) > --8<---------------cut here---------------end--------------->8--- >=20 >=20 > The issue that the argument to the `-run` flag is a regex that > should match any tests that will be execute. Passing a directory > has slightly unexpected consequences, and although it seems to > work, for me typically results tests not running. >=20 > I think that we can remove the `-run` flag from this function. > What do others think? Also, should this be a separate bug/patch > (if indeed it is a bug) or I can incorporate this change into the > current change set. >=20 > best > -- > will I believe you are correct, we can get rid of the -run flag. Please incorporate these changes as part of this patch. (Side note, maybe we should actually pass the package to go test instead of relying on default directory but don't worry about that for this patch).