From: Randy Taylor <dev@rjt.dev>
To: Po Lu <luangruo@yahoo.com>
Cc: 54633@debbugs.gnu.org
Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK.
Date: Mon, 04 Apr 2022 14:09:21 +0000 [thread overview]
Message-ID: <fUJXb6jHm9WtViEPJR07HP6NlRU_y9Np8E1IiT3AGwfjq44CFKal-umJNU130rac_4KoRusnDUA5DOOACV7d7N0PcVlFylwg7M_Z1w7QO0Y=@rjt.dev> (raw)
In-Reply-To: <_cZTGI5IOQhThtQm00iO5TXOSJmyqIhe7IUH9aSYeFx0qifXWHb21bLoNwa58ywtk0EShgtJOaBcUy6ExX0_MWu15uk9Azl2xKUoTXi77y8=@rjt.dev>
Anything stopping this from going in?
------- Original Message -------
On Wednesday, March 30th, 2022 at 10:55, Randy Taylor <dev@rjt.dev> wrote:
>
>
>
>
> ------- Original Message -------
>
> On Wednesday, March 30th, 2022 at 09:34, Po Lu luangruo@yahoo.com wrote:
>
> > Eli Zaretskii eliz@gnu.org writes:
> >
> > > Thanks. But your patch touched more than just the PGTK build. For
> > >
> > > w32, for example, I see no reason to make any changes; do you?
> > >
> > > Likewise for NS.
> > >
> > > Po Lu, do you agree that only PGTK needs a fix? If co, can you
> > >
> > > suggest a fix for PGTK only?
> >
> > I didn't yet test this, but it should work correctly. Randy, please
> >
> > test. Thanks.
> >
> > Native image APIs are used on Haiku and NS for GIF image support, so
> >
> > this probably doesn't have to change.
> >
> > diff --git a/configure.ac b/configure.ac
> >
> > index 93c821eda0..99b2ecc669 100644
> >
> > --- a/configure.ac
> >
> > +++ b/configure.ac
> >
> > @@ -4292,7 +4292,8 @@ AC_DEFUN
> >
> > fi
> >
> > elif test "${HAVE_X11}" = "yes" && test "${with_gif}" != "no" \
> >
> > || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \
> >
> > - || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk"; then
> >
> > + || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk" \
> >
> > + && test "${with_gif}" != "no"; then
> >
> > AC_CHECK_HEADER(gif_lib.h,
> >
> > # EGifPutExtensionLast only exists from version libungif-4.1.0b1.
> >
> > # Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtensionLast.
>
>
> Works for me. Makes sense to only apply it to PGTK.
>
> Thanks.
next prev parent reply other threads:[~2022-04-04 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 1:45 bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK Randy Taylor
2022-03-30 5:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 12:13 ` Eli Zaretskii
2022-03-30 12:42 ` Randy Taylor
2022-03-30 13:27 ` Eli Zaretskii
2022-03-30 13:34 ` Randy Taylor
2022-03-30 13:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 13:46 ` Eli Zaretskii
2022-03-30 13:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 14:55 ` Randy Taylor
2022-04-04 14:09 ` Randy Taylor [this message]
2022-04-05 1:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fUJXb6jHm9WtViEPJR07HP6NlRU_y9Np8E1IiT3AGwfjq44CFKal-umJNU130rac_4KoRusnDUA5DOOACV7d7N0PcVlFylwg7M_Z1w7QO0Y=@rjt.dev' \
--to=dev@rjt.dev \
--cc=54633@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).