From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com,
Juri Linkov <juri@linkov.net>
Subject: bug#60210: 30.0.50; tab-bar height not recalculated when face changes
Date: Mon, 26 Dec 2022 00:24:11 +0000 [thread overview]
Message-ID: <f9fdb7b870ccfeea07d5@heytings.org> (raw)
In-Reply-To: <8335934yse.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 141 bytes --]
>
> I doubt the font-related changes are relevant, but bisecting will be
> welcome.
>
Indeed, the culprit is 5db4ec20fe.
Patch attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Improve-handling-of-tab-bar-height.patch --]
[-- Type: text/x-diff; name=Improve-handling-of-tab-bar-height.patch, Size: 1430 bytes --]
From f2081576513e8b6fba71e67f36622cebe915c4c4 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Mon, 26 Dec 2022 00:20:59 +0000
Subject: [PATCH] Improve handling of tab-bar height.
* src/xdisp.c (redisplay_tab_bar): When 'auto-resize-tab-bar' is
not 'grow-only', also consider the case when the tab-bar height
needs to shrink. Fixes bug#60210.
---
src/xdisp.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/xdisp.c b/src/xdisp.c
index ea2d11e8b4e..c9b3b187fe2 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -14271,12 +14271,14 @@ redisplay_tab_bar (struct frame *f)
frame_default_tab_bar_height = new_height;
}
- /* If new_height or new_nrows indicate that we need to enlarge the
- tab-bar window, we can return right away. */
+ /* If new_height or new_nrows indicate that we need to enlarge or
+ shrink the tab-bar window, we can return right away. */
if (new_nrows > f->n_tab_bar_rows
|| (EQ (Vauto_resize_tab_bars, Qgrow_only)
&& !f->minimize_tab_bar_window_p
- && new_height > WINDOW_PIXEL_HEIGHT (w)))
+ && new_height > WINDOW_PIXEL_HEIGHT (w))
+ || (! EQ (Vauto_resize_tab_bars, Qgrow_only)
+ && new_height < WINDOW_PIXEL_HEIGHT (w)))
{
if (FRAME_TERMINAL (f)->change_tab_bar_height_hook)
FRAME_TERMINAL (f)->change_tab_bar_height_hook (f, new_height);
--
2.35.1
next prev parent reply other threads:[~2022-12-26 0:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 23:04 bug#60210: 30.0.50; tab-bar height not recalculated when face changes Gabriel do Nascimento Ribeiro
2022-12-25 8:35 ` Juri Linkov
2022-12-25 9:29 ` Eli Zaretskii
2022-12-26 0:24 ` Gregory Heytings [this message]
2022-12-26 12:23 ` Eli Zaretskii
2022-12-26 13:36 ` Gregory Heytings
2022-12-26 17:29 ` Juri Linkov
2022-12-26 17:40 ` Gregory Heytings
2023-01-01 17:56 ` Gregory Heytings
2023-01-01 18:22 ` Eli Zaretskii
2023-01-01 21:50 ` Gregory Heytings
2023-01-02 3:29 ` Eli Zaretskii
2023-01-02 15:05 ` Eli Zaretskii
2023-01-02 15:28 ` Gregory Heytings
2023-01-02 16:53 ` Eli Zaretskii
2023-01-04 13:53 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9fdb7b870ccfeea07d5@heytings.org \
--to=gregory@heytings.org \
--cc=60210@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gabriel376@hotmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).