From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Wed, 24 Jun 2020 21:44:01 +0300 Message-ID: References: <87r1ulxk48.fsf@mail.linkov.net> <7164426e-8c37-8839-64da-563cfa829b53@yandex.ru> <87mu50j5cu.fsf@mail.linkov.net> <87y2oh8fdv.fsf@mail.linkov.net> <87366ohw5z.fsf@mail.linkov.net> <878sge7jls.fsf@mail.linkov.net> <7e136435-7123-fa42-e4a8-66b82e6595da@yandex.ru> <87pn9pxris.fsf@mail.linkov.net> <83d05ottnw.fsf@gnu.org> <0b42f540-f779-446b-4411-8dae3a50d09d@yandex.ru> <837dvwtrv1.fsf@gnu.org> <835zbgtqps.fsf@gnu.org> <625de669-0715-1467-0bd1-84328b4bee5f@yandex.ru> <83wo3ws4g8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="80175"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: 41821@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 24 20:45:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1joAOU-000Kkg-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jun 2020 20:45:10 +0200 Original-Received: from localhost ([::1]:33132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joAOT-0002Tq-Dz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jun 2020 14:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joAOL-0002TW-WC for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2020 14:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joAOL-00074s-N4 for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2020 14:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joAOL-0002HY-LK for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2020 14:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jun 2020 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.15930242538700 (code B ref 41821); Wed, 24 Jun 2020 18:45:01 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 24 Jun 2020 18:44:13 +0000 Original-Received: from localhost ([127.0.0.1]:39017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joANY-0002GF-7t for submit@debbugs.gnu.org; Wed, 24 Jun 2020 14:44:13 -0400 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:38932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joANV-0002G1-JG for 41821@debbugs.gnu.org; Wed, 24 Jun 2020 14:44:10 -0400 Original-Received: by mail-ed1-f54.google.com with SMTP id g1so2256699edv.6 for <41821@debbugs.gnu.org>; Wed, 24 Jun 2020 11:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AKdszR6psKAJMx4hfidO1Ybb9BwZmAqqG3P/uW3WDhE=; b=WweutcbdSgGSzS+YOvjrMO+ODv3eIFkQT584cclH1Rp/FQ5oGiKG9EdfEUpL3JRGe9 5V0lrp318cbEg5c5Sx8jjoXIKEFQ+qp31pmP+0xez9cGeDZ+kc6c57udhwSxjbDYb7D0 ONwQdK2TNETQoFG4tLJ4Prhrg2fGgR2fzvE79KsGIIEGpOcczQkUdcMazTBH/Y7LgKtH lQ+EWYbG2tHOu37OVGgZKqp6GTSvFdnR1HYH9Uft8wG3eKgwgmGZsZ9GcEOh68C0R8W/ +DrF3mgAjh+iRkaE3ZEMlRFpej+Nw+X5gpQBernO5h8CNFgF0qwCibaSnXP2XknJRYLC CYWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AKdszR6psKAJMx4hfidO1Ybb9BwZmAqqG3P/uW3WDhE=; b=b4LSV2UMWeEzlHidN+lCl92brGr/CG6GwlVmTgjaXViR83ijMHl1kYiWtxoaDd5deT w4ohs2K1GDc28J+FhCqPA1kQi8WnLKltmbdrJOPRvcwJ5YXmsYJ1cgQ2EoVkDemgDE83 YnBRGKZ5nOFCF1RMe50pwcNirnYyi8wxUQKn841DCGW0h1r+ulcDvs8TffruuBAPNPEG tkYLm54BMxFVqqd+33TY+pd8LTy10QtOWcF+ER5DqwTGTaCzXsGTua11wKyd9O81GcdF QX1pvvasxmfahQ9WrbvAAd6Pf9xOk7seoKgpyUQr/b5cPopGK8LBVx+dsJwcSxzO/6Gl xKFg== X-Gm-Message-State: AOAM533ksYp5bf9BhrEgt20vTgZMhd6hARZsW4lZM1amJMyO8LHsv4OW w4juJ9Y5ioW1/gGWdX0mWJI= X-Google-Smtp-Source: ABdhPJxEsYmqzJGiHK5tq0iLfXT/bzdvR5Mw+yDBCwBEinbw+oc+geM/TiD6OIgCPKy4gHGIZMpyfg== X-Received: by 2002:a05:6402:17ce:: with SMTP id s14mr27891997edy.53.1593024243716; Wed, 24 Jun 2020 11:44:03 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id k8sm16710391edn.28.2020.06.24.11.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2020 11:44:03 -0700 (PDT) In-Reply-To: <83wo3ws4g8.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182358 Archived-At: On 24.06.2020 21:29, Eli Zaretskii wrote: >> Cc: 41821@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> Date: Wed, 24 Jun 2020 21:13:07 +0300 >> >> On 24.06.2020 18:42, Eli Zaretskii wrote: >>> So is it possible to have vc-known-roots defined in vc.el instead of >>> in vc-hooks.el? >> >> Okay, but that new function delegates to code in project.el anyway, what >> would be the practical difference? > > It would be somewhat cleaner, I think. That's the whole reason? I mean, I'm not going to protest against an extra wrapper, but that doesn't sound like it would solve any practical problems. "Cleaner" solutions often have those. > Doesn't vc.el already have some calls to project.el? Nope. >> OTOH, if you just said we shouldn't use project.el in vc/*, I could >> understand that. > > That'd be unreasonably harsh, I think. But that would be a limitation I could understand (don't use non-preloaded code from preloaded code, period). > Actually, I have a question: isn't project.el conceptually a > higher-level feature than VC? If so, how come VC wants to call > project.el? VC doesn't serve project.el only. project.el doesn't solely use VC. Apparently Juri wants to use certain data collected and saved by project.el UI, for convenience. The alternative would be to introduce some separate history-keeping feature for the cases when VC code needs to ask the user to point to a VC repository.