From: "Charles A. Roelli" <charles@aurox.ch>
To: Alan Third <alan@idiocy.org>,
Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 25265@debbugs.gnu.org
Subject: bug#25265: make-thread crashes in OS X 10.6
Date: Sun, 18 Jun 2017 15:05:04 +0200 [thread overview]
Message-ID: <f99bc9af-857c-087e-a33e-2a010b54707d@aurox.ch> (raw)
In-Reply-To: <20170616205139.GA27574@breton.holly.idiocy.org>
The tests sometimes all pass with the updated patch, but then I got
this once (the errors you've seen previously, I think):
Selector: t
Passed: 26
Failed: 2 (2 unexpected)
Skipped: 0
Total: 28/28
Started at: 2017-06-18 14:54:43+0200
Finished.
Finished at: 2017-06-18 14:54:47+0200
.F........F.................
F thread-signal-early
Test signaling a thread as soon as it is started by the OS.
(ert-test-failed
((should-not
(thread-alive-p thread))
:form
(thread-alive-p #<thread 0x102da5498>)
:value t))
F threads-condvar-wait
test waiting on conditional variable
(ert-test-failed
((should
(=
(length
(all-threads))
1))
:form
(= 2 1)
:value nil))
from nextstep/Emacs.app/Contents/MacOS/Emacs -Q -l ert -l
test/src/thread-tests.el
I also tried this way of running the tests in batch mode:
cd test && rm -rf src/thread-tests.log && make src/thread-tests.log
but got a segfault:
GEN src/thread-tests.log
/bin/sh: line 1: 87214 Segmentation fault HOME=/nonexistent
EMACSLOADPATH= LC_ALL=C
EMACS_TEST_DIRECTORY=/Volumes/Toblerone/Code/emacs-devel/test
"../src/emacs" -batch --no-site-file --no-site-lisp -L ":." -l ert -l
src/thread-tests.el --eval "(ert-run-tests-batch-and-exit nil)" >
src/thread-tests.log 2>&1
Running 28 tests (2017-06-18 15:00:03+0200)
make: *** [src/thread-tests.log] Error 139
I'm not sure where the problem is happening (or if it's specific to
NS). The file 'src/thread-tests.log' also doesn't give any extra
information (besides 'Running 28 tests (2017-06-18 15:00:03+0200)').
On 16/06/2017 22:51, Alan Third wrote:
> On Fri, Jun 16, 2017 at 04:05:58PM -0400, Noam Postavsky wrote:
>> On Fri, Jun 16, 2017 at 3:45 PM, Alan Third <alan@idiocy.org> wrote:
>>> The first one looks like the thread’s starting too quick?
>> I think it's rather failing to be killed by the `thread-signal' call.
> Ah, yes. I completely misread the test.
>
>>> The second looks like the thread’s not dying quick enough?
>> Same for that one. I don't know much about the thread internals, and
>> even less macOS internals though...
> Well, I’ve discovered that if I keep the mouse moving over the Emacs
> frame while the tests are running then none of them fail, so I think
> it’s something to do with ns_select jamming everything up for the
> duration of its timeout.
>
> I could probably get round that by getting the thread to fire off an
> NS app defined event when it dies. That would break ns_select out of
> its event loop, presumably letting the dying thread actually die...
>
> Amazingly that seems to have worked! Updated patch attached.
next prev parent reply other threads:[~2017-06-18 13:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 11:06 bug#25265: make-thread crashes in OS X 10.6 Charles A. Roelli
2016-12-24 17:51 ` Eli Zaretskii
2016-12-25 15:52 ` Eli Zaretskii
2016-12-26 13:09 ` Alan Third
2016-12-26 15:52 ` Eli Zaretskii
2016-12-26 20:56 ` Alan Third
2016-12-27 7:30 ` Eli Zaretskii
2016-12-27 10:44 ` Alan Third
2016-12-27 11:13 ` Eli Zaretskii
2016-12-28 19:36 ` Alan Third
2016-12-29 17:12 ` Eli Zaretskii
2016-12-30 18:45 ` Alan Third
2016-12-30 21:08 ` Eli Zaretskii
2016-12-30 22:05 ` Alan Third
2016-12-31 9:20 ` Eli Zaretskii
2016-12-31 16:09 ` bug#25265: [PATCH] Rework NS event handling (bug#25265) Alan Third
2016-12-31 16:25 ` Eli Zaretskii
2016-12-31 16:46 ` Alan Third
2017-01-01 15:03 ` Alan Third
2017-01-01 15:42 ` Eli Zaretskii
2017-03-06 20:02 ` bug#25265: make-thread crashes in OS X 10.6 Alan Third
2017-03-08 20:17 ` Charles A. Roelli
2017-03-14 14:49 ` Alan Third
2017-05-02 20:49 ` Alan Third
2017-06-12 19:32 ` Charles A. Roelli
2017-06-13 20:46 ` Alan Third
2017-06-15 18:57 ` Charles A. Roelli
2017-06-15 19:04 ` Alan Third
2017-06-15 19:14 ` Noam Postavsky
2017-06-16 19:45 ` Alan Third
2017-06-16 20:05 ` Noam Postavsky
2017-06-16 20:51 ` Alan Third
2017-06-18 13:05 ` Charles A. Roelli [this message]
2017-06-18 14:01 ` Alan Third
2017-06-19 18:34 ` Charles A. Roelli
2017-07-01 12:04 ` Alan Third
2017-07-04 6:59 ` Charles A. Roelli
2017-07-04 12:04 ` npostavs
[not found] ` <20170705193642.GA18888@breton.holly.idiocy.org>
2017-07-06 9:25 ` Charles A. Roelli
2017-07-06 17:10 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99bc9af-857c-087e-a33e-2a010b54707d@aurox.ch \
--to=charles@aurox.ch \
--cc=25265@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).