From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37189: 25.4.1: vc-hg-ignore implementation is missing Date: Sat, 22 Feb 2020 21:30:55 +0200 Message-ID: References: <1ba53ae2-42a4-3ab3-d4f2-2ceae565d198@gmx.de> <6145d6f6-37a8-7166-731b-57669086b145@gmx.de> <838slmk90j.fsf@gnu.org> <83h806gp2w.fsf@gnu.org> <8336bmg1o9.fsf@gnu.org> <2354821b-5c1e-f9e3-3a64-4ff978ded33b@gmx.de> <83sgjkdev5.fsf@gnu.org> <3fb73dbc-bf31-233b-4afc-2147c4ffd5b7@gmx.de> <5622487d-a21f-49cf-5420-21f87415af4f@gmx.de> <83wo8ubfbo.fsf@gnu.org> <83zhdpqbas.fsf@gnu.org> <2c8419ae-723d-c7ae-a60e-59d1b1cbc2c1@gmx.de> <83o8u3r6wg.fsf@gnu.org> <6f3ba261-e1f9-cf19-cc22-ec8c24cf3298@gmx.de> <83blq2qzqp.fsf@gnu.org> <83ftfdplo8.fsf@gnu.org> <9929b44f-37da-23c8-16cc-c6ca89602149@yandex.ru> <2f84ddff-3275-6eb1-01ae-ff1d28b6e8da@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="67257"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37189@debbugs.gnu.org To: Wolfgang Scherer , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 22 20:32:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5aVZ-000HNE-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Feb 2020 20:32:13 +0100 Original-Received: from localhost ([::1]:45276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5aVY-0001Pz-D3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Feb 2020 14:32:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52745) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5aVP-0001PT-Qs for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 14:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5aVO-0005tX-Lx for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 14:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44032) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5aVO-0005tT-Ii for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 14:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5aVO-0006uY-FK for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Feb 2020 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37189 X-GNU-PR-Package: emacs Original-Received: via spool by 37189-submit@debbugs.gnu.org id=B37189.158239986526495 (code B ref 37189); Sat, 22 Feb 2020 19:32:02 +0000 Original-Received: (at 37189) by debbugs.gnu.org; 22 Feb 2020 19:31:05 +0000 Original-Received: from localhost ([127.0.0.1]:50005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5aUT-0006tH-D3 for submit@debbugs.gnu.org; Sat, 22 Feb 2020 14:31:05 -0500 Original-Received: from mail-wr1-f67.google.com ([209.85.221.67]:34588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5aUR-0006se-Gc for 37189@debbugs.gnu.org; Sat, 22 Feb 2020 14:31:03 -0500 Original-Received: by mail-wr1-f67.google.com with SMTP id n10so5795577wrm.1 for <37189@debbugs.gnu.org>; Sat, 22 Feb 2020 11:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=REqG+u4iiHj2zOQZlNNIXxIwJ3UJQwnjOWprbLPQCu8=; b=sfJXqelED1tQd3EKRg4e0xbA0NlbL4uuB0KMsxGFv/s3hBchpRAK9HGHmg4MPeh77W 0WpC9r7oX49XMKoyIhpXblUj3cD/fRst2vf3mranHqknErJQgUbtIrJ6YOzriqQfDY/+ AAJ08Zh8fzoAlEl6MbZbeToGDrcbUK4d1qbsmWK7FRyNpsFj9VVVFXWUYyl+G7Y2OzwJ Q5hC6JjZzWFHLiyQjDKydf+BX6v9dPm9AgRm7lcxrw8SuN2BmLGH0CHgYWmXzf/mXECc 0cwF/riBR+j4OgxIWUCETUjB994QXHQ4j1nK37EziK2GYgzCJjcWk5LEMhMR1HMMtU98 BMwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=REqG+u4iiHj2zOQZlNNIXxIwJ3UJQwnjOWprbLPQCu8=; b=uUfgfLDGE0fLyB+HH4Pb/PvkVNGJhCoVD2o3a4RiTxRFFJE1vRqPKtW/ik7xvDpy8G YY98gCmQzdLoMhNxBsZ6XHQgsmNk49WPBbv63XKvsK5vNszZn8YeFL8srKsUJWePbIZt 59SUMb6eV1fcDqweFVejhTEG3z0x0nngbz2IxDHAqXSYilfCIoaAjPQqpVu3apMW9xSA Oba171Af40EO+AXgVXcgNUBPCqqqWCVT6b6MXtyXJdb1QGSQNBE7QzwicQJ+Srv0jw7Y js1JZzI+S0xI631xk+A9iv/Asf4vKkdFWIzqiQ/5aRH4BnPJhpZDro9yZsGyVFx5tW0D eSwA== X-Gm-Message-State: APjAAAUvs5YS2/vnL3FXjSKXODzfSjxFjpaa4CqiXrTAqVoSZ45AkxsQ czxewJraIrDF2zrqmeyvFXtL8Oeb X-Google-Smtp-Source: APXvYqzTvYClM7aHyi0H91bQ309mjcoqhRmFTgsnTTt/cRAyNbFTrsgiyxhQSsZVPjWIibDCy/HcLQ== X-Received: by 2002:adf:e550:: with SMTP id z16mr57496739wrm.5.1582399857384; Sat, 22 Feb 2020 11:30:57 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id s15sm9849910wrp.4.2020.02.22.11.30.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Feb 2020 11:30:56 -0800 (PST) In-Reply-To: <2f84ddff-3275-6eb1-01ae-ff1d28b6e8da@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176403 Archived-At: On 22.02.2020 0:22, Wolfgang Scherer wrote: > Both use cases are important for casual users of a VC. Before this > research, I did not know anything about SVN, SRC, Bzr, Mtn. Ignore file > support in 'vc' as a distilled experience cache does come in handy, > even for experienced users. Especially, if escaping/anchoring is > implemented. Escaping/anchoring can be added in the next step of the "series of ad-hoc patches". > I think that is the best way to proceed. The correct implementation is > definitely non-trivial and should not be made in a series of adhoc > patches. Let's try to discuss this one first anyway. > RCS, SCCS do not have ignore files, so they should error out. SRC has > ignore files similar to CVS and SVN. They will fail anyway because they implement neither 'find-ignore-file' nor the 'ignore' backend actions. > Do not forget that CVS and SVN > have functions vc-cvs-ignore and vc-svn-ignore, which are called > *instead* of vc-default-ignore. I.e. The changes to vc-default-ignore > do not affect those VCs. For the invocation of find-ignore-file in > vc-ignore, see below. I think the patch is compatible with those. At least with the SVN one (vc-cvs-ignore might need a little work). Have you tried this patch with SVN? Is there a particular scenario where it fails? >> Roughly and handwavy, we can take this case to mean "use default-directory". > Unfortunately not. If the file or pattern to be ignored is in a > subdirectory of default-directory, the DIRECTORY argument must reflect > this for CVS, SVN, SRC. vc-svn-ignore looks like it can handle either calling convention. > I apologize for introducing ewoc into vc-dir-mode. Meanwhile I have > discovered vc-deduce-fileset, which does all the hard work for > preparing a fileset in vc-dir-mode, dired-mode and other > modes. vc-deduce-fileset delivers a backend and absolute file names, > not relative file names. Please submit a patch fixing that whenever you have the time. > I think introducing relative file names in > function APIs is the wrong way to go. However, as a preliminary > solution, it does suffice. I think it's just fine if the function is supposed to receive an *ignore pattern*, and not a simple file name.