From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#15582: notes on js-mode indentation bug Date: Sat, 14 Jan 2017 06:51:25 +0300 Message-ID: References: <20131010140648.2d3d1c4a@jcubic> <87fukr1p6o.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1484365943 5884 195.159.176.226 (14 Jan 2017 03:52:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2017 03:52:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Thunderbird/51.0 Cc: Daniel Colascione To: Tom Tromey , 15582@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 14 04:52:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSFNx-0000LY-QC for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2017 04:52:09 +0100 Original-Received: from localhost ([::1]:46327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSFO2-00021N-3y for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2017 22:52:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSFNv-0001wW-NO for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2017 22:52:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSFNq-0006un-QT for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2017 22:52:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cSFNq-0006uj-Mp for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2017 22:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cSFNq-00052X-DX for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2017 22:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2017 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15582-submit@debbugs.gnu.org id=B15582.148436589519339 (code B ref 15582); Sat, 14 Jan 2017 03:52:02 +0000 Original-Received: (at 15582) by debbugs.gnu.org; 14 Jan 2017 03:51:35 +0000 Original-Received: from localhost ([127.0.0.1]:53241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSFNO-00051r-Oj for submit@debbugs.gnu.org; Fri, 13 Jan 2017 22:51:34 -0500 Original-Received: from mail-lf0-f67.google.com ([209.85.215.67]:35278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSFNN-00051f-1b for 15582@debbugs.gnu.org; Fri, 13 Jan 2017 22:51:33 -0500 Original-Received: by mail-lf0-f67.google.com with SMTP id v186so7521046lfa.2 for <15582@debbugs.gnu.org>; Fri, 13 Jan 2017 19:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mZd+OmoYW0U4P3sIWDqABDuOCjY0TtGuqyCODbA6RCA=; b=gL+I3il/cH8bPlsSgzITaMjVK8ui79GaAEeobmt8KkhXkb0PR8RPTet+ULqpaMwVoF I73oK8K+v2oERuOQ//TXvmFhhaFTlbyBB9oZNRjrDKYBgUgkKvUkwJpv60gOtXjP8fv1 yL5InwmJli21nC4dMHilB7qZPKtSl15Ic5YBdytQGSrS1HFgBelb74fu8jMCyUSvMG49 7M4MHpMU5+N2RUy/kKINZedm0VslduQw9y2f0YaqyuENMVWTfUTZQeRiMX1o5VMLtbKx HX81xANfi+DHm7mRtrFlxNHL5DvmgZGyMawbULQ8lRj71bn9AFKDvwpGtDWKlxpNVU2q 7wUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mZd+OmoYW0U4P3sIWDqABDuOCjY0TtGuqyCODbA6RCA=; b=tAI+bShz6Y49dXm0A+rm9J7LXcHfl9E519q3GVqeAIPIPL7qamElaQ7haQ92k6l7lr TjI9h/imyZx8FAJdIEG/+YrhqAImvr3biB7axfQFQzGgQGPZbQI0EjHzmhaVJG2ddk5r WAn+noqnPl1oBNGAVcIapSEAtaLEPMPdT8twHp4cDoUVsLGV2dtgJrQhIXZu3CRSaBG/ SGvL3izPEvhVoUqp2p/72ndhBe4QScb9a8BrM4bAenZu6SuisiqsExxGHVuu+UKKDnCE EzIRICnIBJZW7RoxTHY/NYwtCVksnGWSTYvgpR2z5wGA9rvSQNrEjBhYOuvXU6CESzNN efSw== X-Gm-Message-State: AIkVDXKkoQuZkC5KT0iSp4h25nxFhApjeMA3Pr3jE9UxG4tSr8Ce5BZWdPpANzH7z4XCoQ== X-Received: by 10.25.44.66 with SMTP id s63mr8879446lfs.159.1484365887111; Fri, 13 Jan 2017 19:51:27 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id g95sm4633329lfi.9.2017.01.13.19.51.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jan 2017 19:51:26 -0800 (PST) In-Reply-To: <87fukr1p6o.fsf@tromey.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128101 Archived-At: On 10.01.2017 08:03, Tom Tromey wrote: > It would be helpful to know when the continued-expr-p branch really is > supposed to trigger. Or, if there is an informal corpus of indentation > tests, it would be nice to put them all into js-tests.el. It triggers, for instance, in this example: b += c But you have probably found it already. > Tom > > diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el > index 1484b79..0551f2a 100644 > --- a/lisp/progmodes/js.el > +++ b/lisp/progmodes/js.el > @@ -1771,6 +1771,24 @@ js--looking-at-operator-p > ;; return NaN anyway. Shouldn't be a problem. > (memq (char-before) '(?, ?} ?{)))))))) > > +(defun js--find-newline-backward () > + "Move backward to the nearest newline that is not in a block comment." You might want to phrase it like "Move ... ignoring comments.", meaning treating the openers of non-block comments as newlines, and the contents of block comments as entirely invisible. BTW, here are a couple of examples that the new fix doesn't handle: b += /* found */ c b += /* */ c (I think they suggest that the block comment-related behavior of the new function might be tweaked a little). Thanks.