From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Mon, 04 Jun 2018 22:16:03 +1200 Message-ID: References: <83fu2jej5t.fsf@gnu.org> <834liphz6n.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1528107306 12087 195.159.176.226 (4 Jun 2018 10:15:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Jun 2018 10:15:06 +0000 (UTC) User-Agent: Orcon Webmail Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm, bug-gnu-emacs To: Michael Mauger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 04 12:15:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPmVx-00030L-Iz for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2018 12:15:01 +0200 Original-Received: from localhost ([::1]:38706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPmY4-0004L7-GN for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2018 06:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPmXy-0004L0-Eo for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 06:17:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPmXu-00031a-E9 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 06:17:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPmXu-00031J-AW for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 06:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPmXt-0007hQ-UD for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 06:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2018 10:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.152810736929518 (code B ref 31446); Mon, 04 Jun 2018 10:17:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 4 Jun 2018 10:16:09 +0000 Original-Received: from localhost ([127.0.0.1]:60906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPmX3-0007g2-H9 for submit@debbugs.gnu.org; Mon, 04 Jun 2018 06:16:09 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:36433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPmX1-0007fs-Bo for 31446@debbugs.gnu.org; Mon, 04 Jun 2018 06:16:07 -0400 Original-Received: from [10.253.37.70] (port=55171 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fPmWx-00052Y-Av; Mon, 04 Jun 2018 22:16:03 +1200 Original-Received: from [150.107.175.190] via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 04 Jun 2018 22:16:03 +1200 In-Reply-To: X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146945 Archived-At: On 2018-06-03 11:47, Michael Mauger wrote: > I have made a commit that fixes the buffer name handling. This code > was intended for 26.1 but obviously missed that. Please review it > and let me know what you find. Buffer naming behaviour seems good to me at first look. Running sql-postgres (with no prefix argument) when there is an existing SQLi buffer now displays the buffer but does not select the window, which seems like a bug? -Phil > Outstanding work: > * There is a bug around locating sql-interactive buffers from a sql > buffer; I know how to fix it, just need to further test the code. > * Rewrite the DOCSTRINGs to reflect the improved logic > * Add code tests to limit regressions like this in the future > * Add a Info file documenting sql-mode and the intended behavior.