unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Jonathan Underwood <jonathan.underwood@gmail.com>
Cc: 5313@debbugs.gnu.org
Subject: bug#5313: editing files in hexl-mode corrupts file
Date: Thu, 14 Jan 2010 01:50:34 +0100	[thread overview]
Message-ID: <f7ccd24b1001131650q55e3098at85c9908c8f86d53f@mail.gmail.com> (raw)
In-Reply-To: <645d17211001040535n2ad649b8l7de0e48a0873b7f8@mail.gmail.com>

On Mon, Jan 4, 2010 at 14:35, Jonathan Underwood
<jonathan.underwood@gmail.com> wrote:

> A bug report was filed downstream about hexl-mode corrupting a file
> during editing:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=547566

Could you please try the following patch?

    Juanma


=== modified file 'lisp/hexl.el'
--- lisp/hexl.el	2010-01-13 08:35:10 +0000
+++ lisp/hexl.el	2010-01-14 00:38:04 +0000
@@ -779,7 +779,7 @@

 (defun hexl-printable-character (ch)
   "Return a displayable string for character CH."
-  (format "%c" (if hexl-iso
+  (format "%c" (if (not (equal hexl-iso ""))
 		   (if (or (< ch 32) (and (>= ch 127) (< ch 160)))
 		       46
 		     ch)






  reply	other threads:[~2010-01-14  0:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f7ccd24b1001140639n381d61a6s4fa301ef2cdc05f8@mail.gmail.com>
2010-01-04 13:35 ` bug#5313: editing files in hexl-mode corrupts file Jonathan Underwood
2010-01-14  0:50   ` Juanma Barranquero [this message]
2010-01-14 13:36     ` Jonathan Underwood
2010-01-14 14:40   ` bug#5313: marked as done (editing files in hexl-mode corrupts file) Emacs bug Tracking System
     [not found]   ` <handler.5313.D5313.12634799922391.notifdone@debbugs.gnu.org>
2010-01-14 14:51     ` bug#5313: closed by Juanma Barranquero <lekktu@gmail.com> (Re: bug#5313: editing " Jonathan Underwood
2010-01-14 16:00       ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b1001131650q55e3098at85c9908c8f86d53f@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=5313@debbugs.gnu.org \
    --cc=jonathan.underwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).