From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#3224: 23.0.92; vc-dir vs uniquify: wrong directory used Date: Fri, 8 Jan 2010 00:05:51 +0100 Message-ID: References: <84my9rfuhg.fsf@linux-b2a3.site> <200908041230.n74CUQUd025123@godzilla.ics.uci.edu> Reply-To: Juanma Barranquero , 3224@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1262906355 4483 80.91.229.12 (7 Jan 2010 23:19:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jan 2010 23:19:15 +0000 (UTC) Cc: 3224@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 08 00:19:07 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NT1d9-0000Dx-Rl for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jan 2010 00:19:04 +0100 Original-Received: from localhost ([127.0.0.1]:37997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NT1dA-0005oo-Dq for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jan 2010 18:19:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NT1d6-0005nG-2W for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2010 18:19:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NT1d1-0005g0-8f for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2010 18:18:59 -0500 Original-Received: from [199.232.76.173] (port=57162 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NT1d0-0005fs-Uq for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2010 18:18:54 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39116) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NT1d0-0003n9-ME for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2010 18:18:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NT1RW-0003Tj-Ai; Thu, 07 Jan 2010 18:07:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Juanma Barranquero , 3224@debbugs.gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jan 2010 23:07:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 3224 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3224-submit@debbugs.gnu.org id=B3224.126290557913362 (code B ref 3224); Thu, 07 Jan 2010 23:07:02 +0000 Original-Received: (at 3224) by debbugs.gnu.org; 7 Jan 2010 23:06:19 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NT1Qp-0003TT-DW for submit@debbugs.gnu.org; Thu, 07 Jan 2010 18:06:19 -0500 Original-Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NT1Qn-0003TO-38 for 3224@debbugs.gnu.org; Thu, 07 Jan 2010 18:06:17 -0500 Original-Received: by bwz8 with SMTP id 8so12205533bwz.39 for <3224@debbugs.gnu.org>; Thu, 07 Jan 2010 15:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=MJNwzhAf717f2isab9dbnJEELkNvg5QrZfxRE3bB5HE=; b=kSPQvl1uDmR1YebAqcjYlsu9Q44jsbK5aaYCy/Nu4/VRbYJHxHnBdKgMsQK30OnUkU 5XiTol4CYCF1i5tKY38+FDK7YtjHzznl1qGHwIgxIpJ3Vr3NDMIm8T+ugETsQ60NQbT+ YBoIYaNSxRj1+514zQIAPDdEr+7BtCyEnwRdo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=dLzLn2A3J9xhZ6dqA25RXQhh0bSij0mE6rhmLoVm0Kw1rurz0XJdcbsMoFvAdjaESU aeqse76epcxHNariPpFxLsQRfe8XsohkXMUF1rmigkauQzRybdenAm6cmicUcoLpTDbD gwJijKzD6g/OS0PXenWFEnNZ3+R8U1nU3X2JA= Original-Received: by 10.204.18.18 with SMTP id u18mr7355421bka.107.1262905571223; Thu, 07 Jan 2010 15:06:11 -0800 (PST) In-Reply-To: X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.6 (--) Resent-Date: Thu, 07 Jan 2010 18:07:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34052 Archived-At: On Thu, Jan 7, 2010 at 20:53, Stefan Monnier wrote: > Feel free to rename it to uniquify-buffer-dir-name and adjust the docstring. I'm not sure how to describe what it does. It returns the name of the parent directory of the buffer; something like that. BTW, in that function, this bit (if (memq major-mode uniquify-list-buffers-directory-modes) list-buffers-directory)))) and the whole `uniquify-list-buffers-directory-modes' seem a bit redundant; adding a mode to the variable won't work unless the mode function defines `list-buffers-directory', and even so, if the buffer has a `buffer-file-name', `list-buffers-directory' won't be used. So it would be easier to remove the variable and do the check so: (let ((filename (or buffer-file-name - (if (memq major-mode uniquify-list-buffers-directory-modes) - list-buffers-directory)))) + (bound-and-true-p list-buffers-directory)))) (when filename (directory-file-name It is even more general, because any mode for buffers that do not have a buffer-file-name but do define list-buffers-directory will automatically work with uniquify. Juanma