From: Juanma Barranquero <lekktu@gmail.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 5294@debbugs.gnu.org
Subject: bug#5294: 23.1; unload-feature disable minor-mode
Date: Wed, 6 Jan 2010 02:09:10 +0100 [thread overview]
Message-ID: <f7ccd24b1001051709h5a9f6d53vf2a86e59ad4806f3@mail.gmail.com> (raw)
In-Reply-To: <87zl4srqr3.fsf@blah.blah>
On Wed, Jan 6, 2010 at 02:01, Kevin Ryde <user42@zip.com.au> wrote:
> Principally that define-minor-mode knows what things it did and
> therefore should be undone, or why they might not be undone at the
> present time.
But that is defined in the same file as the unload-function...
> I think it would be rather repetitive to be obliged to
> write a FOO-unload-function whenever making a minor mode.
You want to write the same code, but put it in define-minor-mode. I
don't think define-minor-mode should worry itself with unloading.
> Which, err, presumes that there may be standardized things that should
> be considered and/or undone for unloading a mode. I see you say there's
> normally not -- where I say there could be a disable or a caution to
> avoid likely breakage, removal from the minor modes menu, etc.
I do not say that there are not, I say that they are not easy to
generalize. Some are. For example, removing a minor-mode for the
minor-modes menu seems a good idea, and should be done by
unload-feature if it is not done already, because calling a
nonexistent function is an error.
Juanma
next prev parent reply other threads:[~2010-01-06 1:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 21:09 bug#5294: 23.1; unload-feature disable minor-mode Kevin Ryde
2010-01-02 23:22 ` Juanma Barranquero
2010-01-02 23:58 ` Kevin Ryde
2010-01-03 0:24 ` Juanma Barranquero
2010-01-03 1:05 ` Kevin Ryde
2010-01-03 1:41 ` Juanma Barranquero
2010-01-03 23:04 ` Kevin Ryde
2010-01-03 23:12 ` Juanma Barranquero
2010-01-05 23:31 ` Kevin Ryde
2010-01-06 0:23 ` Juanma Barranquero
2010-01-06 1:01 ` Kevin Ryde
2010-01-06 1:09 ` Juanma Barranquero [this message]
2022-02-13 10:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b1001051709h5a9f6d53vf2a86e59ad4806f3@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=5294@debbugs.gnu.org \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).