From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#5293: 23.1; unload-feature on buffer-local hooks Date: Sun, 3 Jan 2010 00:14:31 +0100 Message-ID: References: <87hbr4p67t.fsf@blah.blah> Reply-To: Juanma Barranquero , 5293@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1262474378 8372 80.91.229.12 (2 Jan 2010 23:19:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jan 2010 23:19:38 +0000 (UTC) Cc: 5293@debbugs.gnu.org To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 03 00:19:31 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NRDFq-0000WH-T9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jan 2010 00:19:31 +0100 Original-Received: from localhost ([127.0.0.1]:56530 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRDFr-00063n-AQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jan 2010 18:19:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRDFl-00061k-Gv for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2010 18:19:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRDFb-0005vz-Lz for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2010 18:19:25 -0500 Original-Received: from [199.232.76.173] (port=59634 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRDFb-0005vt-Hh for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2010 18:19:15 -0500 Original-Received: from [140.186.70.43] (port=55011 helo=debbugs.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRDFb-00024R-5Y for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2010 18:19:15 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NRDBW-0000J8-A3; Sat, 02 Jan 2010 18:15:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Juanma Barranquero , 5293@debbugs.gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jan 2010 23:15:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5293 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5293-submit@debbugs.gnu.org id=B5293.12624740971161 (code B ref 5293); Sat, 02 Jan 2010 23:15:02 +0000 Original-Received: (at 5293) by debbugs.gnu.org; 2 Jan 2010 23:14:57 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRDBR-0000Ig-7q for submit@debbugs.gnu.org; Sat, 02 Jan 2010 18:14:57 -0500 Original-Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRDBP-0000IY-SR for 5293@debbugs.gnu.org; Sat, 02 Jan 2010 18:14:56 -0500 Original-Received: by bwz8 with SMTP id 8so9024201bwz.39 for <5293@debbugs.gnu.org>; Sat, 02 Jan 2010 15:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=NR/ZNTd+BSie+/9MvQp8Gq4OE64LTY3uiNJE+y+s56M=; b=xV16rP6PYdEuYUN+MP61zUo9kobFFDvGFv0fLknR9wc6ocR76JNhC8aP7FEHzi5zDP XatjSNeITiRBtUqwc6Q7eh7Xc4szSn7HoLhNQLzvdt0KV+HOvA3a1cg7xmP0FJnEglWp oRRDyxSzh3hvWP7NT/p1nfvYyfdj5jOLRqvYM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=naLPMCES3zERIiYtaNfUAE/01SLVrJrx8A3v8USE1jHe8Vb1YMmQCCM7zyYasgu8X3 wDO/82ltx9Rt0Peo0BL/LINhif98lziMYazFBBa2LwQ5nexK6FcvzzKpwll+H/JKXBXi ao3t2LZzXV1MXfULUXZ+oOXgvg650Ymp7ikrQ= Original-Received: by 10.204.8.151 with SMTP id h23mr2473823bkh.194.1262474091108; Sat, 02 Jan 2010 15:14:51 -0800 (PST) In-Reply-To: <87hbr4p67t.fsf@blah.blah> X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.8 (--) Resent-Date: Sat, 02 Jan 2010 18:15:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33880 Archived-At: On Sat, Jan 2, 2010 at 22:06, Kevin Ryde wrote: > When `unload-feature' looks in hooks for functions that it's going to > unload, it doesn't seem to look in buffer-local values, other than for > the current buffer. [...] > I suppose looking in all buffers is more work for unload-feature, but > would be a good protection against bad things happening later. Yes, unload-feature should look at buffer-local values, too. For the moment being, a package like foo should define a function (foo in the function name matches the feature name you're unloading): (defun foo-unload-function () ;; do whatever is necessary; in foo's case: (with-current-buffer (get-buffer "foo-bufer") (remove-hook 'after-change-functions 'foo-message t)) ;; continue standard unloading nil) that will be automatically called upon unloading foo.el; in most cases, it should return nil to allow unload-feature to continue the normal unloading process. Juanma