bug#4792: 23.1; dired-insert-directory: doesn't indent header lines if no files

bug#4792: 23.1; dired-insert-directory: doesn't indent header lines if no files

[Chong Yidong]

> emacs -q
> C-x d some-directory-that-does-not-exist

> The listing looks like this:
>   c:/Emacs-23.1/lisp:
>   wildcard some-directory-that-does-not-exist
> (No match)
> total used in directory 0 available 26402560

I can't reproduce this.  C-x d some-directory-that-does-not-exist gives
an error

  "Reading directory: no such file or directory, some-directory"

This is both with and without ls-lisp loaded.

bug#4792: 23.1; dired-insert-directory: doesn't indent header lines if no files

[Drew Adams]

> > emacs -q
> > C-x d some-directory-that-does-not-exist
> 
> > The listing looks like this:
> >   c:/Emacs-23.1/lisp:
> >   wildcard some-directory-that-does-not-exist
> > (No match)
> > total used in directory 0 available 26402560
> 
> I can't reproduce this.  C-x d 
> some-directory-that-does-not-exist gives an error
> 
>   "Reading directory: no such file or directory, some-directory"
> 
> This is both with and without ls-lisp loaded.

Hey, what can I say? Did you actually try it on MS Windows?
This is 100% reproducible for me, using emacs -Q in 23.1.

And I don't think it _should_ be raising an error. You should be able to use any
wildcard expression (and that's what this is, in fact), and a Dired buffer
should be opened showing you the matches - even if there are none.

IOW, using `some-directory-that-does-not-exist' is no different from using
`*.jjjjjjjjj'. If there are no matches for the pattern, then you should get a
listing like what I wrote above - except the header info should be indented
properly.

bug#4792: 23.1; dired-insert-directory: doesn't indent header lines if no files

[Juanma Barranquero]

On Sat, Oct 24, 2009 at 20:51, Chong Yidong <cyd@stupidchicken.com> wrote:

> I can't reproduce this.  C-x d some-directory-that-does-not-exist gives
> an error
>
>  "Reading directory: no such file or directory, some-directory"

Perhaps it is a Windows thing. I can reproduce it.

C:\> emacs -Q

C-x d doesnotexist <RET>

  c:/:
  wildcard doesnotexist
(No match)
total used in directory 0 available 43706472


    Juanma

bug#4792: 23.1; dired-insert-directory: doesn't indent header lines if no files

[Drew Adams]

emacs -q
C-x d some-directory-that-does-not-exist
 
The listing looks like this:
 
  c:/Emacs-23.1/lisp:
  wildcard some-directory-that-does-not-exist
(No match)
total used in directory 0 available 26402560
 
The last two lines should be indented, but they are not.
 
They need to be indented, in particular, so that any (custom)
font-lock highlighting that might be done can act appropriately. They
should also be indented for consistency with the display of a
non-empty listing.
 
This regression was introduced in Emacs 22 - the lines are indented
correctly in Emacs 20 and 21.
 
The cause is this change in `dired-insert-directory':
(indent-rigidly opoint (point) 2)
 
Originally, that was (indent-rigidly (point-min) (point-max) 2),
though the indentation was done elsewhere at that time.
 
The problem is that when there are no files in the listing, point does
not get moved, so opoint is 1, and so is (point) - so nothing is
indented.
 
Either `point-min' and `point-max' should be used, as before (unless
that causes some other problem), or the code should check whether any
file lines were actually inserted and DTRT. Or perhaps the
`save-excursion' could be removed around the code that inserts this
header info, so that (point) would be at (point-max). (opoint = 1 is
not the problem.)
 
Note: I'm on Windows, so the code uses ls-lisp.el. E.g. it uses the
version of `insert-directory' provided by ls-lisp.el. Dunno if that
makes a difference.
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'