From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#4534: assertion failure at window.c:grow_mini_window Date: Wed, 23 Sep 2009 15:41:24 +0200 Message-ID: References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> Reply-To: Juanma Barranquero , 4534@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1253715086 4875 80.91.229.12 (23 Sep 2009 14:11:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Sep 2009 14:11:26 +0000 (UTC) Cc: 4534@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 23 16:11:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MqSYk-00010g-Av for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Sep 2009 16:11:07 +0200 Original-Received: from localhost ([127.0.0.1]:43351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqSYj-0006CM-PA for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Sep 2009 10:11:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqSUy-0004dU-20 for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 10:07:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqSUt-0004b2-KG for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 10:07:11 -0400 Original-Received: from [199.232.76.173] (port=45412 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqSUs-0004ao-QI for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 10:07:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46065) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqSUs-0002NT-4m for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 10:07:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NE7391006850; Wed, 23 Sep 2009 07:07:04 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8NDo321003515; Wed, 23 Sep 2009 06:50:03 -0700 Resent-Date: Wed, 23 Sep 2009 06:50:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 23 Sep 2009 13:50:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4534 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4534-submit@emacsbugs.donarmstrong.com id=B4534.12537133132038 (code B ref 4534); Wed, 23 Sep 2009 13:50:03 +0000 Original-Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 13:41:53 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NDfpPm002035 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 06:41:52 -0700 Original-Received: by bwz23 with SMTP id 23so607011bwz.1 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 06:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=wV5rtmyM9RXCe0yHjpuSw/SLXwTaiQdhF81ieEcSHo8=; b=vGBe/BHHmo+MZfWfw5MBztOPVsZ8U6GwMMghFdP8FhSi8UtPT4Ckdk3PZ52l7ybU/I bOq9mq+Bnj97SOjolonkHwJr5KfMnCGAMxilgUXgs3ArmD2thVJrZL1yPLef5B4rz+xJ DaU6t/cuqXpepRr7I9rI4EASUHOUYAyRnZieM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=oo+TWIHPiT8R3wD5Xpo5yZMBA0xQkwl6vQo+BzrUP5sRgYN3WTHVL21so4ORITwUu+ psBFJagic2w2N1tnRgksQcBvxDqPXm6DXuaPTbKkMNJWIa0PJ6A2jFdt6wqnCfU4YlhV qp0v2phLj6B51pAJ9IRNZsGVr0JFfIC7c5bs4= Original-Received: by 10.239.130.31 with SMTP id 31mr198952hbh.134.1253713305205; Wed, 23 Sep 2009 06:41:45 -0700 (PDT) In-Reply-To: <4ABA12BF.8070205@gmx.at> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 23 Sep 2009 10:07:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31404 Archived-At: On Wed, Sep 23, 2009 at 14:21, martin rudalics wrote: > Would writing > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height > WINDOW_TOTAL= _LINES (w)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0freeze_wind= ow_starts (f, 1); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0grow_mini_w= indow (w, height - WINDOW_TOTAL_LINES (w)); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > instead do better? In my case, height < WINDOW_TOTAL_LINES (w) at that point (that's what triggers the xassert), so adding the above check works exactly like removing the if() altogether: it does not crash, but it does not shrink the minibuffer to 5 lines, which would be the correct height. Juanma