unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#2994: Recent change to font.c:font_load_for_lface affects variable-pitch face in the modeline
@ 2009-04-14 11:57 Juanma Barranquero
  2009-04-21  7:40 ` Kenichi Handa
  0 siblings, 1 reply; 12+ messages in thread
From: Juanma Barranquero @ 2009-04-14 11:57 UTC (permalink / raw)
  To: Emacs Bug Tracker

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

Package: emacs
X-Debbugs-CC: <handa@m17n.org>

This change affects using variable-pitch on the modeline:

--------------------------------------------------------------------------------
2009-04-13  Kenichi Handa  <handa@m17n.org>

        * font.c [...]
        (font_load_for_lface): Get a font that supports at least ASCII
        characters.

--------------------------------------------------------------------------------
@@ -3455,7 +3461,8 @@ font_load_for_lface (f, attrs, spec)
 {
   Lisp_Object entity;

-  entity = font_find_for_lface (f, attrs, spec, -1);
+  /* We assume that a font that supports 'A' supports ASCII chars.  */
+  entity = font_find_for_lface (f, attrs, spec, 'A');
   if (NILP (entity))
     {
       /* No font is listed for SPEC, but each font-backend may have
--------------------------------------------------------------------------------

Running

   emacs -Q --eval "(push '(propertize \" \" 'face 'variable-pitch)
mode-line-format)"

The attached PNGs show the difference. In both cases,

M-x describe-face variable-pitch <RET>

Face: variable-pitch (sample) (customize this face)
Documentation: The basic variable-pitch face.
Defined in `faces.el'.

        Family: Sans Serif
       Foundry: unspecified
         Width: unspecified
        Height: unspecified
        Weight: unspecified
         Slant: unspecified
    Foreground: unspecified
    Background: unspecified
     Underline: unspecified
      Overline: unspecified
Strike-through: unspecified
           Box: unspecified
       Inverse: unspecified
       Stipple: unspecified
          Font: unspecified
       Fontset: unspecified
       Inherit: unspecified

    Juanma

[-- Attachment #2: good.png --]
[-- Type: image/png, Size: 1191 bytes --]

[-- Attachment #3: bad.png --]
[-- Type: image/png, Size: 1287 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2009-04-22 12:10 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <mailman.5312.1239711841.31690.bug-gnu-emacs@gnu.org>
2009-04-14 14:21 ` bug#2994: Recent change to font.c:font_load_for_lface affects variable-pitch face in the modeline Miles Bader
2009-04-14 16:07   ` Juanma Barranquero
2009-04-14 16:40     ` Juanma Barranquero
2009-04-16  6:24     ` Kenichi Handa
2009-04-16 11:14       ` Juanma Barranquero
2009-04-16 12:14         ` Kenichi Handa
2009-04-16 14:05           ` Juanma Barranquero
2009-04-20 11:21             ` Kenichi Handa
2009-04-14 11:57 Juanma Barranquero
2009-04-21  7:40 ` Kenichi Handa
2009-04-21 12:06   ` Juanma Barranquero
2009-04-22 12:10   ` Taylor Venable

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).